Merge pull request #984 from Caliburn-Micro/alert-autofix-194

Potential fix for code scanning alert no. 194: Missed opportunity to use Where

Author: vb2ae

src/Caliburn.Micro.Platform/Platforms/uap/XamlMetadataProvider.cs

@@ -2,7 +2,7 @@
 {
     using System;
     using System.Collections.Generic;
-
+    using System.Linq;
 #if WinUI3
     using Microsoft.UI.Xaml;
     using Microsoft.UI.Xaml.Markup;
@@ -260,7 +260,8 @@ public virtual IXamlType KeyType
 
         public virtual IXamlType BoxedType => throw new NotImplementedException();
 
-        public virtual object ActivateInstance() {
+        public virtual object ActivateInstance()
+        {
             throw new NotImplementedException();
         }
 
@@ -319,7 +320,8 @@ public override IXamlType BaseType
 
         public override IXamlType BoxedType { get => _baseType; }
 
-        public override bool IsArray {
+        public override bool IsArray
+        {
             get { return _isArray; }
         }
 
@@ -410,30 +412,27 @@ public override object CreateFromString(String input)
                     Int32 enumFieldValue = 0;
                     try
                     {
+                        var trimmedValue = valuePart.Trim();
                         object partValue;
-                        if (_enumValues.TryGetValue(valuePart.Trim(), out partValue))
+                        if (_enumValues.TryGetValue(trimmedValue, out partValue))
                         {
                             enumFieldValue = Convert.ToInt32(partValue);
                         }
                         else
                         {
                             try
                             {
-                                enumFieldValue = Convert.ToInt32(valuePart.Trim());
+                                enumFieldValue = Convert.ToInt32(trimmedValue);
                             }
                             catch (FormatException)
                             {
-                                foreach (var key in _enumValues.Keys)
-                                {
-                                    if (String.Compare(valuePart.Trim(), key, StringComparison.OrdinalIgnoreCase) == 0 &&
-                                        _enumValues.TryGetValue(key.Trim(), out partValue))
-                                    {
-                                        enumFieldValue = Convert.ToInt32(partValue);
-                                        break;
-                                    }
-                                }
+                                var key = _enumValues.FirstOrDefault(kvp => String.Equals(trimmedValue, kvp.Key, StringComparison.OrdinalIgnoreCase));
+
+                                enumFieldValue = Convert.ToInt32(key.Value ?? 0);
                             }
                         }
+
+
                         value |= enumFieldValue;
                     }
                     catch (FormatException)