Firefly-416: useFieldGroupConnector was not unmounting fields properly

  - also enable wcs button to be turned off
  - added line to demonstrate removing wcs lock in gator
            - IRSA-3070 should use this example

Author: robyww

src/firefly/html/test/template.html

@@ -61,7 +61,8 @@
                     },
                     tables : {
                         showInfoButton: false // info about table : title, table links, etc.
-                    }
+                    },
+                    MenuItemKeys: {matchLockDropDown:false}
                 }
             }
         }

src/firefly/js/ui/FieldGroupConnector.jsx

@@ -191,7 +191,11 @@ export const useFieldGroupConnector= (props) => {
             if (fieldState !== gState.fields[fieldKey]) setFieldState(gState.fields[fieldKey]);
         });
     }, effectChangeAry);
-    
+
+    useEffect(() => {  // only run on dismount
+        return () => dispatchMountComponent( groupKey, fieldKey, false);
+    }, []);
+
     return {
         fireValueChange, viewProps: buildViewProps(fieldState,props,fieldKey,groupKey, value), fieldKey, groupKey
     };

src/firefly/js/visualize/MenuItemKeys.js

@@ -32,7 +32,8 @@ export const MenuItemKeys= {
     restore : 'restore',
     overlayColorLock: 'overlayColorLock',
     fitsHeader: 'fitsHeader',
-    panByTableRow: 'panByTableRow'
+    panByTableRow: 'panByTableRow',
+    matchLockDropDown: 'matchLockDropDown'
 };
 
 const defaultOff = [MenuItemKeys.lockImage, MenuItemKeys.irsaCatalog, MenuItemKeys.maskOverlay];

src/firefly/js/visualize/ui/CatalogSelectViewPanel.jsx

@@ -83,6 +83,8 @@ export class CatalogSelectViewPanel extends PureComponent {
                     width='auto' height='auto'
                     groupKey={[gkey, gkeySpacial]}
                     onSubmit={(request) => onSearchSubmit(request)}
+                    onError={(request) => onSearchFail(request)}
+                    params={{hideOnInvalid: false}}
                     onCancel={hideSearchPanel}>
                     <CatalogSelectView fields={fields}/>
                 </FormPanel>
@@ -104,17 +106,25 @@ export function validateConstraints(groupKey) {
     return true;
 }
 
+function onSearchFail() {
+    showInfoPopup('One or more fields are not valid');
+}
+
 function onSearchSubmit(request) {
-    // console.log('original request <br />' + JSON.stringify(request));
 
+    if (!catmaster) {
+        showInfoPopup('Error: Master table was not loaded.');
+        return false;
+    }
     if (request[gkey].Tabs === 'catalog') {
-        const {spatial} = request[gkeySpacial];
-        const wp = parseWorldPt(request[gkeySpacial][ServerParams.USER_TARGET_WORLD_PT]);
+        const spacPart= request[gkeySpacial] || {};
+        const {spatial} = spacPart;
+        const wp = parseWorldPt(spacPart[ServerParams.USER_TARGET_WORLD_PT]);
         if (!wp && (spatial === SpatialMethod.Cone.value
             || spatial === SpatialMethod.Box.value
             || spatial === SpatialMethod.Elliptical.value)) {
             showInfoPopup('Target is required');
-            return;
+            return false;
         }
         if (validateConstraints(gkey)) {
             doCatalog(request);
@@ -130,8 +140,10 @@ function onSearchSubmit(request) {
         doVoSearch(request[gkey], 'NED');
     }
     else {
-        console.log('request no supported');
+        showInfoPopup('Request not supported');
+        return false;
     }
+    return true;
 }
 function hideSearchPanel() {
     dispatchHideDropDown();
@@ -140,7 +152,7 @@ function hideSearchPanel() {
 function doCatalog(request) {
 
     const catPart= request[gkey];
-    const spacPart= request[gkeySpacial];
+    const spacPart= request[gkeySpacial] || {};
     const {catalog, project, cattable}= catPart;
     const {spatial='AllSky'}= spacPart;  // if there is no 'spatial' field (catalog with no position information case)
 

src/firefly/js/visualize/ui/MatchLockDropDown.jsx

@@ -34,7 +34,7 @@ const getCountWithTarget= (vr) =>
 
 
 
-export function MatchLockDropDown({visRoot:vr, enabled}) {
+export function MatchLockDropDown({visRoot:vr, enabled, visible}) {
     const {wcsMatchType}= vr;
     const wcsCnt= getCountWithWCS(vr);
     const tCnt= getCountWithTarget(vr);
@@ -124,7 +124,7 @@ export function MatchLockDropDown({visRoot:vr, enabled}) {
         <DropDownToolbarButton icon={wcsMatchType?MATCH_LOCKED:MATCH_UNLOCKED }
                                tip='Determine how to align images'
                                enabled={enabled} horizontal={true}
-                               visible={true}
+                               visible={visible}
                                hasHorizontalLayoutSep={false}
                                useDropDownIndicator={true}
                                dropDown={dropDown}/>

src/firefly/js/visualize/ui/VisToolbarView.jsx

@@ -325,7 +325,7 @@ export class VisToolbarView extends PureComponent {
                                 onClick={() => toggleOverlayColorLock(pv,plotGroupAry)}
                                  />
 
-                <MatchLockDropDown visRoot={visRoot} enabled={enabled} />
+                <MatchLockDropDown visRoot={visRoot} enabled={enabled} visible={mi.matchLockDropDown} />
 
 
                 <ToolbarButton icon={FITS_HEADER}