BUG: 'FireflyClient' object has no attribute 'show_fits_image'

[bsipocz]

I'm not sure why this started popping now, but nevertheless, here is the tracelog (I suspect maybe something else happens before these lines that doesn't produce an error so an unrelated cell will fail instead). Seeing it on the oldestdeps run, and persistent enough to produce the failure after restart in 2 hours.

https://github.com/Caltech-IPAC/irsa-tutorials/actions/runs/19221240496/job/54939630546#step:5:812

This may also very well be an upstream issue as we could pull in some newer versions for the unpinned indirect dependencies.

cc @jaladh-singhal

________________ tutorials/spherex/spherex_intro.ipynb::Cell 9 _________________
Notebook cell execution failed
Cell 9: Cell execution caused an exception

Input:
fc.show_fits_image(file_input=spectral_image_url,
             plot_id="spectral_image",
             Title="Spectral Image"
             )

Traceback:

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[1], line 1
----> 1 fc.show_fits_image(file_input=spectral_image_url,
      2              plot_id="spectral_image",
      3              Title="Spectral Image"
      4              )

AttributeError: 'FireflyClient' object has no attribute 'show_fits_image'

[jaladh-singhal]

The firefly-client version is outdated (firefly_client==3.2.0) in this job. 'show_fits_image' was added in latest release which is 3.4.0.

I couldn't find the PR/branch which triggered this to tell why it's pulling old firefly-client. Do you know?

[bsipocz]

why it's pulling old firefly-client.

Because it's the oldestdeps job.

The firefly-client version is outdated (firefly_client==3.2.0) in this job. 'show_fits_image' was added in latest release which is 3.4.0.

How did the PR that added this merged then? I mean this should have triggered failures since that change, and we definitely had passing jobs since March.

[jaladh-singhal]

How did the PR that added this merged then? I mean this should have triggered failures since that change, and we definitely had passing jobs since March.

This was recently added as I can tell from the git blame: 0aec687. Associated PR passed it seems to me but didn't put a minimum version limit on the dependency