-
Notifications
You must be signed in to change notification settings - Fork 4
Open
2 / 32 of 3 issues completedLabels
contentContent related issues/PRs.Content related issues/PRs.documentationImprovements or additions to documentationImprovements or additions to documentation
Description
This is a list of things identified during the notebook review. Some of them will have to be fixed prior data release, some can come later.
- no reason to use pyvo, we can switch to astroquery [ENH: Euclid swap pyvo for astroquery #60]
- Use astropy.units to do flux--magnitude conversions in euclid CMD #94
- we really could use more of astropy Table, none of pandas functionality I saw is specific so it's a bit counterintuitive to go back and forth. [ENH: Euclid swap pyvo for astroquery #60]
- direct use of requests and bytesIO feels a bit overkill, I think we will be able to remove it [Euclid: Simplify spectra notebook #85 and ENH: More cleanups for euclid notebooks: remove bytesIO and astropy-ify notebook 1&5 #86 ]
- there are some hard wired path pointing to personal home directory. That should be removed, even if it's just listed in a commented out cell. [Euclid: Remove irsadev urls and notes to testers #56]
- Code should be pep8-ed (more or less done in the many follow-up PRs opened after this issue. adding codestyle checks to CI is on the list, but is beyond this euclid tracking issue)
- add the whole thing into rendering [Euclid rendering #52]
- revise headings
- cleanup irsadev URLs and all testing notes [Euclid: Remove irsadev urls and notes to testers #56]
- make variable names (like
img_tbl
) descriptive in the cloud notebook
These can only be done after the data release is public:
- add the whole thing into CI [CI: Adding notebooks to the CI #61]
Relies on astroquery 0.4.10
- remove the
to_table()
calls for list_catalogs/query_sia/etc calls as we will be returning astropy Tables instead of pyvo classes (Updating tutorials with new astroquery features #57 )
For Euclid ERO notebook:
- Use astropy.units for flux conversions
- would be nice to use less mpl upfront customization and have a central mpl style if needed.
- pep8 code clean
- have OS agnostic code. CI is not yet enabled and I would not be surprised if windows would be upset
- progress bar is not progressing when locally running notebook, nor it does anything pretty in rendering, consider removing it, and progress bar from photutils looks very ugly so we definitely need to remove it
- review comments in ENH: adding Euclid ERO notebook #55 (review)
cc @jaladh-singhal - add any referred items into this list. Alternatively open a subissue
jaladh-singhal
Sub-issues
Metadata
Metadata
Assignees
Labels
contentContent related issues/PRs.Content related issues/PRs.documentationImprovements or additions to documentationImprovements or additions to documentation