Skip to content

Commit c9b136b

Browse files
Merge pull request #1575 from TheooJ/invert_confidence_intervals
switch confidence interval values
2 parents 716b204 + 2abf0dd commit c9b136b

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

lifelines/fitters/breslow_fleming_harrington_fitter.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,14 @@ def fit(
7272
alpha = coalesce(alpha, self.alpha)
7373

7474
naf = NelsonAalenFitter(alpha=alpha)
75-
naf.fit(durations, event_observed=event_observed, timeline=timeline, label=self._label, entry=entry, ci_labels=ci_labels)
75+
naf.fit(
76+
durations,
77+
event_observed=event_observed,
78+
timeline=timeline,
79+
label=self._label,
80+
entry=entry,
81+
ci_labels=ci_labels,
82+
)
7683
self.durations, self.event_observed, self.timeline, self.entry, self.event_table, self.weights = (
7784
naf.durations,
7885
naf.event_observed,
@@ -87,6 +94,7 @@ def fit(
8794
self.confidence_interval_ = np.exp(-naf.confidence_interval_)
8895
self.confidence_interval_survival_function_ = self.confidence_interval_
8996
self.confidence_interval_cumulative_density = 1 - self.confidence_interval_
97+
self.confidence_interval_cumulative_density[:] = np.fliplr(self.confidence_interval_cumulative_density.values)
9098

9199
# estimation methods
92100
self._estimation_method = "survival_function_"

lifelines/fitters/kaplan_meier_fitter.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -351,9 +351,14 @@ def _fit(
351351
primary_estimate_name = "survival_function_"
352352
secondary_estimate_name = "cumulative_density_"
353353

354-
(self.durations, self.event_observed, self.timeline, self.entry, self.event_table, self.weights) = _preprocess_inputs(
355-
durations, event_observed, timeline, entry, weights
356-
)
354+
(
355+
self.durations,
356+
self.event_observed,
357+
self.timeline,
358+
self.entry,
359+
self.event_table,
360+
self.weights,
361+
) = _preprocess_inputs(durations, event_observed, timeline, entry, weights)
357362

358363
alpha = alpha if alpha else self.alpha
359364
log_estimate, cumulative_sq_ = _additive_estimate(
@@ -386,6 +391,7 @@ def _fit(
386391

387392
self.confidence_interval_survival_function_ = self.confidence_interval_
388393
self.confidence_interval_cumulative_density_ = 1 - self.confidence_interval_
394+
self.confidence_interval_cumulative_density_[:] = np.fliplr(self.confidence_interval_cumulative_density_.values)
389395
self._median = median_survival_times(self.survival_function_)
390396
self._cumulative_sq_ = cumulative_sq_
391397

0 commit comments

Comments
 (0)