-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Labels
Hacktoberfest(◡ ‿ ◡ ✿) 2019(◡ ‿ ◡ ✿) 2019configurationProject's general configurationProject's general configurationgood first issueGood for newcomersGood for newcomers
Description
In the utils server we are using too many custom functions for the magazines fake data. We could replace that using the fake-data-generator as a dev-dependency.
Current models: please respect the current type of each property
magazine: {
id: Number, // faker random number
name: String, // faker random words
articles: Array, // Please delete this one
issue: String, // faker random numbers with a '#' prefix
publisher: String // faker random words
}Checkpoints:
- Run the e2e tests, they should pass.
- Run the unit tests, they should pass.
- Magazines service: Replace ipsum dependency with fake-data-generator. Replace the magazines array with a new fake-data-generator model of 40 items (don't worry about the articles array property in each magazine, we don't need it anymore)
- Rerun e2e tests, they must pass.
- Rerun unit tests, they must pass.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Hacktoberfest(◡ ‿ ◡ ✿) 2019(◡ ‿ ◡ ✿) 2019configurationProject's general configurationProject's general configurationgood first issueGood for newcomersGood for newcomers