Merge pull request #254 from CambrianTech/fix/widget-routing-infinite-loop

Fix widget routing infinite loop and room switching

Author: joelteply

src/debug/jtag/browser/generated.ts

@@ -1,7 +1,7 @@
 /**
  * Browser Structure Registry - Auto-generated
  *
- * Contains 11 daemons and 133 commands and 2 adapters and 26 widgets.
+ * Contains 11 daemons and 139 commands and 2 adapters and 26 widgets.
  * Generated by scripts/generate-structure.ts - DO NOT EDIT MANUALLY
  */
 
@@ -19,6 +19,9 @@ import { UserDaemonBrowser } from './../daemons/user-daemon/browser/UserDaemonBr
 import { WidgetDaemonBrowser } from './../daemons/widget-daemon/browser/WidgetDaemonBrowser';
 
 // Browser commands Imports
+import { AdapterAdoptBrowserCommand } from './../commands/adapter/adopt/browser/AdapterAdoptBrowserCommand';
+import { AdapterSearchBrowserCommand } from './../commands/adapter/search/browser/AdapterSearchBrowserCommand';
+import { AdapterTryBrowserCommand } from './../commands/adapter/try/browser/AdapterTryBrowserCommand';
 import { BagOfWordsBrowserCommand } from './../commands/ai/bag-of-words/browser/BagOfWordsBrowserCommand';
 import { AICostBrowserCommand } from './../commands/ai/cost/browser/AICostBrowserCommand';
 import { AiDetectSemanticLoopBrowserCommand } from './../commands/ai/detect-semantic-loop/browser/AiDetectSemanticLoopBrowserCommand';
@@ -51,6 +54,7 @@ import { DecisionProposeBrowserCommand } from './../commands/collaboration/decis
 import { DecisionRankBrowserCommand } from './../commands/collaboration/decision/rank/browser/DecisionRankBrowserCommand';
 import { DecisionViewBrowserCommand } from './../commands/collaboration/decision/view/browser/DecisionViewBrowserCommand';
 import { DecisionVoteBrowserCommand } from './../commands/collaboration/decision/vote/browser/DecisionVoteBrowserCommand';
+import { DmBrowserCommand } from './../commands/collaboration/dm/browser/DmBrowserCommand';
 import { WallListBrowserCommand } from './../commands/collaboration/wall/list/browser/WallListBrowserCommand';
 import { WallReadBrowserCommand } from './../commands/collaboration/wall/read/browser/WallReadBrowserCommand';
 import { WallWriteBrowserCommand } from './../commands/collaboration/wall/write/browser/WallWriteBrowserCommand';
@@ -99,6 +103,7 @@ import { GenomeJobCreateBrowserCommand } from './../commands/genome/job-create/b
 import { GenomeJobStatusBrowserCommand } from './../commands/genome/job-status/browser/GenomeJobStatusBrowserCommand';
 import { HelpBrowserCommand } from './../commands/help/browser/HelpBrowserCommand';
 import { IndicatorBrowserCommand } from './../commands/indicator/browser/IndicatorBrowserCommand';
+import { InferenceGenerateBrowserCommand } from './../commands/inference/generate/browser/InferenceGenerateBrowserCommand';
 import { ClickBrowserCommand } from './../commands/interface/click/browser/ClickBrowserCommand';
 import { GetTextBrowserCommand } from './../commands/interface/get-text/browser/GetTextBrowserCommand';
 import { NavigateBrowserCommand } from './../commands/interface/navigate/browser/NavigateBrowserCommand';
@@ -116,6 +121,7 @@ import { LogsSearchBrowserCommand } from './../commands/logs/search/browser/Logs
 import { LogsStatsBrowserCommand } from './../commands/logs/stats/browser/LogsStatsBrowserCommand';
 import { MediaProcessBrowserCommand } from './../commands/media/process/browser/MediaProcessBrowserCommand';
 import { MediaResizeBrowserCommand } from './../commands/media/resize/browser/MediaResizeBrowserCommand';
+import { PersonaGenomeBrowserCommand } from './../commands/persona/genome/browser/PersonaGenomeBrowserCommand';
 import { GenomeCaptureFeedbackBrowserCommand } from './../commands/persona/learning/capture-feedback/browser/GenomeCaptureFeedbackBrowserCommand';
 import { GenomeCaptureInteractionBrowserCommand } from './../commands/persona/learning/capture-interaction/browser/GenomeCaptureInteractionBrowserCommand';
 import { GenomeMultiAgentLearnBrowserCommand } from './../commands/persona/learning/multi-agent-learn/browser/GenomeMultiAgentLearnBrowserCommand';
@@ -253,6 +259,21 @@ export const BROWSER_DAEMONS: DaemonEntry[] = [
 ];
 
 export const BROWSER_COMMANDS: CommandEntry[] = [
+{
+    name: 'adapter/adopt',
+    className: 'AdapterAdoptBrowserCommand',
+    commandClass: AdapterAdoptBrowserCommand
+  },
+{
+    name: 'adapter/search',
+    className: 'AdapterSearchBrowserCommand',
+    commandClass: AdapterSearchBrowserCommand
+  },
+{
+    name: 'adapter/try',
+    className: 'AdapterTryBrowserCommand',
+    commandClass: AdapterTryBrowserCommand
+  },
 {
     name: 'ai/bag-of-words',
     className: 'BagOfWordsBrowserCommand',
@@ -413,6 +434,11 @@ export const BROWSER_COMMANDS: CommandEntry[] = [
     className: 'DecisionVoteBrowserCommand',
     commandClass: DecisionVoteBrowserCommand
   },
+{
+    name: 'collaboration/dm',
+    className: 'DmBrowserCommand',
+    commandClass: DmBrowserCommand
+  },
 {
     name: 'collaboration/wall/list',
     className: 'WallListBrowserCommand',
@@ -653,6 +679,11 @@ export const BROWSER_COMMANDS: CommandEntry[] = [
     className: 'IndicatorBrowserCommand',
     commandClass: IndicatorBrowserCommand
   },
+{
+    name: 'inference/generate',
+    className: 'InferenceGenerateBrowserCommand',
+    commandClass: InferenceGenerateBrowserCommand
+  },
 {
     name: 'interface/click',
     className: 'ClickBrowserCommand',
@@ -738,6 +769,11 @@ export const BROWSER_COMMANDS: CommandEntry[] = [
     className: 'MediaResizeBrowserCommand',
     commandClass: MediaResizeBrowserCommand
   },
+{
+    name: 'persona/genome',
+    className: 'PersonaGenomeBrowserCommand',
+    commandClass: PersonaGenomeBrowserCommand
+  },
 {
     name: 'persona/learning/capture-feedback',
     className: 'GenomeCaptureFeedbackBrowserCommand',

src/debug/jtag/cli.ts

@@ -108,7 +108,9 @@ async function main() {
     const [command, ...rawParams] = commandArgs;
 
     // Parse parameters into object format
-    const params: Record<string, string | boolean | number> = {};
+    // ParsedValue supports primitives, arrays (for repeated flags), and objects (for complex params)
+    type ParsedValue = string | boolean | number | null | ParsedValue[] | { [key: string]: ParsedValue };
+    const params: Record<string, ParsedValue> = {};
     let i = 0;
     while (i < rawParams.length) {
       const arg = rawParams[i];
@@ -209,17 +211,18 @@ async function main() {
         i++;
       } else {
         // Handle positional arguments - add them to a general array
-        if (!params._positional) {
+        if (!params._positional || !Array.isArray(params._positional)) {
           params._positional = [];
         }
-        params._positional.push(arg);
+        (params._positional as ParsedValue[]).push(arg);
         i++;
       }
     }
 
     // Handle positional arguments for single-parameter commands
     // This allows `./jtag help screenshot` instead of `./jtag help commandName=screenshot`
-    if (params._positional && params._positional.length > 0) {
+    const positional = params._positional;
+    if (Array.isArray(positional) && positional.length > 0) {
       // Map of commands to their primary parameter name
       const singleParamCommands: Record<string, string> = {
         'help': 'commandName',
@@ -236,20 +239,27 @@ async function main() {
       const primaryParam = singleParamCommands[command];
       if (primaryParam && !params[primaryParam]) {
         // Use first positional arg as the primary parameter
-        params[primaryParam] = params._positional[0];
+        params[primaryParam] = positional[0] as ParsedValue;
         // Remove from positional array
-        params._positional = params._positional.slice(1);
-        if (params._positional.length === 0) {
+        params._positional = positional.slice(1);
+        if ((params._positional as ParsedValue[]).length === 0) {
           delete params._positional;
         }
       }
     }
 
     // INTELLIGENT ENTRY POINT: Adapts behavior based on detected agent type
+    type OutputFormat = 'json' | 'human' | 'auto' | 'compact' | 'ai-friendly';
+    const formatValue = params.format as string | undefined;
+    const validFormats: OutputFormat[] = ['json', 'human', 'auto', 'compact', 'ai-friendly'];
+    const format: OutputFormat = (formatValue && validFormats.includes(formatValue as OutputFormat))
+      ? formatValue as OutputFormat
+      : 'auto';
+
     const entryPoint = new EntryPointAdapter({
-      verbose: params.verbose,
-      quiet: params.quiet,
-      format: params.format || 'auto',
+      verbose: params.verbose as boolean | undefined,
+      quiet: params.quiet as boolean | undefined,
+      format,
       showAgentInfo: !params.quiet
     });
 
@@ -290,7 +300,7 @@ async function main() {
     }
 
     const clientOptions: JTAGClientConnectOptions = {
-      targetEnvironment: 'server', 
+      targetEnvironment: 'server',
       transportType: 'websocket',
       serverUrl: `ws://localhost:${instanceConfig.ports.websocket_server}`,
       enableFallback: false,
@@ -300,8 +310,7 @@ async function main() {
         cli: {
           command,
           args: commandArgs,
-          timestamp: new Date().toISOString(),
-          sessionPersistence: sessionId ? 'reused' : 'new'
+          timestamp: new Date().toISOString()
         }
       }
     };
@@ -326,7 +335,7 @@ async function main() {
 
       const isConnectionRefused = connectionError.message.includes('ECONNREFUSED') ||
                                 connectionError.message.includes('connect') ||
-                                (err && typeof err === 'object' && 'code' in err && err.code === 'ECONNREFUSED');
+                                (err && typeof err === 'object' && 'code' in err && (err as {code?: string}).code === 'ECONNREFUSED');
 
       if (behavior.logLevel === 'verbose') {
         console.log('='.repeat(60));
@@ -337,7 +346,7 @@ async function main() {
           console.error('✅ IMMEDIATE ACTION: Run "npm start" and wait 60 seconds');
         } else {
           console.error('🔍 Connection details:', connectionError.message);
-          console.error('🔍 Error code:', connectionError.code || 'unknown');
+          console.error('🔍 Error code:', (connectionError as Error & {code?: string}).code || 'unknown');
         }
       } else {
         // Clean JSON error for connection failures - send to stderr
@@ -373,10 +382,12 @@ async function main() {
       // AI commands need longer timeout due to queue + generation time
       // Genome commands can take longer for training operations
       // Interface commands (screenshot) may need to wait for html2canvas rendering
+      // Inference commands (inference/generate) need time for local model generation
       const isAICommand = command.startsWith('ai/');
       const isGenomeCommand = command.startsWith('genome/');
       const isInterfaceCommand = command.startsWith('interface/');
-      const timeoutMs = isGenomeCommand ? 300000 : isAICommand ? 60000 : isInterfaceCommand ? 60000 : 10000; // 5min for genome, 60s for AI/interface, 10s for others
+      const isInferenceCommand = command.startsWith('inference/');
+      const timeoutMs = isGenomeCommand ? 300000 : (isAICommand || isInferenceCommand) ? 60000 : isInterfaceCommand ? 60000 : 10000; // 5min for genome, 60s for AI/inference/interface, 10s for others
       const timeoutSeconds = timeoutMs / 1000;
 
       const commandTimeout = new Promise((_, reject) =>
@@ -407,18 +418,22 @@ async function main() {
 
       // Special parameter transformation for screenshot command
       if (command === 'screenshot') {
+        // Ensure options is an object
+        if (!params.options || typeof params.options !== 'object' || Array.isArray(params.options)) {
+          params.options = {};
+        }
+        const options = params.options as { [key: string]: ParsedValue };
+
         // Convert comma-separated presets to array
         if (params.presets && typeof params.presets === 'string') {
-          params.options = params.options || {};
-          params.options.presets = params.presets.split(',').map((p: string) => p.trim());
+          options.presets = params.presets.split(',').map((p: string) => p.trim());
           delete params.presets;
         }
-        
+
         // Convert comma-separated resolutions to array (if provided as JSON string)
         if (params.resolutions && typeof params.resolutions === 'string') {
           try {
-            params.options = params.options || {};
-            params.options.resolutions = JSON.parse(params.resolutions);
+            options.resolutions = JSON.parse(params.resolutions);
             delete params.resolutions;
           } catch (e) {
             console.warn(`⚠️ Invalid resolutions JSON: ${params.resolutions}`);

src/debug/jtag/commands/adapter/adopt/.npmignore

@@ -0,0 +1,20 @@
+# Development files
+.eslintrc*
+tsconfig*.json
+vitest.config.ts
+
+# Build artifacts
+*.js.map
+*.d.ts.map
+
+# IDE
+.vscode/
+.idea/
+
+# Logs
+*.log
+npm-debug.log*
+
+# OS files
+.DS_Store
+Thumbs.db