ExportTilesetDefinitionLinux.sh not being run correctly?

[sommerper]

Hi!

I'm trying to get the plugin to work on Linux (PopOS) and it seems the command was added correctly to the ldtk file. The command inside the .sh file also points towards a working mono command.

I've restarted both Unity and ldtk but I still get this error. Is there something else I could try to make it work?

[Cammin]

I can't personally test this OS so it's tricky for me. But, I'm willing to help hands-on in the discord server.

I've had other Mac/Linux users help me with their issues, but maybe there's something else to clear up here 🙂

[sommerper]

I'll see if I have time for Discord at some point =)

But as far as I can see in LDtkEditorCommandUpdater.cs

You want $1 to be a part of the command on mac an linux

LDtkToUnity/Assets/LDtkUnity/Editor/CustomEditor/Importer/LDtkEditorCommandUpdater.cs

Line 29 in 885860c

Command += $" $1";

like so

../../../Library/LDtkTilesetExporter/ExportTilesetDefinitionLinux.sh "test_level" $1

but later you check if the split.length is not 2

LDtkToUnity/Assets/LDtkUnity/Editor/CustomEditor/Importer/LDtkEditorCommandUpdater.cs

Line 296 in 885860c

if (split.Length != 2 || split[1] != $"\"{ProjectName}\"")

Which it is not because with the added $1 it would be 3

So if I change the check to 3 it works.

But after some testing it seems like it really doesn't matter if the custom command in ldtk
is ../../../Library/LDtkTilesetExporter/ExportTilesetDefinitionLinux.sh "test_level" $1 or ../../../Library/LDtkTilesetExporter/ExportTilesetDefinitionLinux.sh "test_level"

it works either way and I can drag the level to the scene.

Thanks for the quick reply!

[Cammin]

Yeah, it is possible that it might be improperly thinking there is a problem when there is not, and so it shows that error dialog

[sommerper]

I could make some changes (i.e. pull request if you're accepting those) so that it works better on linux and mac.

I would also like to rename the .sh file to ../../../Library/LDtkTilesetExporter/ExportTilesetDefinition.sh - omitting the Mac/Linux part so that you can work on both systems at the same time.

Right now I'm switching between Linux and Mac and I have to update the path in ldtk every time which is not super convenient.

[Haelle]

I'm using LDtk2Unity and it's working fine, the "fix" button generate the right command but the warning stays, I didn't figured out why thanks for the investigation.

cf #59 it wasn't working before 6.4.6

[Cammin]

It's definitely a string comparison issue, it thinks there is a problem when it shouldn't be