Fix to replace EOItemLinksS3Bucket name since it may not be created if bucket creation is set to false

Author: bo-lu

docs/cloudformation/geocore-eo-rcm-ard-harvester.yml

@@ -117,7 +117,7 @@ Resources:
         Variables:
           GEOCORE_TEMPLATE_BUCKET_NAME:  !Sub 'webpresence-geocore-template-${Environment}'
           GEOCORE_TEMPLATE_NAME: 'geocore-format-null-template.json'
-          ITEM_LINK_BUCKET_NAME: !Ref EOItemLinksS3Bucket
+          ITEM_LINK_BUCKET_NAME: !Sub 'eo-sg-datacube-item-links-${Environment}'
           PROCESSED_DATA_BUCKET_NAME: !Ref ProcessedDataS3Bucket
           API_ROOT: 'https://www.eodms-sgdot.nrcan-rncan.gc.ca/stac'
           ROOT_NAME: 'EODMS Datacube API / EODMS Cube de données API'
@@ -260,7 +260,7 @@ Resources:
       MemorySize: 4096
       Environment:
         Variables:
-          ITEM_LINK_BUCKET_NAME: !Ref EOItemLinksS3Bucket
+          ITEM_LINK_BUCKET_NAME: !Sub 'eo-sg-datacube-item-links-${Environment}'
           JSON_FILENAME: 'rcm-ard-item-api.json'
           SG_PROCESSES_TABLE_NAME: !Ref SGRCMARDProcessesTableName
           SG_AGGREGATE_TABLE_NAME: !Ref SGRCMARDAggregateTableName