Integrated peer comments

Can delete a layer that's not existing (only existing through the config)

Author: Alex-NRCan

packages/geoview-core/src/api/event-processors/abstract-event-processor.ts

@@ -203,9 +203,9 @@ export abstract class AbstractEventProcessor {
   /**
    * Helper function to delete a layer information from an array when found.
    *
-   * @param {T[]} layerArray - The layer array to work with
-   * @param {string} layerPath - The layer path to delete
-   * @param {(layerArray: T[]) => void} onDeleteCallback - The callback executed when the array is updated
+   * @param layerArray - The layer array to work with
+   * @param layerPath - The layer path to delete
+   * @param onDeleteCallback - The callback executed when the array is updated
    */
   protected static helperDeleteFromArray<T extends TypeResultSetEntry>(
     layerArray: T[],

packages/geoview-core/src/api/event-processors/event-processor-children/legend-event-processor.ts

@@ -1208,16 +1208,18 @@ export class LegendEventProcessor extends AbstractEventProcessor {
       existingJob.delayedJob.cancel();
     }
 
-    // Get the layer
+    // Get the layer api
     const layerApi = MapEventProcessor.getMapViewerLayerAPI(mapId);
-    const gvLayer = layerApi.getGeoviewLayer(layerPath);
+
+    // Get the layer if it exists, it's possible it doesn't exist if the layer failed to process
+    const gvLayer = layerApi.getGeoviewLayerIfExists(layerPath);
 
     // Note the original visibility state of the layer before starting the deletion process.
     // If there was already a pending deletion, preserve its original visibility since the layer is already hidden.
-    const originalVisibility = existingJob?.originalVisibility ?? gvLayer.getVisible();
+    const originalVisibility = existingJob?.originalVisibility ?? gvLayer?.getVisible() ?? false;
 
     // Hide layer immediately
-    gvLayer.setVisible(false);
+    gvLayer?.setVisible(false);
     layerApi.removeLayerHighlights(layerPath);
 
     // Update the store with the start time of the deletion of the layer
@@ -1252,8 +1254,7 @@ export class LegendEventProcessor extends AbstractEventProcessor {
     }
 
     // Undo deletion — restore original visibility
-    const gvLayerIfExists = layerApi.getGeoviewLayerIfExists(layerPath);
-    gvLayerIfExists?.setVisible(originalVisibility);
+    gvLayer?.setVisible(originalVisibility);
 
     // Negative
     return false;