Skip to content

Commit a3458a3

Browse files
committed
fix: imploding filter values with array size 1 will show warning
1 parent 1959426 commit a3458a3

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

src/Service/OutputCacheService.php

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -462,20 +462,16 @@ private function getImplodedFilterValues(array $variables): string
462462
foreach ($filters as $filter) {
463463
if (array_key_exists('values', $filter)) {
464464
if (is_array($filter['values'])) {
465-
if (count($filter['values']) > 1) {
466-
$valueList = [];
467-
foreach ($filter['values'] as $filterValue) {
468-
if (is_array($filterValue)) {
469-
$valueList[] = key($filterValue) . '-' . $filterValue[key($filterValue)];
470-
} else {
471-
$valueList[] = ($filter['field'] ?? 'unknown-field') . '-' . implode('-', $filter['values']);
472-
break;
473-
}
465+
$valueList = [];
466+
foreach ($filter['values'] as $filterValue) {
467+
if (is_array($filterValue)) {
468+
$valueList[] = key($filterValue) . '-' . $filterValue[key($filterValue)];
469+
} else {
470+
$valueList[] = ($filter['field'] ?? 'unknown-field') . '-' . implode('-', $filter['values']);
471+
break;
474472
}
475-
$filterValues[] = implode($valueList);
476-
} else {
477-
$filterValues[] = ($filter['field'] ?? 'unknown-field') . '-' . implode('-', $filter['values']);
478473
}
474+
$filterValues[] = implode($valueList);
479475
} else {
480476
$filterValues[] = ($filter['field'] ?? 'unknown-field') . '-' . $filter['values'];
481477
}

0 commit comments

Comments
 (0)