Skip to content

Complete MATLAB test suite #245

@ischoegl

Description

@ischoegl

Abstract

At the moment, there are no tests for oneD , and several tests for zeroD are filtered, i.e.,

     ctTestFlowDevice/testMFC                                         X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowDevice/testMFCErrors                                   X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowDevice/testValve3                                      X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowDevice/testValveTiming                                 X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowDevice/testPressureController                          X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowReactor1/testNonReacting                               X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowReactor1/testReacting                                  X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowReactor1/testCatalyticSurface                          X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowReactor1/testComponentNames                            X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowReactor2/testNoMassFlowRate                            X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowReactor2/testMaxSteps                                  X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowReactor2/testMaxTimeStep                               X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowReactor2/testIterationLimits                           X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowReactor2/testSolverOrder                               X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowReactor2/testReinitialization                          X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestFlowReactor2/testInitialConditionTolerances                X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestPureFluid/testTPQ                                          X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestPureFluid/testPhaseOfMatter                                X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestPureFluid/testWaterBackends                                X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestReactor/testHeatTransfer2                                  X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestReactor/testWallVelocity                                   X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestReactor/testHeatFluxFunc                                   X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestReactor/testReinitialize                                   X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestReactor/testPreconditionerUnsupported                      X       Filtered by assumption.
    --------------------------------------------------------------------------------------------------
     ctTestWellStirredReactor/testSteadyState                         X       Filtered by assumption.

PS: There also are several utility functions that are not covered, e.g., ct.version and ct.gitCommit

Motivation

Describe the need for the proposed change:

  • What problem is it trying to solve? ... resolve temporary 'band-aid' fixes
  • Who is affected by the change? ... MATLAB users
  • Why is this a good solution? ... the MATLAB toolbox is getting very close to stable

Possible Solutions

Addressing filtered tests is likely straightforward. Adding the missing oneD tests will take some work.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions