some cleanups

Author: ameer2468

apps/web/actions/organization/upload-organization-icon.ts

@@ -48,7 +48,6 @@ export async function uploadOrganizationIcon(
 		throw new Error("File must be an image");
 	}
 
-	// Validate file size (limit to 2MB)
 	if (file.size > MAX_FILE_SIZE_BYTES) {
 		throw new Error("File size must be less than 1MB");
 	}

apps/web/app/(org)/dashboard/settings/account/Settings.tsx

@@ -89,10 +89,7 @@ export const Settings = ({
 		return () => window.removeEventListener("beforeunload", handleBeforeUnload);
 	}, [hasChanges]);
 
-	const {
-		mutate: uploadProfileImageMutation,
-		isPending: isUploadingProfileImage,
-	} = useMutation({
+	const uploadProfileImageMutation = useMutation({
 		mutationFn: async (file: File) => {
 			const formData = new FormData();
 			formData.append("image", file);
@@ -116,10 +113,7 @@ export const Settings = ({
 		},
 	});
 
-	const {
-		mutate: removeProfileImageMutation,
-		isPending: isRemovingProfileImage,
-	} = useMutation({
+	const removeProfileImageMutation = useMutation({
 		mutationFn: removeProfileImage,
 		onSuccess: (result) => {
 			if (result.success) {
@@ -140,21 +134,22 @@ export const Settings = ({
 	});
 
 	const isProfileImageMutating =
-		isUploadingProfileImage || isRemovingProfileImage;
+		uploadProfileImageMutation.isPending ||
+		removeProfileImageMutation.isPending;
 
 	const handleProfileImageChange = (file: File | null) => {
 		if (!file || isProfileImageMutating) {
 			return;
 		}
-		uploadProfileImageMutation(file);
+		uploadProfileImageMutation.mutate(file);
 	};
 
 	const handleProfileImageRemove = () => {
 		if (isProfileImageMutating) {
 			return;
 		}
 		setProfileImageOverride(null);
-		removeProfileImageMutation();
+		removeProfileImageMutation.mutate();
 	};
 
 	return (
@@ -177,8 +172,8 @@ export const Settings = ({
 						onChange={handleProfileImageChange}
 						onRemove={handleProfileImageRemove}
 						disabled={isProfileImageMutating}
-						isUploading={isUploadingProfileImage}
-						isRemoving={isRemovingProfileImage}
+						isUploading={uploadProfileImageMutation.isPending}
+						isRemoving={removeProfileImageMutation.isPending}
 					/>
 				</Card>
 				<Card className="space-y-4">

apps/web/app/(org)/dashboard/settings/account/components/ProfileImage.tsx

@@ -45,11 +45,12 @@ export function ProfileImage({
 			toast.error("File size must be 1MB or less");
 			return;
 		}
-		if (file && file.size <= sizeLimit) {
-			const objectUrl = URL.createObjectURL(file);
-			setPreviewUrl(objectUrl);
-			onChange?.(file);
+		if (previewUrl && previewUrl !== initialPreviewUrl) {
+			URL.revokeObjectURL(previewUrl);
 		}
+		const objectUrl = URL.createObjectURL(file);
+		setPreviewUrl(objectUrl);
+		onChange?.(file);
 	};
 
 	const handleRemove = () => {