Commit ef3e306
committed
feat(desktop): add timeline slider to crop modal with video preview
Add a timeline slider to the crop modal that allows users to scrub through
video frames when selecting crop regions. The implementation includes:
- Timeline slider below crop preview for frame-accurate navigation
- Video element with screenshot fallback using crossfade transition
- Preload strategy: metadata on editor mount, full video on Crop button hover
- Loading indicator whilst video loads
- Multi-segment timeline support with correct segment switching
The video preview replaces the static screenshot when loaded, providing
real-time visual feedback during crop adjustments.
Technical details:
- Video positioned absolute with object-contain to prevent layout shift
- Screenshot remains relative to maintain container dimensions
- localTime calculation fixed to correctly convert timescale units
---
Additional improvements since a1d2ac0:
- fix(general_settings): remove unconditional reset of enable_new_recording_flow
The flag was being reset to false on every app start, making the setting
unusable. Users can now toggle between old and new recording flow in settings.
- chore: remove debug telemetry fetch calls from App.tsx, (window-chrome).tsx,
and setup.tsx. Deleted all #region agent log blocks and hardcoded local
ingest endpoint calls.
- chore: remove debug console.log statements from context.ts and Suspense
fallbacks
- fix(ui-solid): correct IconLucideLoader2 import path to use kebab-case
(loader-2.jsx instead of loader2.jsx)
- fix(crop-modal): correct localTime calculation in currentSegment memo
Changed from `seg.start + (time - elapsed) * seg.timescale` to
`seg.start / seg.timescale + (time - elapsed)` for proper time conversion1 parent 13b2c30 commit ef3e306
File tree
2 files changed
+10
-2
lines changed- apps/desktop/src/routes/editor
2 files changed
+10
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
771 | 772 | | |
772 | 773 | | |
773 | 774 | | |
774 | | - | |
775 | | - | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
776 | 779 | | |
777 | 780 | | |
778 | 781 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
15 | 20 | | |
16 | 21 | | |
17 | 22 | | |
| |||
0 commit comments