remove unused funcitonality

Author: CapsAdmin

nattlua/analyzer/control_flow.lua

@@ -11,6 +11,11 @@ local debug_getinfo = _G.debug.getinfo
 -- this turns out to be really hard so I'm trying 
 -- naive approaches while writing tests
 return function(META)
+	META:AddInitializer(function(self)
+		self.call_stack_map = {}
+		self.recursively_called = {}
+	end)
+
 	function META:AnalyzeStatements(statements)
 		for _, statement in ipairs(statements) do
 			self:AnalyzeStatement(statement)
@@ -402,9 +407,7 @@ return function(META)
 		end
 
 		function META:PushCallFrame(obj, call_node, not_recursive_call)
-			self.call_stack_map = self.call_stack_map or {}
-
-			if obj.recursively_called then return obj.recursively_called end
+			if self.recursively_called[obj] then return self.recursively_called[obj] end
 
 			if
 				self:IsRuntime() and
@@ -416,13 +419,13 @@ return function(META)
 				if self.call_stack_map[call_node] then
 					if obj:IsExplicitOutputSignature() then
 						-- so if we have explicit return types, just return those
-						obj.recursively_called = obj:GetOutputSignature():Copy()
-						return obj.recursively_called
+						self.recursively_called[obj] = obj:GetOutputSignature():Copy()
+						return self.recursively_called[obj]
 					else
 						-- if not we sadly have to resort to any
 						-- TODO: error?
-						obj.recursively_called = Tuple():AddRemainder(Tuple({Any()}):SetRepeat(math_huge))
-						return obj.recursively_called
+						self.recursively_called[obj] = Tuple():AddRemainder(Tuple({Any()}):SetRepeat(math_huge))
+						return self.recursively_called[obj]
 					end
 				end
 			end

nattlua/analyzer/operators/function_call_body.lua

@@ -442,8 +442,6 @@ return function(self, obj, input)
 	self:ClearScopedTrackedObjects(scope)
 	self:PopStashedTrackedChanges()
 	restore_mutated_types(self)
-	-- used for analyzing side effects
-	obj:AddScope(scope)
 
 	-- if the function is untyped we warn about untyped arguments
 	-- and we also merge merge the input into the function's input signature

nattlua/types/function.lua

@@ -11,7 +11,6 @@ local META = require("nattlua.types.base")()
 --[[#type META.@Name = "TFunction"]]
 --[[#type TFunction = META.@Self]]
 --[[#type TFunction.scopes = List<|any|>]]
---[[#type TFunction.scope = any]]
 --[[#type TFunction.suppress = boolean]]
 META.Type = "function"
 META:IsSet("Called", false)
@@ -201,34 +200,6 @@ function META.IsCallbackSubsetOf(a--[[#: TFunction]], b--[[#: TFunction]])
 	return true
 end
 
-do
-	function META:AddScope(scope--[[#: any]])
-		table.insert(self.scopes, scope)
-	end
-
-	function META:GetSideEffects()
-		local out = {}
-
-		for _, scope in ipairs(self.scopes) do
-			for _, val in ipairs(scope:GetDependencies()) do
-				if (val.Type == "upvalue" and val:GetScope() or val.scope) ~= scope then
-					table.insert(out, val)
-				end
-			end
-		end
-
-		return out
-	end
-
-	function META:GetCallCount()
-		return #self.scopes
-	end
-
-	function META:IsPure()
-		return #self:GetSideEffects() == 0
-	end
-end
-
 function META:HasReferenceTypes()
 	for i, v in ipairs(self:GetInputSignature():GetData()) do
 		if self:IsInputModifier(i, "ref") then return true end
@@ -281,11 +252,8 @@ function META.New(input--[[#: TTuple]], output--[[#: TTuple]])
 			ExplicitOutputSignature = false,
 			ArgumentsInferred = false,
 			PreventInputArgumentExpansion = false,
-			scopes = {},
-			scope = false,
 			InputSignature = input or false,
 			OutputSignature = output or false,
-			recursively_called = false,
 			AnalyzerFunction = false,
 			FunctionBodyNode = false,
 			Upvalue = false,