improvements to camera swap

set it as a doubleclick action (corresponds to the quick access option, view/unview camera)

it saves the old view position (relative if using follow entity) so that when returning to editor view, we return to the same position

Author: pingu7867

lua/pac3/core/client/parts/camera.lua

@@ -6,6 +6,8 @@ PART.ClassName = "camera"
 PART.Group = 'entity'
 PART.Icon = 'icon16/camera.png'
 
+PART.ImplementsDoubleClickSpecified = true
+
 BUILDER:StartStorableVars()
 	BUILDER:GetSet("EyeAnglesLerp", 1)
 	BUILDER:GetSet("DrawViewModel", false)
@@ -75,6 +77,12 @@ function PART:CameraTakePriority(then_view)
 		self.priority = true
 	end)
 	if then_view then
+		pace.old_ViewAngles = pace.ViewAngles
+		pace.old_ViewPos = pace.ViewPos
+
+		--it should be relative if we use camera follow entity
+		pace.old_ViewPos_delta = pace.ViewPos - pace.GetViewEntity():GetPos()
+
 		timer.Simple(0.2, function() pace.CameraPartSwapView(true) end)
 	end
 end
@@ -351,6 +359,17 @@ function pac.HandleCameraPart(ply, pos, ang, fov, nearz, farz)
 	--until we make reversible first person a thing, letting some non-drawable parts think, this is the best solution I could come up with
 end
 
+function PART:OnDoubleClickSpecified()
+	if self ~= pac.active_camera then
+		self:CameraTakePriority(true)
+	else
+		pac.active_camera = nil
+		self.priority = false
+		self:RemoveSmallIcon()
+		pace.CameraPartSwapView()
+	end
+end
+
 function pac.HasRemainingCameraPart()
 	pac.RebuildCameras()
 	return table.Count(pac.LocalPlayer.pac_cameras) ~= 0

lua/pac3/editor/client/view.lua

@@ -768,7 +768,19 @@ function pace.EnableView(b)
 		pac.AddHook("HUDShouldDraw", "editor", pace.HUDShouldDraw)
 		pac.AddHook("PostRenderVGUI", "editor", pace.PostRenderVGUI)
 		pace.Focused = true
-		pace.ResetView()
+		if pace.old_ViewAngles and pace.old_ViewPos and pace.old_ViewPos_delta then
+			if follow_entity:GetBool() then
+				pace.ViewPos = pace.old_ViewPos_delta + pace.GetViewEntity():GetPos()
+			else
+				pace.ViewPos = pace.old_ViewPos
+			end
+			pace.ViewAngles = pace.old_ViewAngles
+			pace.old_ViewAngles = nil 
+			pace.old_ViewPos = nil
+			pace.old_ViewPos_delta = nil
+		else
+			pace.ResetView()
+		end
 	else
 		lastEntityPos = nil
 		pac.RemoveHook("GUIMousePressed", "editor")