Removed usage of String references

Author: Raelr

engine/render/renderer/platform/vulkan/Texture2D.cpp

@@ -19,7 +19,7 @@
 
 namespace Siege::Vulkan
 {
-Texture2D::Texture2D(const String& name)
+Texture2D::Texture2D(const char* name)
 {
     LoadTexture(Constants::DEFAULT_TEXTURE_2D, Constants::DEFAULT_TEXTURE_SIZE, 16, 16);
 
@@ -33,7 +33,7 @@ Texture2D::Texture2D(const String& name)
     id = INTERN_STR(name);
 }
 
-Texture2D::Texture2D(const String& name, const String& filePath)
+Texture2D::Texture2D(const char* name, const char* filePath)
 {
     LoadFromFile(filePath);
 
@@ -62,7 +62,7 @@ Texture2D& Texture2D::operator=(Texture2D&& other)
     return *this;
 }
 
-void Texture2D::LoadFromFile(const String& filePath)
+void Texture2D::LoadFromFile(const char* filePath)
 {
     int texWidth, texHeight, texChannels;
 
@@ -72,7 +72,7 @@ void Texture2D::LoadFromFile(const String& filePath)
 
     uint64_t imageSize = texWidth * texHeight * 4;
 
-    uint8_t pixelPtr[imageSize];
+    uint8_t* pixelPtr = new uint8_t[imageSize];
 
     // Set the image to 0 so that we get no garbage data in the pixel array
     memset(pixelPtr, 0, imageSize);
@@ -102,6 +102,8 @@ void Texture2D::LoadFromFile(const String& filePath)
     image.CopyBuffer(stagingBuffer.buffer);
 
     Buffer::DestroyBuffer(stagingBuffer);
+
+    delete [] pixelPtr;
 }
 
 void Texture2D::LoadTexture(const uint8_t* pixels, size_t size, uint32_t width, uint32_t height)

engine/render/renderer/platform/vulkan/Texture2D.h

@@ -47,15 +47,15 @@ class Texture2D
      * default white texture
      * @param name the name of the texture being created
      */
-    Texture2D(const String& name);
+    Texture2D(const char* name);
 
     /**
      * The texture constructor used for loading a texture from file. This loads data from a given
      * file path and stores pixel data in the class
      * @param name the name of the texture
      * @param filePath the path of the PNG or JPG file
      */
-    Texture2D(const String& name, const String& filePath);
+    Texture2D(const char* name, const char* filePath);
 
     /**
      * A move constructor for the Texture2D class
@@ -108,7 +108,7 @@ class Texture2D
      * Loads pixel information from a PNG or JPG file located on disk
      * @param filePath the path of the file
      */
-    void LoadFromFile(const String& filePath);
+    void LoadFromFile(const char* filePath);
 
     /**
      * Loads a texture from a pixel buffer. Useful if you already have pixel info loaded into a

engine/render/renderer/platform/vulkan/utils/DebugUtilsMessenger.cpp

@@ -106,8 +106,7 @@ void PopulateCreateInfo(VkDebugUtilsMessengerCreateInfoEXT& createInfo)
                                  VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT;
     createInfo.messageType = VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT |
                              VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT |
-                             VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT |
-                             VK_DEBUG_UTILS_MESSAGE_TYPE_DEVICE_ADDRESS_BINDING_BIT_EXT;
+                             VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT;
     createInfo.pfnUserCallback = debugCallback;
     createInfo.pUserData = nullptr; // Optional
 }