Fixed several compile warnings

Author: jonjondev

engine/render/renderer/platform/vulkan/LogicalDevice.cpp

@@ -80,7 +80,6 @@ LogicalDevice::LogicalDevice(const Surface& surface, PhysicalDevice& physDevice)
     GET_UNIQUE_QUEUES(queueCreateInfos, graphicsIdx, presentIdx)
 
     auto deviceExtensions = Vulkan::Config::deviceExtensions;
-    auto layers = Vulkan::Config::validationLayers;
 
     CREATE_LOGICAL_DEVICE(
         vkPhysicalDevice,

engine/render/renderer/platform/vulkan/utils/Device.cpp

@@ -10,6 +10,8 @@
 
 #include <set>
 
+static constexpr uint32_t UNFOUND_DEVICE_ITEM_IDX = -1;
+
 namespace Siege::Vulkan
 {
 // Device
@@ -47,6 +49,7 @@ uint32_t Device::Physical::GetGraphicsQueue(VkPhysicalDevice device)
     }
 
     CC_ASSERT(false, "No Graphics queue found for device!")
+    return UNFOUND_DEVICE_ITEM_IDX;
 }
 
 uint32_t Device::Physical::GetPresentQueue(VkPhysicalDevice device, VkSurfaceKHR surface)
@@ -65,6 +68,7 @@ uint32_t Device::Physical::GetPresentQueue(VkPhysicalDevice device, VkSurfaceKHR
     }
 
     CC_ASSERT(false, "No Present queue found for device!")
+    return UNFOUND_DEVICE_ITEM_IDX;
 }
 
 void Device::Physical::GetDevices(VkInstance instance, VkPhysicalDevice* devices)
@@ -270,6 +274,7 @@ uint32_t Device::Physical::FindMemoryType(VkPhysicalDevice device,
     }
 
     CC_ASSERT(false, "Failed to find suitable memory type!")
+    return UNFOUND_DEVICE_ITEM_IDX;
 }
 
 VkFormat Device::Physical::FindSupportedFormat(VkPhysicalDevice device,
@@ -295,6 +300,7 @@ VkFormat Device::Physical::FindSupportedFormat(VkPhysicalDevice device,
         }
     }
     CC_ASSERT(false, "Failed to find a supported format!")
+    return {};
 }
 
 bool Device::Physical::HasFormats(VkPhysicalDevice device, VkSurfaceKHR surface)

engine/utils/String.cpp

@@ -97,7 +97,7 @@ static char* GetFromFormat(const char* format, T value)
 {
     size_t len = snprintf(nullptr, 0, format, value);
     char* cstr = Allocate(len);
-    sprintf(cstr, format, value);
+    snprintf(cstr, len + 1, format, value);
     cstr[len] = '\0';
     return cstr;
 }

engine/utils/String.h

@@ -483,8 +483,8 @@ class String
     {
         const char* data = Data();
         size_t formatLen = snprintf(nullptr, 0, data, std::forward<P>(params)...);
-        char newStr[formatLen];
-        sprintf(newStr, data, std::forward<P>(params)...);
+        char newStr[formatLen + 1];
+        snprintf(newStr, formatLen + 1, data, std::forward<P>(params)...);
         Assign(newStr);
     }