Skip to content

Commit 5268601

Browse files
committed
Fixed globbing pattern issues across platforms
1 parent b47af50 commit 5268601

File tree

6 files changed

+13
-13
lines changed

6 files changed

+13
-13
lines changed

engine/render/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,4 +53,4 @@ $(renderBuildDir)/assets/shaders/%.spv: $(renderSrcDir)/assets/shaders/%
5353
# Copy Vulkan libraries to the build directory
5454
vulkan-libs:
5555
$(MKDIR) $(call platformpth, $(renderBuildDir)/lib)
56-
$(call COPY,$(vendorDir)/vulkan/lib,$(renderBuildDir)/lib,"$(RWCARDGLOB)")
56+
$(call COPY,$(vendorDir)/vulkan/lib,$(renderBuildDir)/lib,$(RWCARDGLOB))

examples/game/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ $(exampleGameBinDir)/%.o: $(exampleGameSrcDir)/%.cpp
7070
# Copy assets directory to the build directory and pack them
7171
pack-assets:
7272
$(MKDIR) $(call platformpth, $(exampleGameBuildDir)/assets)
73-
$(call COPY,$(exampleGameSrcDir)/assets,$(exampleGameBuildDir)/assets,"$(RWCARDGLOB)")
73+
$(call COPY,$(exampleGameSrcDir)/assets,$(exampleGameBuildDir)/assets,$(RWCARDGLOB))
7474
$(MKDIR) $(call platformpth,$(exampleGameBuildDir)/assets/shaders)
75-
$(call COPY,$(binDir)/engine/render/build/assets/shaders,$(exampleGameBuildDir)/assets/shaders,"$(RWCARDGLOB)")
75+
$(call COPY,$(binDir)/engine/render/build/assets/shaders,$(exampleGameBuildDir)/assets/shaders,$(RWCARDGLOB))
7676
$(packerApp) $(exampleGameBuildDir)/app.pck $(exampleGameBuildDir) $(exampleGameAssets)
7777
$(RM) $(call platformpth,$(exampleGameBuildDir)/assets)
7878

examples/render/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ $(exampleRenderBinDir)/%.o: $(exampleRenderSrcDir)/%.cpp
6969
# Copy assets directory to the build directory and pack them
7070
pack-assets:
7171
$(MKDIR) $(call platformpth, $(exampleRenderBuildDir)/assets)
72-
$(call COPY,$(exampleRenderSrcDir)/assets,$(exampleRenderBuildDir)/assets,"$(RWCARDGLOB)")
72+
$(call COPY,$(exampleRenderSrcDir)/assets,$(exampleRenderBuildDir)/assets,$(RWCARDGLOB))
7373
$(MKDIR) $(call platformpth,$(exampleRenderBuildDir)/assets/shaders)
74-
$(call COPY,$(binDir)/engine/render/build/assets/shaders,$(exampleRenderBuildDir)/assets/shaders,"$(RWCARDGLOB)")
74+
$(call COPY,$(binDir)/engine/render/build/assets/shaders,$(exampleRenderBuildDir)/assets/shaders,$(RWCARDGLOB))
7575
$(packerApp) $(exampleRenderBuildDir)/app.pck $(exampleRenderBuildDir) $(exampleRenderAssets)
7676
$(RM) $(call platformpth,$(exampleRenderBuildDir)/assets)
7777

examples/tilemap/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ $(exampleTilemapBinDir)/%.o: $(exampleTilemapSrcDir)/%.cpp
6868
# Copy assets directory to the build directory and pack them
6969
pack-assets:
7070
$(MKDIR) $(call platformpth, $(exampleTilemapBuildDir)/assets)
71-
$(call COPY,$(exampleTilemapSrcDir)/assets,$(exampleTilemapBuildDir)/assets,"$(RWCARDGLOB)")
71+
$(call COPY,$(exampleTilemapSrcDir)/assets,$(exampleTilemapBuildDir)/assets,$(RWCARDGLOB))
7272
$(MKDIR) $(call platformpth,$(exampleTilemapBuildDir)/assets/shaders)
73-
$(call COPY,$(binDir)/engine/render/build/assets/shaders,$(exampleTilemapBuildDir)/assets/shaders,"$(RWCARDGLOB)")
73+
$(call COPY,$(binDir)/engine/render/build/assets/shaders,$(exampleTilemapBuildDir)/assets/shaders,$(RWCARDGLOB))
7474
$(packerApp) $(exampleTilemapBuildDir)/app.pck $(exampleTilemapBuildDir) $(exampleTilemapAssets)
7575
$(RM) $(call platformpth,$(exampleTilemapBuildDir)/assets)
7676

make/Platform.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ ifeq ($(OS), Windows_NT)
1111
platform := windows
1212
CXX ?= g++
1313
THEN := &&
14-
RWCARDGLOB := *.*
14+
RWCARDGLOB := "*.*"
1515
PATHSEP := \$(BLANK)
1616
MKDIR = powershell -executionpolicy bypass $(scriptsDir)/mkdir.ps1
1717
RM = powershell -executionpolicy bypass $(scriptsDir)/rm.ps1

tests/Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ testAssets += $(patsubst ./%,%, $(call rwildcard,$(testSrcDir),*.scene))
2525
utestIncludeDir := $(vendorDir)/include/utest
2626
linkFlags += -l core -l utils -l resources
2727

28-
.PHONY: all test-data
28+
.PHONY: all pack-assets
2929

30-
all: $(testApp) test-data
30+
all: $(testApp) pack-assets
3131

3232
# Link the object files and create an executable
3333
$(testApp): $(utestIncludeDir) $(testObjects)
@@ -47,8 +47,8 @@ $(utestIncludeDir):
4747
$(MKDIR) $(call platformpth, $(utestIncludeDir))
4848
$(call COPY,$(vendorDir)/utest.h,$(utestIncludeDir),utest.h)
4949

50-
# Copy the data directory to the build directory, and pack them
51-
test-data:
50+
# Copy the assets directory to the build directory, and pack them
51+
pack-assets:
5252
$(MKDIR) $(call platformpth,$(testBuildDir)/data)
53-
$(call COPY,$(testSrcDir)/data,$(testBuildDir)/data,"$(RWCARDGLOB)")
53+
$(call COPY,$(testSrcDir)/data,$(testBuildDir)/data,$(RWCARDGLOB))
5454
$(packerApp) $(testBuildDir)/app.pck $(testBuildDir) $(testAssets)

0 commit comments

Comments
 (0)