SurvivalFly - Add watermove Check (Jesus)

Attempts to prevent walking directly above water

Author: CaptainObvious0

NCPCore/src/main/java/fr/neatmonster/nocheatplus/checks/moving/player/SurvivalFly.java

@@ -19,6 +19,7 @@
 import java.util.Locale;
 import java.util.Set;
 
+import org.bukkit.Bukkit;
 import org.bukkit.Location;
 import org.bukkit.Material;
 import org.bukkit.entity.Player;
@@ -399,6 +400,25 @@ else if (data.liftOffEnvelope == LiftOffEnvelope.LIMIT_LIQUID
                 hDistanceAboveLimit = Math.max(hDistanceAboveLimit, hDistance);
                 tags.add("waterwalk");
             }
+			
+	    // Detects walking directly above water
+	    Material blockUnder = player.getLocation().subtract(0, 0.12, 0).getBlock().getType();
+            Material blockAbove = player.getLocation().add(0, 0.12, 0).getBlock().getType();
+            if (blockUnder != null && blockAbove != null) {
+	        // Checks if the player is above water but not in water.
+            	if (blockUnder == Material.WATER && blockAbove == Material.AIR) {
+		// hDist and vDist checks, simply checks for horizontal movement with little y distance
+            	if (hDistanceAboveLimit <= 0D && hDistance > 0.1D && yDistance <= 0.1D && !toOnGround && !fromOnGround 
+                    && lastMove.toIsValid && lastMove.yDistance != 0D 
+                    && !from.isHeadObstructed() && !to.isHeadObstructed() && !player.isSwimming()) {
+			// Prevent being flagged if a player transitions from a block to water and the player falls into the water.
+            		if (!(yDistance < 0 && yDistance != 0 && lastMove.yDistance < 0 && lastMove.yDistance != 0)) {
+                	    hDistanceAboveLimit = Math.max(hDistanceAboveLimit, hDistance);
+                            tags.add("watermove");	
+            			}
+            		}
+            	}
+            }
 
             // Prevent players from sprinting if they're moving backwards (allow buffers to cover up !?).
             if (sprinting && data.lostSprintCount == 0 && !cc.assumeSprint && hDistance > thisMove.walkSpeed && !data.hasActiveHorVel()) {