Skip to content

Commit 0aa53d7

Browse files
Fix minor exception in dump check
1 parent f173c72 commit 0aa53d7

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
<PropertyGroup Label="Default Versioning">
4040
<!-- Default version for all projects (can be overridden per project) -->
4141
<VersionPrefix>1.1.2</VersionPrefix>
42-
<VersionSuffix>4</VersionSuffix>
42+
<VersionSuffix>5</VersionSuffix>
4343

4444
<!-- Calculated version -->
4545
<Version Condition="'$(Version)' == ''">$(VersionPrefix).$(VersionSuffix)</Version>

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
![MCP Nexus Icon](https://github.com/CapulusCodeNinja/mcp_nexus/blob/main/images/mcp_nexus_small.png?raw=true)
66

7-
![Tests](https://img.shields.io/badge/tests-1247%20passing-brightgreen)
8-
![Coverage](https://img.shields.io/badge/coverage-87.1%25%20lines-green)
7+
![Tests](https://img.shields.io/badge/tests-1249%20passing-brightgreen)
8+
![Coverage](https://img.shields.io/badge/coverage-86.9%25%20lines-green)
99
![Build](https://img.shields.io/badge/build-passing-brightgreen)
1010
![License](https://img.shields.io/badge/license-Apache%202.0-blue)
1111

nexus_external_apis/ProcessManagement/ProcessManager.cs

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,22 +106,27 @@ public bool WaitForProcessExit(Process process, int timeout = -1)
106106
/// <param name="process">The process to wait for.</param>
107107
/// <param name="timeout">The timeout in milliseconds. Use -1 for infinite timeout.</param>
108108
/// <param name="cancellationToken">The cancellation token.</param>
109-
/// <returns>A task that represents the asynchronous operation. The task result is true if the process exited within the timeout, false otherwise.</returns>
109+
/// <returns>
110+
/// A task that represents the asynchronous operation. The task result is true if the process
111+
/// exited within the timeout window and false if the operation was cancelled or timed out.
112+
/// </returns>
110113
public async Task<bool> WaitForProcessExitAsync(Process process, int timeout = -1, CancellationToken cancellationToken = default)
111114
{
112-
using var cts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
115+
using var linkedTokenSource = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
116+
113117
if (timeout > 0)
114118
{
115-
cts.CancelAfter(timeout);
119+
linkedTokenSource.CancelAfter(timeout);
116120
}
117121

118122
try
119123
{
120-
await process.WaitForExitAsync(cts.Token);
124+
await process.WaitForExitAsync(linkedTokenSource.Token);
121125
return true;
122126
}
123-
catch (OperationCanceledException) when (cancellationToken.IsCancellationRequested)
127+
catch (OperationCanceledException)
124128
{
129+
// Treat both timeout-based and external cancellation uniformly as "did not exit in time".
125130
return false;
126131
}
127132
}

0 commit comments

Comments
 (0)