Increase the test coverage

Author: CapulusCodeNinja

mcp_nexus_tests/Caching/CacheEvictionManagerTests.cs

@@ -39,21 +39,21 @@ public void Dispose()
         [Fact]
         public void Constructor_WithNullLogger_ThrowsArgumentNullException()
         {
-            Assert.Throws<ArgumentNullException>(() => 
+            Assert.Throws<ArgumentNullException>(() =>
                 new CacheEvictionManager<string, object>(null!, _config, _cache));
         }
 
         [Fact]
         public void Constructor_WithNullConfig_ThrowsArgumentNullException()
         {
-            Assert.Throws<ArgumentNullException>(() => 
+            Assert.Throws<ArgumentNullException>(() =>
                 new CacheEvictionManager<string, object>(_mockLogger.Object, null!, _cache));
         }
 
         [Fact]
         public void Constructor_WithNullCache_ThrowsArgumentNullException()
         {
-            Assert.Throws<ArgumentNullException>(() => 
+            Assert.Throws<ArgumentNullException>(() =>
                 new CacheEvictionManager<string, object>(_mockLogger.Object, _config, null!));
         }
 

mcp_nexus_tests/CommandQueue/BasicCommandProcessorTests.cs

@@ -32,31 +32,31 @@ public BasicCommandProcessorTests()
         public void Constructor_WithNullCdbSession_ThrowsArgumentNullException()
         {
             // Act & Assert
-            Assert.Throws<ArgumentNullException>(() => 
+            Assert.Throws<ArgumentNullException>(() =>
                 new BasicCommandProcessor(null!, _mockLogger.Object, _config, _activeCommands));
         }
 
         [Fact]
         public void Constructor_WithNullLogger_ThrowsArgumentNullException()
         {
             // Act & Assert
-            Assert.Throws<ArgumentNullException>(() => 
+            Assert.Throws<ArgumentNullException>(() =>
                 new BasicCommandProcessor(_mockCdbSession.Object, null!, _config, _activeCommands));
         }
 
         [Fact]
         public void Constructor_WithNullConfig_ThrowsArgumentNullException()
         {
             // Act & Assert
-            Assert.Throws<ArgumentNullException>(() => 
+            Assert.Throws<ArgumentNullException>(() =>
                 new BasicCommandProcessor(_mockCdbSession.Object, _mockLogger.Object, null!, _activeCommands));
         }
 
         [Fact]
         public void Constructor_WithNullActiveCommands_ThrowsArgumentNullException()
         {
             // Act & Assert
-            Assert.Throws<ArgumentNullException>(() => 
+            Assert.Throws<ArgumentNullException>(() =>
                 new BasicCommandProcessor(_mockCdbSession.Object, _mockLogger.Object, _config, null!));
         }
 
@@ -95,7 +95,7 @@ public async Task ProcessCommandQueueAsync_WithSingleCommand_ProcessesSuccessful
             var cancellationTokenSource = new CancellationTokenSource();
             var completionSource = new TaskCompletionSource<string>();
             var queuedCommand = new QueuedCommand("cmd-1", "!analyze -v", DateTime.UtcNow, completionSource, cancellationTokenSource);
-            
+
             commandQueue.Add(queuedCommand);
             commandQueue.CompleteAdding();
 
@@ -122,7 +122,7 @@ public async Task ProcessCommandQueueAsync_WithFailingCommand_HandlesFailure()
             var cancellationTokenSource = new CancellationTokenSource();
             var completionSource = new TaskCompletionSource<string>();
             var queuedCommand = new QueuedCommand("cmd-1", "!invalid", DateTime.UtcNow, completionSource, cancellationTokenSource);
-            
+
             commandQueue.Add(queuedCommand);
             commandQueue.CompleteAdding();
 
@@ -150,7 +150,7 @@ public async Task ProcessCommandQueueAsync_WithCancelledCommand_HandlesCancellat
             var commandCancellationTokenSource = new CancellationTokenSource();
             var completionSource = new TaskCompletionSource<string>();
             var queuedCommand = new QueuedCommand("cmd-1", "!analyze -v", DateTime.UtcNow, completionSource, commandCancellationTokenSource);
-            
+
             commandQueue.Add(queuedCommand);
             commandQueue.CompleteAdding();
 
@@ -179,7 +179,7 @@ public async Task ProcessCommandQueueAsync_WithServiceShutdown_HandlesCancellati
             var commandCancellationTokenSource = new CancellationTokenSource();
             var completionSource = new TaskCompletionSource<string>();
             var queuedCommand = new QueuedCommand("cmd-1", "!analyze -v", DateTime.UtcNow, completionSource, commandCancellationTokenSource);
-            
+
             commandQueue.Add(queuedCommand);
             commandQueue.CompleteAdding();
 
@@ -194,7 +194,7 @@ public async Task ProcessCommandQueueAsync_WithServiceShutdown_HandlesCancellati
 
             // Act - Start processing and then cancel the service
             var processingTask = _processor.ProcessCommandQueueAsync(commandQueue, serviceCancellationTokenSource.Token);
-            
+
             // Cancel the service after a short delay to allow processing to start
             await Task.Delay(100);
             serviceCancellationTokenSource.Cancel();
@@ -239,7 +239,7 @@ public void TriggerCleanup_RemovesCompletedCommands()
             var completionSource = new TaskCompletionSource<string>();
             var cancellationTokenSource = new CancellationTokenSource();
             var oldCommand = new QueuedCommand("cmd-1", "!analyze -v", DateTime.UtcNow.AddHours(-2), completionSource, cancellationTokenSource, CommandState.Completed);
-            
+
             _activeCommands["cmd-1"] = oldCommand;
 
             // Act
@@ -256,7 +256,7 @@ public void TriggerCleanup_KeepsRecentCommands()
             var completionSource = new TaskCompletionSource<string>();
             var cancellationTokenSource = new CancellationTokenSource();
             var recentCommand = new QueuedCommand("cmd-1", "!analyze -v", DateTime.UtcNow, completionSource, cancellationTokenSource, CommandState.Completed);
-            
+
             _activeCommands["cmd-1"] = recentCommand;
 
             // Act
@@ -273,7 +273,7 @@ public void TriggerCleanup_KeepsExecutingCommands()
             var completionSource = new TaskCompletionSource<string>();
             var cancellationTokenSource = new CancellationTokenSource();
             var executingCommand = new QueuedCommand("cmd-1", "!analyze -v", DateTime.UtcNow.AddHours(-2), completionSource, cancellationTokenSource, CommandState.Executing);
-            
+
             _activeCommands["cmd-1"] = executingCommand;
 
             // Act

mcp_nexus_tests/CommandQueue/CommandNotificationManagerTests.cs

@@ -28,23 +28,23 @@ public CommandNotificationManagerTests()
         public void Constructor_WithNullNotificationService_ThrowsArgumentNullException()
         {
             // Act & Assert
-            Assert.Throws<ArgumentNullException>(() => 
+            Assert.Throws<ArgumentNullException>(() =>
                 new CommandNotificationManager(null!, _mockLogger.Object, _config));
         }
 
         [Fact]
         public void Constructor_WithNullLogger_ThrowsArgumentNullException()
         {
             // Act & Assert
-            Assert.Throws<ArgumentNullException>(() => 
+            Assert.Throws<ArgumentNullException>(() =>
                 new CommandNotificationManager(_mockNotificationService.Object, null!, _config));
         }
 
         [Fact]
         public void Constructor_WithNullConfig_ThrowsArgumentNullException()
         {
             // Act & Assert
-            Assert.Throws<ArgumentNullException>(() => 
+            Assert.Throws<ArgumentNullException>(() =>
                 new CommandNotificationManager(_mockNotificationService.Object, _mockLogger.Object, null!));
         }
 
@@ -145,9 +145,9 @@ public async Task NotifyCommandHeartbeatFireAndForget_WithQueuedCommand_CallsNot
             // Wait for the Task.Run to complete
             await Task.Delay(2000);
             _mockNotificationService.Verify(x => x.NotifyCommandStatusAsync(
-                It.IsAny<string>(), 
-                It.IsAny<string>(), 
-                It.Is<string>(s => s.Contains("Executing for 5") && s.Contains("minutes")), 
+                It.IsAny<string>(),
+                It.IsAny<string>(),
+                It.Is<string>(s => s.Contains("Executing for 5") && s.Contains("minutes")),
                 It.IsAny<int?>(),
                 It.IsAny<string>(),
                 It.IsAny<string>(),
@@ -170,9 +170,9 @@ public async Task NotifyCommandHeartbeatFireAndForget_WithLongElapsedTime_CapsPr
             // Wait for the Task.Run to complete
             await Task.Delay(1000);
             _mockNotificationService.Verify(x => x.NotifyCommandStatusAsync(
-                It.IsAny<string>(), 
-                It.IsAny<string>(), 
-                It.IsAny<string>(), 
+                It.IsAny<string>(),
+                It.IsAny<string>(),
+                It.IsAny<string>(),
                 It.Is<int?>(p => p <= 95),
                 It.IsAny<string>(),
                 It.IsAny<string>(),
@@ -341,7 +341,7 @@ public async Task NotifyCommandStatusFireAndForget_WithExceptionInNotificationSe
             var commandId = "cmd-1";
             var command = "!analyze -v";
             var status = "executing";
-            
+
             _mockNotificationService.Setup(x => x.NotifyCommandStatusAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<int?>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>()))
                 .ThrowsAsync(new Exception("Notification failed"));
 
@@ -367,7 +367,7 @@ public async Task NotifyCommandHeartbeatFireAndForget_WithExceptionInNotificatio
             var cancellationTokenSource = new CancellationTokenSource();
             var queuedCommand = new QueuedCommand("cmd-1", "!analyze -v", DateTime.UtcNow, completionSource, cancellationTokenSource);
             var elapsed = TimeSpan.FromMinutes(5);
-            
+
             _mockNotificationService.Setup(x => x.NotifyCommandStatusAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<int?>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>()))
                 .ThrowsAsync(new Exception("Notification failed"));