Working on the stack extension to ensure it has the correct thread

Author: CapulusCodeNinja

mcp_nexus/Extensions/ExtensionExecutor.cs

@@ -315,7 +315,7 @@ private IProcessHandle CreateProcess(
             string callbackToken,
             object? parameters)
         {
-            // Build environment variables dictionary
+            // Build environment variables dictionary (for secrets and system info only)
             var environmentVariables = new Dictionary<string, string>
             {
                 ["MCP_NEXUS_SESSION_ID"] = sessionId,
@@ -324,13 +324,6 @@ private IProcessHandle CreateProcess(
                 ["MCP_NEXUS_CALLBACK_TOKEN"] = callbackToken
             };
 
-            // Add extension parameters as JSON
-            if (parameters != null)
-            {
-                var parametersJson = JsonSerializer.Serialize(parameters);
-                environmentVariables["MCP_NEXUS_PARAMETERS"] = parametersJson;
-            }
-
             // Configure based on script type (only PowerShell supported)
             var scriptType = metadata.ScriptType.ToLowerInvariant();
             string fileName;
@@ -341,7 +334,23 @@ private IProcessHandle CreateProcess(
                 // Try to find PowerShell - prefer pwsh (PowerShell 7+), fall back to powershell (5.1)
                 string? powershellPath = FindPowerShell() ?? throw new InvalidOperationException("PowerShell not found. Please ensure pwsh.exe or powershell.exe is in PATH or installed.");
                 fileName = powershellPath;
-                arguments = $"-NoProfile -ExecutionPolicy Bypass -File \"{metadata.FullScriptPath}\"";
+                
+                // Build PowerShell arguments with parameters
+                var argumentsBuilder = new StringBuilder();
+                argumentsBuilder.Append($"-NoProfile -ExecutionPolicy Bypass -File \"{metadata.FullScriptPath}\"");
+                
+                // Add parameters as PowerShell command-line arguments
+                if (parameters != null)
+                {
+                    var paramArgs = BuildPowerShellParameterArguments(parameters);
+                    if (!string.IsNullOrWhiteSpace(paramArgs))
+                    {
+                        argumentsBuilder.Append(' ');
+                        argumentsBuilder.Append(paramArgs);
+                    }
+                }
+                
+                arguments = argumentsBuilder.ToString();
             }
             else
             {
@@ -354,6 +363,72 @@ private IProcessHandle CreateProcess(
         }
 
 
+        /// <summary>
+        /// Builds PowerShell command-line parameter arguments from a JSON object.
+        /// Converts parameter names to PowerShell naming convention (camelCase to PascalCase).
+        /// </summary>
+        /// <param name="parameters">The parameters object to convert.</param>
+        /// <returns>PowerShell parameter string (e.g., "-ThreadId '5' -Verbose $true").</returns>
+        private string BuildPowerShellParameterArguments(object parameters)
+        {
+            if (parameters == null)
+                return string.Empty;
+
+            var argumentsBuilder = new StringBuilder();
+
+            // Serialize to JSON and deserialize to JsonElement for easy property access
+            var json = JsonSerializer.Serialize(parameters);
+            using var doc = JsonDocument.Parse(json);
+            var root = doc.RootElement;
+
+            foreach (var property in root.EnumerateObject())
+            {
+                // Convert camelCase to PascalCase for PowerShell convention
+                var paramName = char.ToUpper(property.Name[0]) + property.Name[1..];
+                
+                if (argumentsBuilder.Length > 0)
+                    argumentsBuilder.Append(' ');
+
+                argumentsBuilder.Append($"-{paramName}");
+
+                // Handle different value types
+                switch (property.Value.ValueKind)
+                {
+                    case JsonValueKind.String:
+                        // Escape single quotes in string values
+                        var stringValue = property.Value.GetString() ?? string.Empty;
+                        stringValue = stringValue.Replace("'", "''");
+                        argumentsBuilder.Append($" '{stringValue}'");
+                        break;
+
+                    case JsonValueKind.Number:
+                        argumentsBuilder.Append($" {property.Value.GetRawText()}");
+                        break;
+
+                    case JsonValueKind.True:
+                        argumentsBuilder.Append(" $true");
+                        break;
+
+                    case JsonValueKind.False:
+                        argumentsBuilder.Append(" $false");
+                        break;
+
+                    case JsonValueKind.Null:
+                        argumentsBuilder.Append(" $null");
+                        break;
+
+                    default:
+                        // For complex types (objects, arrays), pass as JSON string
+                        var jsonValue = property.Value.GetRawText();
+                        jsonValue = jsonValue.Replace("'", "''");
+                        argumentsBuilder.Append($" '{jsonValue}'");
+                        break;
+                }
+            }
+
+            return argumentsBuilder.ToString();
+        }
+
         /// <summary>
         /// Finds PowerShell executable on the system.
         /// Prefers pwsh.exe (PowerShell 7+), falls back to powershell.exe (Windows PowerShell 5.1).

mcp_nexus/Extensions/stack_with_sources/stack_with_sources.ps1

@@ -6,22 +6,33 @@ Downloads stack trace with source code for all frames.
 This extension gets the stack trace for a specified thread and downloads
 source files for all frames using the lsa command.
 
+.PARAMETER ThreadId
+Thread ID to analyze (e.g., '8' or '.' for current thread). Defaults to current thread ('.').
+
+.EXAMPLE
+.\stack_with_sources.ps1 -ThreadId '5'
+
+.EXAMPLE
+.\stack_with_sources.ps1
+
 .NOTES
 This is the workflow we discussed - gets stack with kL and runs lsa on each return address.
 #>
 
 param(
+    [Parameter(Mandatory=$false)]
     [string]$ThreadId = "."  # Default to current thread
 )
 
 # Import MCP Nexus helper module
 Import-Module "$PSScriptRoot\..\modules\McpNexusExtensions.psm1" -Force
 
+Write-NexusLog "Starting stack_with_sources extension with ThreadId: $ThreadId" -Level Information
+
 # Display user-friendly thread description
 $threadDisplay = if ($ThreadId -eq ".") { "current thread" } else { "thread $ThreadId" }
 
 Write-NexusProgress "Starting stack analysis with source download for $threadDisplay"
-Write-NexusLog "Starting stack_with_sources extension for thread: $ThreadId" -Level Information
 
 try {
     # Step 1: Get stack with line numbers