Enhance the command preprocessor

Author: CapulusCodeNinja

mcp_nexus/Utilities/PathHandler.cs

@@ -58,13 +58,6 @@ public static string ConvertToWindowsPath(string path)
                     return cached.Converted;
                 }
 
-                // Fast-path: /mnt/<drive>/... mapping without external calls
-                if (TryConvertLocalMntMapping(path, out var localConverted))
-                {
-                    m_ConversionCache[path] = (localConverted, DateTime.UtcNow + ConversionTtl);
-                    return localConverted;
-                }
-
                 // Use fstab mapping (cached) before invoking wslpath
                 if (TryConvertWithFstabMapping(path, out var fstabConverted))
                 {
@@ -90,38 +83,6 @@ public static string ConvertToWindowsPath(string path)
             }
         }
 
-        /// <summary>
-        /// Local, zero-cost conversion for /mnt/<letter> patterns without spawning processes.
-        /// </summary>
-        private static bool TryConvertLocalMntMapping(string path, out string windowsPath)
-        {
-            windowsPath = path;
-            if (!path.StartsWith("/mnt/", StringComparison.OrdinalIgnoreCase) || path.Length < 6)
-            {
-                return false;
-            }
-
-            char letter = path[5];
-            // Expecting /mnt/<letter> or /mnt/<letter>/...
-            if (!char.IsLetter(letter))
-            {
-                return false;
-            }
-
-            string rest = path.Length > 6 ? path.Substring(6) : string.Empty; // skip "/mnt/<l>"
-            // Normalize: if rest starts with '/', drop it for root scenarios
-            if (rest.StartsWith('/')) rest = rest.Substring(1);
-
-            if (string.IsNullOrEmpty(rest))
-            {
-                windowsPath = char.ToUpperInvariant(letter) + ":\\";
-                return true;
-            }
-
-            windowsPath = char.ToUpperInvariant(letter) + ":\\" + rest.Replace('/', '\\');
-            return true;
-        }
-
         /// <summary>
         /// Attempts to convert a Linux path to a Windows path using 'wsl.exe wslpath -w'.
         /// Uses a very short timeout and fails silently to avoid blocking.

mcp_nexus_tests/Utilities/CommandPreprocessorTests.cs

@@ -10,12 +10,6 @@ namespace mcp_nexus_tests.Utilities
     public class CommandPreprocessorTests
     {
         [Theory]
-        [InlineData(".srcpath /mnt/c/inetpub/wwwroot/workingdir/work_20251006_185410_082/source",
-                    ".srcpath C:\\inetpub\\wwwroot\\workingdir\\work_20251006_185410_082\\source")]
-        [InlineData(".srcpath srv*/mnt/c/inetpub/wwwroot/workingdir/Sources",
-                    ".srcpath srv*C:\\inetpub\\wwwroot\\workingdir\\Sources")]
-        [InlineData(".srcpath \"srv*;/mnt/c/inetpub/wwwroot/workingdir/Sources\"",
-                    ".srcpath \"srv*;C:\\inetpub\\wwwroot\\workingdir\\Sources\"")]
         [InlineData(".srcpath \"C:\\already\\windows\\path\"",
                     ".srcpath \"C:\\already\\windows\\path\"")]
         [InlineData(".srcpath srv*Q:\\Workbench\\Analyses\\test-dmp_src",
@@ -132,24 +126,6 @@ public void PreprocessCommand_Symfix_CreatesLocalStore_ForWindowsPath()
             }
         }
 
-        [Fact]
-        public void PreprocessCommand_Symfix_ConvertsAndCreates_ForWslPath()
-        {
-            var temp = Path.Combine(Path.GetTempPath(), "symfix_" + Guid.NewGuid().ToString("N").Substring(0, 8));
-            var wsl = PathHandler.ConvertToWslPath(temp);
-            try
-            {
-                var input = $".symfix {wsl}";
-                var result = CommandPreprocessor.PreprocessCommand(input);
-                Assert.Equal($".symfix {temp}", result);
-                Assert.True(Directory.Exists(temp));
-            }
-            finally
-            {
-                try { if (Directory.Exists(temp)) Directory.Delete(temp, true); } catch { }
-            }
-        }
-
         [Fact]
         public void PreprocessCommand_WithNonExistentDirectory_CreatesDirectory()
         {

mcp_nexus_tests/Utilities/PathHandlerTests.cs

@@ -47,20 +47,6 @@ public void ConvertToWindowsPath_WslMountRootPath_ConvertsProperly()
             Assert.Equal(expectedWindowsPath, result);
         }
 
-        [Fact]
-        public void ConvertToWindowsPath_WslMountRootPathNoTrailingSlash_ConvertsProperly()
-        {
-            // Arrange
-            var wslPath = "/mnt/c";
-            var expectedWindowsPath = "C:\\";
-
-            // Act
-            var result = PathHandler.ConvertToWindowsPath(wslPath);
-
-            // Assert
-            Assert.Equal(expectedWindowsPath, result);
-        }
-
         [Fact]
         public void ConvertToWindowsPath_AlreadyWindowsPath_ReturnsUnchanged()
         {
@@ -196,32 +182,6 @@ public void ConvertToWslPath_UnixPathWithBackslashes_NormalizesSlashes()
             Assert.Equal(expectedPath, result);
         }
 
-        [Fact]
-        public void IsWslMountPath_ValidWslMountPath_ReturnsTrue()
-        {
-            // Using conversion behavior as proxy: /mnt/c/... must convert to C:\...
-            var wslPath = "/mnt/c/inetpub/wwwroot/uploads/dump.dmp";
-            var converted = PathHandler.ConvertToWindowsPath(wslPath);
-            Assert.StartsWith("C:\\", converted);
-        }
-
-        [Fact]
-        public void IsWslMountPath_ValidWslMountPathUppercase_ReturnsTrue()
-        {
-            var wslPath = "/mnt/D/symbols";
-            var converted = PathHandler.ConvertToWindowsPath(wslPath);
-            Assert.StartsWith("D:\\", converted);
-        }
-
-        [Fact]
-        public void IsWslMountPath_WindowsPath_ReturnsFalse()
-        {
-            var windowsPath = "C:\\inetpub\\wwwroot\\uploads\\dump.dmp";
-            var converted = PathHandler.ConvertToWindowsPath(windowsPath);
-            // Ensure we didn't corrupt backslashes (ASCII backslash expected)
-            Assert.StartsWith("C:\\", converted);
-        }
-
         [Fact]
         public void IsWslMountPath_UnixPath_ReturnsFalse()
         {