non_constant_identifier_names

Author: CarGuo

analysis_options.yaml

@@ -5,4 +5,5 @@ analyzer:
     mixin_inherits_from_not_object: ignore
 
 linter:
-  rules:
+  rules:
+    non_constant_identifier_names: false

lib/common/dao/user_dao.dart

@@ -39,8 +39,8 @@ class UserDao {
     if (res != null && res.result) {
       var result = Uri.parse("gsy://oauth?$res.data");
       var token = result.queryParameters["access_token"]!;
-      var _token = 'token $token';
-      await LocalStorage.save(Config.TOKEN_KEY, _token);
+      var token0 = 'token $token';
+      await LocalStorage.save(Config.TOKEN_KEY, token0);
 
       resultData = await getUserInfo(null);
       if (Config.DEBUG!) {

lib/common/net/graphql/client.dart

@@ -4,20 +4,20 @@ import 'package:gsy_github_app_flutter/common/net/graphql/users.dart';
 import 'package:gsy_github_app_flutter/common/utils/common_utils.dart';
 
 Future<GraphQLClient> _client(token) async {
-  final HttpLink _httpLink = HttpLink(
+  final HttpLink httpLink = HttpLink(
     'https://api.github.com/graphql',
   );
 
-  final AuthLink _authLink = AuthLink(
+  final AuthLink authLink = AuthLink(
     getToken: () => '$token',
   );
 
-  final Link _link = _authLink.concat(_httpLink);
+  final Link link = authLink.concat(httpLink);
   var path = await CommonUtils.getApplicationDocumentsPath();
   final store = await HiveStore.open(path: path);
   return GraphQLClient(
     cache: GraphQLCache(store: store),
-    link: _link,
+    link: link,
   );
 }
 
@@ -32,14 +32,14 @@ releaseClient() {
 }
 
 Future<QueryResult>? getRepository(String owner, String? name) async {
-  final QueryOptions _options = QueryOptions(
+  final QueryOptions options = QueryOptions(
       document: gql(readRepository),
       variables: <String, dynamic>{
         'owner': owner,
         'name': name,
       },
       fetchPolicy: FetchPolicy.noCache);
-  return await _innerClient!.query(_options);
+  return await _innerClient!.query(options);
 }
 
 Future<QueryResult>? getTrendUser(String location, {String? cursor}) async {
@@ -51,9 +51,9 @@ Future<QueryResult>? getTrendUser(String location, {String? cursor}) async {
           'location': "location:$location sort:followers",
           'after': cursor,
         };
-  final QueryOptions _options = QueryOptions(
+  final QueryOptions options = QueryOptions(
       document: gql(cursor == null ? readTrendUser : readTrendUserByCursor),
       variables: variables,
       fetchPolicy: FetchPolicy.noCache);
-  return await _innerClient!.query(_options);
+  return await _innerClient!.query(options);
 }

lib/common/net/interceptors/log_interceptor.dart

@@ -1,3 +1,5 @@
+// ignore_for_file: type_literal_in_constant_pattern
+
 import 'package:dio/dio.dart';
 import 'package:gsy_github_app_flutter/common/config/config.dart';
 

lib/common/scoped_model/scoped_model.dart

@@ -118,7 +118,7 @@ class ScopedModel<T extends Model> extends StatelessWidget {
   Widget build(BuildContext context) {
     return AnimatedBuilder(
       animation: model!,
-      builder: (context, _) => _InheritedModel<T>(model: model!, child: child!),
+      builder: (context, _) => _InheritedModel<T>(model: model, child: child!),
     );
   }
 
@@ -274,6 +274,7 @@ class ScopedModelDescendant<T extends Model> extends StatelessWidget {
 class ScopedModelError extends Error {
   ScopedModelError();
 
+  @override
   String toString() {
     return '''Error: Could not find the correct ScopedModel.
     

lib/page/login/login_page.dart

@@ -200,7 +200,7 @@ mixin LoginBLoC on State<LoginPage> {
 
   oauthLogin() async {
     String? code = await NavigatorUtils.goLoginWebView(context,
-        Address.getOAuthUrl(), "${GSYLocalizations.i18n(context)!.oauth_text}");
+        Address.getOAuthUrl(), GSYLocalizations.i18n(context)!.oauth_text);
 
     if (code != null && code.isNotEmpty) {
       ///通过 redux 去执行登陆流程

lib/page/repos/repository_detail_issue_list_page.dart

@@ -109,10 +109,6 @@ class RepositoryDetailIssuePageState extends State<RepositoryDetailIssuePage>
         page: page);
   }
 
-  @override
-  void initState() {
-    super.initState();
-  }
 
   @override
   bool get wantKeepAlive => true;

lib/page/search/search_page.dart

@@ -315,7 +315,7 @@ class AnimationClipper extends CustomClipper<Path> {
   });
 
   @override
-  bool shouldReclip(old) => true;
+  bool shouldReclip(oldClipper) => true;
 
   @override
   Path getClip(Size size) {

lib/page/welcome_page.dart

@@ -100,7 +100,7 @@ class _WelcomePageState extends State<WelcomePage> {
                     height: size,
                     child: RiveAnimation.asset(
                       'static/file/launch.riv',
-                      animations: ["lookUp"],
+                      animations: const ["lookUp"],
                       onInit: (arb) {
                         var controller =
                             StateMachineController.fromArtboard(arb, "birb");

lib/redux/login_redux.dart

@@ -71,7 +71,7 @@ class LoginMiddleware implements MiddlewareClass<GSYState> {
 }
 
 Stream<dynamic> loginEpic(Stream<dynamic> actions, EpicStore<GSYState> store) {
-  Stream<dynamic> _loginIn(
+  Stream<dynamic> loginIn(
       LoginAction action, EpicStore<GSYState> store) async* {
     CommonUtils.showLoadingDialog(action.context);
     var res = await UserDao.login(
@@ -81,11 +81,11 @@ Stream<dynamic> loginEpic(Stream<dynamic> actions, EpicStore<GSYState> store) {
   }
   return actions
       .whereType<LoginAction>()
-      .switchMap((action) => _loginIn(action, store));
+      .switchMap((action) => loginIn(action, store));
 }
 
 Stream<dynamic> oauthEpic(Stream<dynamic> actions, EpicStore<GSYState> store) {
-  Stream<dynamic> _loginIn(
+  Stream<dynamic> loginIn(
       OAuthAction action, EpicStore<GSYState> store) async* {
     CommonUtils.showLoadingDialog(action.context);
     var res = await UserDao.oauth(action.code, store);
@@ -94,5 +94,5 @@ Stream<dynamic> oauthEpic(Stream<dynamic> actions, EpicStore<GSYState> store) {
   }
   return actions
       .whereType<OAuthAction>()
-      .switchMap((action) => _loginIn(action, store));
+      .switchMap((action) => loginIn(action, store));
 }