Fix battles attacking/blocking (#7075)

* Add battle SBA

---------

Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.59>
Co-authored-by: tool4EvEr <tool4EvEr@192.168.0.60>

Author: 3 people

forge-game/src/main/java/forge/game/GameAction.java

@@ -1659,11 +1659,23 @@ private boolean stateBasedAction_Saga(Card c, CardCollection sacrificeList) {
 
     private boolean stateBasedAction_Battle(Card c, CardCollection removeList) {
         boolean checkAgain = false;
-        if (!c.getType().isBattle()) {
-            return false;
+        if (!c.isBattle()) {
+            return checkAgain;
+        }
+        if (((c.getProtectingPlayer() == null || !c.getProtectingPlayer().isInGame()) &&
+                (game.getCombat() == null || game.getCombat().getAttackersOf(c).isEmpty())) ||
+                (c.getType().hasStringType("Siege") && c.getController().equals(c.getProtectingPlayer()))) {
+            Player newProtector = c.getController().getController().chooseSingleEntityForEffect(c.getController().getOpponents(), null, "Choose an opponent to protect this battle", null);
+            // seems unlikely unless range of influence gets implemented
+            if (newProtector == null) {
+                removeList.add(c);
+            } else {
+                c.setProtectingPlayer(newProtector);
+            }
+            checkAgain = true;
         }
         if (c.getCounters(CounterEnumType.DEFENSE) > 0) {
-            return false;
+            return checkAgain;
         }
         // 704.5v If a battle has defense 0 and it isn't the source of an ability that has triggered but not yet left the stack,
         // it’s put into its owner’s graveyard.

forge-game/src/main/java/forge/game/card/CardFactoryUtil.java

@@ -519,14 +519,6 @@ public static List<String> getSharedKeywords(final Iterable<String> kw, final Ca
         return filteredkw;
     }
 
-    public static int getCardTypesFromList(final CardCollectionView list) {
-        EnumSet<CardType.CoreType> types = EnumSet.noneOf(CardType.CoreType.class);
-        for (Card c1 : list) {
-            c1.getType().getCoreTypes().forEach(types::add);
-        }
-        return types.size();
-    }
-
     /**
      * Adds the ability factory abilities.
      *

forge-game/src/main/java/forge/game/combat/CombatUtil.java

@@ -201,6 +201,10 @@ public static boolean canAttackNextTurn(final Card attacker, final GameEntity de
     private static boolean canAttack(final Card attacker, final GameEntity defender, final boolean forNextTurn) {
         final Game game = attacker.getGame();
 
+        if (attacker.isBattle()) {
+            return false;
+        }
+
         // Basic checks (unless is for next turn)
         if (!forNextTurn && (
                    !attacker.isCreature()
@@ -480,6 +484,10 @@ public static boolean canBlock(final Card blocker, final boolean nextTurn) {
             return false;
         }
 
+        if (blocker.isBattle()) {
+            return false;
+        }
+
         if (!nextTurn && blocker.isTapped() && !blocker.hasKeyword("CARDNAME can block as though it were untapped.")) {
             return false;
         }

forge-game/src/main/java/forge/game/cost/CostExile.java

@@ -222,7 +222,7 @@ else if (type.contains("FromTopGrave")) {
         int amount = this.getAbilityAmount(ability);
 
         if (nTypes > -1) {
-            if (CardFactoryUtil.getCardTypesFromList(list) < nTypes) return false;
+            if (AbilityUtils.countCardTypesFromList(list, false) < nTypes) return false;
         }
 
         if (sharedType) { // will need more logic if cost ever wants more than 2 that share a type

forge-game/src/main/java/forge/game/player/Player.java

@@ -26,6 +26,7 @@
 import forge.game.*;
 import forge.game.ability.AbilityFactory;
 import forge.game.ability.AbilityKey;
+import forge.game.ability.AbilityUtils;
 import forge.game.ability.ApiType;
 import forge.game.ability.effects.DetachedCardEffect;
 import forge.game.ability.effects.RollDiceEffect;
@@ -2176,7 +2177,7 @@ public final void setDescended(final int n) {
     }
 
     public final boolean hasDelirium() {
-        return CardFactoryUtil.getCardTypesFromList(getCardsIn(ZoneType.Graveyard)) >= 4;
+        return AbilityUtils.countCardTypesFromList(getCardsIn(ZoneType.Graveyard), false) >= 4;
     }
 
     public final boolean hasLandfall() {

forge-gui/src/main/java/forge/player/HumanCostDecision.java

@@ -303,7 +303,7 @@ public PaymentDecision visit(final CostExile cost) {
             inp.setCancelAllowed(true);
             inp.showAndWait();
             if (inp.hasCancelled() || 
-                !Expressions.compare(CardFactoryUtil.getCardTypesFromList(list), "GE", nTypes)) {
+                !Expressions.compare(AbilityUtils.countCardTypesFromList(list, false), "GE", nTypes)) {
                     return null;
             }
             return PaymentDecision.card(inp.getSelected());