Network multiplayer optimization (UI improvements) (#9671)

- Connection errors display detailed messages instead of generic failure
- Waiting timer shows player name and elapsed time
  - Add volatile to timer fields for thread safety
  - 1-second reschedule loop for network games only

* Add lobby chat enhancements extracted from NetworkPlay/main

These server-side chat features were missed during the earlier extraction
to NetworkPlay/chat (since merged to master). Moving here as UI-focused.

- Broadcast ready state with player count when toggling ready
- Show (Host) indicator next to host's chat messages
- Distinguish host login ('Lobby hosted by') vs player join ('joined the lobby')
- Detect and announce player name changes
- Fix duplicate message display by removing MessageEvent from LobbyInputHandler
- Use 'left the lobby' instead of 'left the room' for consistency

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Refactor GuiBase.isNetworkplay to support per-instance query (PR 9671 feedback)

Adds an overloaded isNetworkplay(IGuiGame) that checks whether a
specific game instance is networked, rather than relying solely on the
global static boolean which reflects whichever lobby last called
setNetworkplay().

Unmigrated call sites (no-arg fallback, no IGuiGame in scope):
- FThreads (utility class, no game context)

Co-authored-by: tool4EvEr <tool4EvEr@>

Author: MostCromulent

.gitignore

@@ -94,3 +94,6 @@ forge-gui/tools/PerSetTrackingResults
 # Ignore python temporaries
 __pycache__
 *.pyc
+
+# Ignore Claude configuration
+.claude

forge-gui-desktop/src/main/java/forge/GuiDesktop.java

@@ -368,6 +368,14 @@ private static float initializeScreenScale() {
     }
     static float screenScale = initializeScreenScale();
 
+    @Override
+    public boolean hasNetGame() {
+        if (Singletons.getView() == null || Singletons.getView().getNavigationBar() == null) {
+            return false;
+        }
+        return Singletons.getView().getNavigationBar().hasNetGame();
+    }
+
     @Override
     public float getScreenScale() {
         return screenScale;

forge-gui-desktop/src/main/java/forge/screens/home/VLobby.java

@@ -33,7 +33,6 @@
 import forge.gamemodes.match.LobbySlotType;
 import forge.gamemodes.net.event.UpdateLobbyPlayerEvent;
 import forge.gui.CardDetailPanel;
-import forge.gui.GuiBase;
 import forge.gui.SwingPrefBinders;
 import forge.gui.interfaces.ILobbyView;
 import forge.gui.util.SOptionPane;
@@ -247,8 +246,6 @@ public void update(final boolean fullUpdate) {
 
         final boolean allowNetworking = lobby.isAllowNetworking();
 
-        GuiBase.setNetworkplay(allowNetworking);
-
         ImmutableList<VariantCheckBox> vntBoxes = null;
         if (allowNetworking) {
             vntBoxes = vntBoxesNetwork;

forge-gui-desktop/src/main/java/forge/screens/home/online/CSubmenuOnlineLobby.java

@@ -86,10 +86,16 @@ private void join(final String url) {
         });
 
         final ChatMessage result = NetConnectUtil.join(url, VSubmenuOnlineLobby.SINGLETON_INSTANCE, FNetOverlay.SINGLETON_INSTANCE);
-        if(Objects.equals(result.getMessage(), ForgeConstants.CLOSE_CONN_COMMAND)) {
+        String message = result.getMessage();
+        if(Objects.equals(message, ForgeConstants.CLOSE_CONN_COMMAND)) {
             FOptionPane.showErrorDialog(Localizer.getInstance().getMessage("UnableConnectToServer", url));
             SOverlayUtils.hideOverlay();
-        } else if (Objects.equals(result.getMessage(), ForgeConstants.INVALID_HOST_COMMAND)) {
+        } else if (message != null && message.startsWith(ForgeConstants.CONN_ERROR_PREFIX)) {
+            // Show detailed connection error
+            String errorDetail = message.substring(ForgeConstants.CONN_ERROR_PREFIX.length());
+            FOptionPane.showErrorDialog(errorDetail, Localizer.getInstance().getMessage("lblConnectionError"));
+            SOverlayUtils.hideOverlay();
+        } else if (Objects.equals(message, ForgeConstants.INVALID_HOST_COMMAND)) {
             FOptionPane.showErrorDialog(Localizer.getInstance().getMessage("lblDetectedInvalidHostAddress", url));
             SOverlayUtils.hideOverlay();
         } else {

forge-gui-desktop/src/main/java/forge/screens/match/CMatchUI.java

@@ -963,16 +963,22 @@ public void popupMenuCanceled(PopupMenuEvent e) {
 
     @Override
     public void showPromptMessage(final PlayerView playerView, final String message) {
+        cancelWaitingTimer();
+        cPrompt.setMessage(message);
+    }
+    public void showPromptMessageNoCancel(final PlayerView playerView, final String message) {
         cPrompt.setMessage(message);
     }
 
     @Override
     public void showCardPromptMessage(PlayerView playerView, String message, CardView card) {
+        cancelWaitingTimer();
         cPrompt.setMessage(message, card);
     }
 
     //  no override for now
     public void showPromptMessage(final PlayerView playerView, final String message, final CardView card ) {
+        cancelWaitingTimer();
         cPrompt.setMessage(message,card);
     }
 

forge-gui-desktop/src/main/java/forge/view/FNavigationBar.java

@@ -24,6 +24,7 @@
 import com.google.common.collect.Lists;
 
 import forge.Singletons;
+import forge.gamemodes.match.AbstractGuiGame;
 import forge.gui.framework.FScreen;
 import forge.gui.framework.ILocalRepaint;
 import forge.localinstance.properties.ForgePreferences;
@@ -185,6 +186,11 @@ private void closeTab(final NavigationTab tab) {
         }
     }
 
+    public boolean hasNetGame() {
+        return tabs.stream().filter(t -> t.getScreen().getController() instanceof AbstractGuiGame game
+                && game.isNetGame()).findAny().map(b -> true).orElse(false);
+    }
+
     @Override
     public void updateButtons() {
         super.updateButtons();
@@ -475,6 +481,10 @@ public void paintComponent(final Graphics g) {
             super.paintComponent(g);
         }
 
+        public FScreen getScreen() {
+            return screen;
+        }
+
         private void updateTitle() {
             setText(screen.getTabCaption());
         }

forge-gui-mobile/src/forge/GuiMobile.java

@@ -362,6 +362,11 @@ public void preventSystemSleep(boolean preventSleep) {
         Forge.getDeviceAdapter().preventSystemSleep(preventSleep);
     }
 
+    @Override
+    public boolean hasNetGame() {
+        return MatchController.instance.isNetGame();
+    }
+
     @Override
     public float getScreenScale() {
         return 1f;

forge-gui-mobile/src/forge/screens/constructed/LobbyScreen.java

@@ -602,8 +602,6 @@ public void update(final boolean fullUpdate) {
 
         final boolean allowNetworking = lobby.isAllowNetworking();
 
-        GuiBase.setNetworkplay(allowNetworking);
-
         setStartButtonAvailability();
 
         for (int i = 0; i < cbPlayerCount.getSelectedItem(); i++) {

forge-gui-mobile/src/forge/screens/match/MatchController.java

@@ -143,7 +143,7 @@ public void refreshCardDetails(final Iterable<CardView> cards) {
 
     @Override
     public void refreshField() {
-        if(!GuiBase.isNetworkplay())
+        if(!GuiBase.isNetworkplay(this))
             return;
         refreshCardDetails(null);
     }
@@ -182,7 +182,7 @@ public void openView(final TrackableCollection<PlayerView> myPlayers) {
             }
         }
         view = new MatchScreen(playerPanels);
-        if(GuiBase.isNetworkplay())
+        if(GuiBase.isNetworkplay(this))
             view.resetFields();
         clearSelectables();  //fix uncleared selection
 
@@ -211,11 +211,16 @@ public void buildTouchListeners(final float screenX, final float screenY, final
 
     @Override
     public void showPromptMessage(final PlayerView player, final String message) {
+        cancelWaitingTimer();
+        view.getPrompt(player).setMessage(message);
+    }
+    public void showPromptMessageNoCancel(final PlayerView player, final String message) {
         view.getPrompt(player).setMessage(message);
     }
 
     @Override
     public void showCardPromptMessage(final PlayerView player, final String message, final CardView card) {
+        cancelWaitingTimer();
         view.getPrompt(player).setMessage(message, card);
     }
 
@@ -251,19 +256,19 @@ public void updatePhase(boolean saveState) {
                 final VPhaseIndicator.PhaseLabel phaseLabel = view.getPlayerPanel(lastPlayer).getPhaseIndicator().getLabel(ph);
                 if (phaseLabel != null)
                     phaseLabel.setActive(true);
-                if (GuiBase.isNetworkplay())
+                if (GuiBase.isNetworkplay(this))
                     getGameView().updateNeedsPhaseRedrawn(lastPlayer, PhaseType.CLEANUP);
             } else if (getGameView().getPlayerTurn() != null) {
                 //set phaselabel
                 final VPhaseIndicator.PhaseLabel phaseLabel = view.getPlayerPanel(getGameView().getPlayerTurn()).getPhaseIndicator().getLabel(ph);
                 if (phaseLabel != null)
                     phaseLabel.setActive(true);
-                if (GuiBase.isNetworkplay())
+                if (GuiBase.isNetworkplay(this))
                     getGameView().updateNeedsPhaseRedrawn(getGameView().getPlayerTurn(), ph);
             }
         }
 
-        if(GuiBase.isNetworkplay())
+        if(GuiBase.isNetworkplay(this))
             checkStack();
 
         if (ph != null && saveState && ph.isMain()) {

forge-gui-mobile/src/forge/screens/match/MatchScreen.java

@@ -126,7 +126,7 @@ public MatchScreen(List<VPlayerPanel> playerPanels0) {
                 e -> getGameController().selectButtonOk(),
                 e -> getGameController().selectButtonCancel()));
 
-        if (humanCount < 2 || MatchController.instance.hotSeatMode() || GuiBase.isNetworkplay())
+        if (humanCount < 2 || MatchController.instance.hotSeatMode() || GuiBase.isNetworkplay(MatchController.instance))
             topPlayerPrompt = null;
         else {
             //show top prompt if multiple human players and not playing in Hot Seat mode and not in network play
@@ -378,7 +378,7 @@ protected void drawOverlay(Graphics g) {
             if (devMenu.isVisible()) {
                 try {
                     //rollbackphase enable -- todo limit by gametype?
-                    devMenu.getChildAt(2).setEnabled(game.getPlayers().size() == 2 && game.getStack().size() == 0 && !GuiBase.isNetworkplay() && game.getPhase().isMain() && !game.getPlayerTurn().isAI());
+                    devMenu.getChildAt(2).setEnabled(game.getPlayers().size() == 2 && game.getStack().size() == 0 && !GuiBase.isNetworkplay(MatchController.instance) && game.getPhase().isMain() && !game.getPlayerTurn().isAI());
                 } catch (Exception e) {/*NPE when the game hasn't started yet and you click dev mode*/}
             }
         }