Clearer complement calculation

Author: timorleph

Cargo.lock

@@ -60,7 +60,7 @@ More details are available [in the book][reference-link-implementation-details].
 - Import AlephBFT in your crate
   ```toml
   [dependencies]
-  aleph-bft = "^0.43"
+  aleph-bft = "^0.44"
   ```
 - The main entry point is the `run_session` function, which returns a Future that runs the
   consensus algorithm.

README.md

@@ -1,6 +1,6 @@
 [package]
 name = "aleph-bft"
-version = "0.43.1"
+version = "0.44.0"
 edition = "2021"
 authors = ["Cardinal Cryptography"]
 categories = ["algorithms", "data-structures", "cryptography", "database"]
@@ -13,8 +13,8 @@ readme = "../README.md"
 description = "AlephBFT is an asynchronous and Byzantine fault tolerant consensus protocol aimed at ordering arbitrary messages (transactions). It has been designed to continuously operate even in the harshest conditions: with no bounds on message-delivery delays and in the presence of malicious actors. This makes it an excellent fit for blockchain-related applications."
 
 [dependencies]
-aleph-bft-rmc = { path = "../rmc", version = "0.14" }
-aleph-bft-types = { path = "../types", version = "0.14" }
+aleph-bft-rmc = { path = "../rmc", version = "0.15" }
+aleph-bft-types = { path = "../types", version = "0.15" }
 anyhow = "1.0"
 async-trait = "0.1"
 codec = { package = "parity-scale-codec", version = "3.0", default-features = false, features = ["derive"] }

consensus/Cargo.toml

@@ -196,9 +196,9 @@ impl<'a, MK: Keychain> Collection<'a, MK> {
 
     fn missing_responders(&self) -> Vec<Recipient> {
         self.collected_starting_rounds
-            .size()
-            .into_iterator()
-            .filter(|node_id| self.collected_starting_rounds.get(*node_id).is_none())
+            .to_subset()
+            .complement()
+            .elements()
             .map(Recipient::Node)
             .collect()
     }

consensus/src/collection/mod.rs

@@ -1,6 +1,6 @@
 [package]
 name = "aleph-bft-crypto"
-version = "0.9.1"
+version = "0.10.0"
 edition = "2021"
 authors = ["Cardinal Cryptography"]
 documentation = "https://docs.rs/?"

crypto/Cargo.toml

@@ -237,6 +237,12 @@ impl NodeSubset {
             .filter_map(|(i, b)| if b { Some(i.into()) } else { None })
     }
 
+    pub fn complement(&self) -> NodeSubset {
+        let mut result = self.0.clone();
+        result.negate();
+        NodeSubset(result)
+    }
+
     pub fn len(&self) -> usize {
         self.elements().count()
     }

crypto/src/node.rs

@@ -1,6 +1,6 @@
 [package]
 name = "aleph-bft-mock"
-version = "0.16.0"
+version = "0.17.0"
 edition = "2021"
 authors = ["Cardinal Cryptography"]
 documentation = "https://docs.rs/?"
@@ -11,7 +11,7 @@ readme = "./README.md"
 description = "Mock implementations of traits required by the aleph-bft package. Do NOT use outside of testing!"
 
 [dependencies]
-aleph-bft-types = { path = "../types", version = "0.14" }
+aleph-bft-types = { path = "../types", version = "0.15" }
 async-trait = "0.1"
 codec = { package = "parity-scale-codec", version = "3.0", default-features = false, features = ["derive"] }
 futures = "0.3"

mock/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "aleph-bft-rmc"
-version = "0.14.0"
+version = "0.15.0"
 edition = "2021"
 authors = ["Cardinal Cryptography"]
 categories = ["algorithms", "cryptography"]
@@ -13,8 +13,8 @@ readme = "./README.md"
 description = "Reliable MultiCast - a primitive for Reliable Broadcast protocol."
 
 [dependencies]
-aleph-bft-crypto = { path = "../crypto", version = "0.9" }
-aleph-bft-types = { path = "../types", version = "0.14" }
+aleph-bft-crypto = { path = "../crypto", version = "0.10" }
+aleph-bft-types = { path = "../types", version = "0.15" }
 async-trait = "0.1"
 codec = { package = "parity-scale-codec", version = "3.0", default-features = false, features = ["derive"] }
 futures = "0.3"

rmc/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "aleph-bft-types"
-version = "0.14.0"
+version = "0.15.0"
 edition = "2021"
 authors = ["Cardinal Cryptography"]
 documentation = "https://docs.rs/?"
@@ -11,7 +11,7 @@ readme = "./README.md"
 description = "Traits that need to be implemented by the user of the aleph-bft package."
 
 [dependencies]
-aleph-bft-crypto = { path = "../crypto", version = "0.9" }
+aleph-bft-crypto = { path = "../crypto", version = "0.10" }
 async-trait = "0.1"
 codec = { package = "parity-scale-codec", version = "3.0", default-features = false, features = ["derive"] }
 futures = "0.3"