Review improvements

Author: timorleph

consensus/src/dissemination/mod.rs

@@ -83,7 +83,7 @@ pub enum DisseminationResponse<H: Hasher, D: Data, S: Signature> {
     NewestUnit(UncheckedSigned<NewestUnitResponse<H, D, S>, S>),
 }
 
-/// A message that has to be passed between committe members for consensus to work.
+/// A message that has to be passed between committee members for consensus to work.
 #[derive(Eq, PartialEq, Debug, Clone)]
 pub enum DisseminationMessage<H: Hasher, D: Data, S: Signature> {
     /// Unit, either broadcast or in response to a coord request.

consensus/src/dissemination/task.rs

@@ -1,6 +1,6 @@
 use crate::{dag::Request, runway::Salt, units::UncheckedSignedUnit, Data, Hasher, Signature};
 
-/// Repeatable task, either requesting or broadcasting a unit.
+/// Task that needs to be performed to ensure successful unit dissemination, either requesting or broadcasting a unit.
 #[derive(Eq, PartialEq, Debug, Clone)]
 pub enum DisseminationTask<H: Hasher, D: Data, S: Signature> {
     /// Perform a request.

consensus/src/network/unit.rs

@@ -27,14 +27,12 @@ impl<H: Hasher, D: Data, S: Signature> UnitMessage<H, D, S> {
         use UnitMessage::*;
         match self {
             Unit(uu) => uu.as_signable().included_data(),
-            CoordRequest(_, _) => Vec::new(),
-            ParentsRequest(_, _) => Vec::new(),
             ParentsResponse(_, units) => units
                 .iter()
                 .flat_map(|uu| uu.as_signable().included_data())
                 .collect(),
-            NewestRequest(_, _) => Vec::new(),
             NewestResponse(response) => response.as_signable().included_data(),
+            NewestRequest(_, _) | CoordRequest(_, _) | ParentsRequest(_, _) => Vec::new(),
         }
     }
 }