Review

Author: Marcin-Radecki

consensus/src/extension/election.rs

@@ -102,14 +102,14 @@ impl<U: UnitWithParents> CandidateElection<U> {
             return Ok(());
         }
         let relative_round = voter.round() - self.round;
-        let direct_parents = voter.direct_parents().cloned().collect();
         let vote = match relative_round {
             0 => unreachable!("just checked that voter and election rounds are not equal"),
             // Direct descendands vote for, all other units of that round against.
             1 => voter.parent_for(self.candidate_creator) == Some(&self.candidate_hash),
             // Otherwise we compute the vote based on the parents' votes.
             _ => {
                 let threshold = voter.node_count().consensus_threshold();
+                let direct_parents = voter.direct_parents().cloned().collect();
                 self.vote_from_parents(direct_parents, threshold, relative_round)?
             }
         };

consensus/src/testing/dag.rs

@@ -139,7 +139,7 @@ impl DagFeeder {
 
     fn on_reconstructed_unit(&mut self, unit: ReconstructedUnit) {
         let h = unit.hash();
-        let parents = unit.parents().cloned().collect::<Vec<_>>();
+        let parents: HashSet<_> = unit.parents().cloned().collect();
         let expected_hashes: HashSet<_> = self
             .units_map
             .get(&h)
@@ -148,7 +148,7 @@ impl DagFeeder {
             .into_iter()
             .collect();
 
-        assert_eq!(parents.into_iter().collect::<HashSet<_>>(), expected_hashes);
+        assert_eq!(parents, expected_hashes);
         self.result.push(unit.clone());
         self.store.insert(unit);
     }