A0-4260: Only support full sync mode (#1688)

# Description

We don't really support other sync modes than `Full` for our node
anyway, so this changes the config and warns the user on startup.

## Type of change

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)

# Checklist:

- I have created new documentation

Author: timorleph

bin/node/src/config/mod.rs

@@ -0,0 +1,30 @@
+use crate::Cli;
+
+mod pruning;
+mod sync;
+
+use pruning::PruningConfigValidator;
+use sync::SyncConfigValidator;
+
+/// Validate and modify the configuration to make it conform to our assumptions.
+pub struct Validator {
+    pruning: PruningConfigValidator,
+    sync: SyncConfigValidator,
+}
+
+impl Validator {
+    /// Modifies the settings.
+    pub fn process(cli: &mut Cli) -> Self {
+        Validator {
+            pruning: PruningConfigValidator::process(cli),
+            sync: SyncConfigValidator::process(cli),
+        }
+    }
+
+    /// Warns the user about the modified settings.
+    pub fn report(self) {
+        let Validator { pruning, sync } = self;
+        pruning.report();
+        sync.report();
+    }
+}

bin/node/src/pruning_config.rs renamed to bin/node/src/config/pruning.rs

@@ -140,7 +140,7 @@ mod tests {
     use sc_service::{BlocksPruning, PruningMode};
 
     use super::PruningParams;
-    use crate::pruning_config::{DEFAULT_BLOCKS_PRUNING, DEFAULT_STATE_PRUNING};
+    use crate::config::pruning::{DEFAULT_BLOCKS_PRUNING, DEFAULT_STATE_PRUNING};
 
     #[test]
     fn pruning_sanity_check() {

bin/node/src/config/sync.rs

@@ -0,0 +1,31 @@
+use log::warn;
+use sc_cli::arg_enums::SyncMode;
+
+use crate::Cli;
+
+/// Modifies the sync config to ensure only full sync is used.
+pub struct SyncConfigValidator {
+    overwritten: Option<SyncMode>,
+}
+
+impl SyncConfigValidator {
+    /// Modifies the settings.
+    pub fn process(cli: &mut Cli) -> Self {
+        let overwritten = match cli.run.network_params.sync {
+            SyncMode::Full => None,
+            mode => Some(mode),
+        };
+        cli.run.network_params.sync = SyncMode::Full;
+        SyncConfigValidator { overwritten }
+    }
+
+    /// Warns the user if they attempted to use a sync setting other than full.
+    pub fn report(self) {
+        if let Some(mode) = self.overwritten {
+            warn!(
+                "Only full sync mode is supported, ignoring request for {:?} mode.",
+                mode
+            );
+        }
+    }
+}

bin/node/src/lib.rs

@@ -2,12 +2,14 @@ mod aleph_cli;
 mod aleph_node_rpc;
 mod chain_spec;
 mod cli;
+mod config;
 mod executor;
 mod resources;
 mod rpc;
 mod service;
 
 pub use cli::{Cli, Subcommand};
+pub use config::Validator as ConfigValidator;
 #[cfg(any(
     feature = "runtime-benchmarks",
     feature = "local-debugging",

bin/node/src/main.rs

@@ -1,9 +1,6 @@
-mod pruning_config;
-
-use aleph_node::{new_authority, new_partial, Cli, Subcommand};
+use aleph_node::{new_authority, new_partial, Cli, ConfigValidator, Subcommand};
 use log::info;
 use primitives::HEAP_PAGES;
-use pruning_config::PruningConfigValidator;
 use sc_cli::{clap::Parser, SubstrateCli};
 use sc_network::config::Role;
 use sc_service::{Configuration, PartialComponents};
@@ -15,7 +12,7 @@ fn enforce_heap_pages(config: &mut Configuration) {
 fn main() -> sc_cli::Result<()> {
     let mut cli = Cli::parse();
 
-    let pruning_config_validation_result = PruningConfigValidator::process(&mut cli);
+    let config_validation_result = ConfigValidator::process(&mut cli);
 
     match &cli.subcommand {
         Some(Subcommand::BootstrapChain(cmd)) => cmd.run(),
@@ -142,7 +139,7 @@ fn main() -> sc_cli::Result<()> {
         None => {
             let runner = cli.create_runner(&cli.run)?;
 
-            pruning_config_validation_result.report();
+            config_validation_result.report();
 
             let mut aleph_cli_config = cli.aleph;
             runner.run_node_until_exit(|mut config| async move {