improve coverage rate (antgroup#330)

- improve coverage on brute force
- remove unused function
- add parameter ToJson test

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>

Author: LHT129

src/io/memory_block_io_parameter_test.cpp

@@ -0,0 +1,29 @@
+
+// Copyright 2024-present the vsag project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "memory_block_io_parameter.h"
+
+#include <catch2/catch_test_macros.hpp>
+
+#include "parameter_test.h"
+
+using namespace vsag;
+
+TEST_CASE("memory_block_io_parameter", "[ut][memory_block_io]") {
+    std::string param_str = "{}";
+    auto param = std::make_shared<MemoryBlockIOParameter>();
+    param->FromJson(param_str);
+    ParameterTest::TestToJson(param);
+}

src/io/memory_io_parameter_test.cpp

@@ -0,0 +1,29 @@
+
+// Copyright 2024-present the vsag project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "memory_io_parameter.h"
+
+#include <catch2/catch_test_macros.hpp>
+
+#include "parameter_test.h"
+
+using namespace vsag;
+
+TEST_CASE("memory_io_parameter", "[ut][memory_io]") {
+    std::string param_str = "{}";
+    auto param = std::make_shared<MemoryIOParameter>();
+    param->FromJson(param_str);
+    ParameterTest::TestToJson(param);
+}

src/parameter_test.h

@@ -0,0 +1,33 @@
+
+// Copyright 2024-present the vsag project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#pragma once
+
+#include <catch2/catch_test_macros.hpp>
+
+#include "parameter.h"
+
+namespace vsag {
+class ParameterTest {
+public:
+    static void
+    TestToJson(const ParamPtr& param) {
+        auto json1 = param->ToJson();
+        auto str1 = param->ToString();
+        param->FromJson(json1);
+        REQUIRE(param->ToString() == str1);
+    }
+};
+}  // namespace vsag

src/quantization/fp32_quantizer_parameter_test.cpp

@@ -0,0 +1,29 @@
+
+// Copyright 2024-present the vsag project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "fp32_quantizer_parameter.h"
+
+#include <catch2/catch_test_macros.hpp>
+
+#include "parameter_test.h"
+
+using namespace vsag;
+
+TEST_CASE("fp32_quantizer_parameter", "[ut][fp32_quantizer_parameter]") {
+    std::string param_str = "{}";
+    auto param = std::make_shared<FP32QuantizerParameter>();
+    param->FromJson(param_str);
+    ParameterTest::TestToJson(param);
+}

src/quantization/scalar_quantization/sq4_quantizer_parameter_test.cpp

@@ -0,0 +1,29 @@
+
+// Copyright 2024-present the vsag project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "sq4_quantizer_parameter.h"
+
+#include <catch2/catch_test_macros.hpp>
+
+#include "parameter_test.h"
+
+using namespace vsag;
+
+TEST_CASE("sq4_quantizer_parameter", "[ut][sq4_quantizer_parameter]") {
+    std::string param_str = "{}";
+    auto param = std::make_shared<SQ4QuantizerParameter>();
+    param->FromJson(param_str);
+    ParameterTest::TestToJson(param);
+}

src/quantization/scalar_quantization/sq4_uniform_quantizer.h

@@ -289,7 +289,6 @@ SQ4UniformQuantizer<metric>::ProcessQueryImpl(const DataType* query,
         computer.buf_ = reinterpret_cast<uint8_t*>(this->allocator_->Allocate(this->code_size_));
         this->EncodeOneImpl(query, computer.buf_);
     } catch (const std::bad_alloc& e) {
-        computer.buf_ = nullptr;
         logger::error("bad alloc when init computer buf");
         throw std::bad_alloc();
     }

src/quantization/scalar_quantization/sq4_uniform_quantizer_parameter_test.cpp

@@ -0,0 +1,29 @@
+
+// Copyright 2024-present the vsag project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "sq4_uniform_quantizer_parameter.h"
+
+#include <catch2/catch_test_macros.hpp>
+
+#include "parameter_test.h"
+
+using namespace vsag;
+
+TEST_CASE("sq4_uniform_quantizer_parameter", "[ut][sq4_uniform_quantizer_parameter]") {
+    std::string param_str = "{}";
+    auto param = std::make_shared<SQ4UniformQuantizerParameter>();
+    param->FromJson(param_str);
+    ParameterTest::TestToJson(param);
+}

src/quantization/scalar_quantization/sq8_quantizer_parameter_test.cpp

@@ -0,0 +1,29 @@
+
+// Copyright 2024-present the vsag project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "sq8_quantizer_parameter.h"
+
+#include <catch2/catch_test_macros.hpp>
+
+#include "parameter_test.h"
+
+using namespace vsag;
+
+TEST_CASE("sq8_quantizer_parameter", "[ut][sq8_quantizer_parameter]") {
+    std::string param_str = "{}";
+    auto param = std::make_shared<SQ8QuantizerParameter>();
+    param->FromJson(param_str);
+    ParameterTest::TestToJson(param);
+}

src/quantization/scalar_quantization/sq8_uniform_quantizer.h

@@ -266,7 +266,6 @@ SQ8UniformQuantizer<metric>::ProcessQueryImpl(const DataType* query,
         computer.buf_ = reinterpret_cast<uint8_t*>(this->allocator_->Allocate(this->code_size_));
         this->EncodeOneImpl(query, computer.buf_);
     } catch (const std::bad_alloc& e) {
-        computer.buf_ = nullptr;
         logger::error("bad alloc when init computer buf");
         throw std::bad_alloc();
     }

src/quantization/scalar_quantization/sq8_uniform_quantizer_parameter_test.cpp

@@ -0,0 +1,29 @@
+
+// Copyright 2024-present the vsag project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "sq8_uniform_quantizer_parameter.h"
+
+#include <catch2/catch_test_macros.hpp>
+
+#include "parameter_test.h"
+
+using namespace vsag;
+
+TEST_CASE("sq8_uniform_quantizer_parameter", "[ut][sq8_uniform_quantizer_parameter]") {
+    std::string param_str = "{}";
+    auto param = std::make_shared<SQ8UniformQuantizerParameter>();
+    param->FromJson(param_str);
+    ParameterTest::TestToJson(param);
+}