enable clang-analyzer-* checks in clang-tidy (antgroup#375)

Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>

Author: wxyucs

.clang-tidy

@@ -18,7 +18,8 @@ Checks: >
     -*,
     bugprone-*,
     -bugprone-easily-swappable-parameters,
-    # clang-analyzer-*,
+    clang-analyzer-*,
+    -clang-analyzer-deadcode.DeadStores, # value stored but never read
     # clang-diagnostic-*,
     -clang-diagnostic-deprecated-builtins,
     # google-*,

src/factory/factory.cpp

@@ -66,7 +66,11 @@ class LocalFileReader : public Reader {
     void
     AsyncRead(uint64_t offset, uint64_t len, void* dest, CallBack callback) override {
         if (pool_) {
-            pool_->GeneralEnqueue([this, offset, len, dest, callback]() {
+            pool_->GeneralEnqueue([this,  // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
+                                   offset,
+                                   len,
+                                   dest,
+                                   callback]() {
                 this->Read(offset, len, dest);
                 callback(IOErrorCode::IO_SUCCESS, "success");
             });

src/impl/basic_searcher.cpp

@@ -15,6 +15,8 @@
 
 #include "basic_searcher.h"
 
+#include <limits>
+
 namespace vsag {
 
 BasicSearcher::BasicSearcher(const IndexCommonParam& common_param) {
@@ -65,7 +67,7 @@ BasicSearcher::Search(const GraphInterfacePtr& graph_data_cell,
 
     auto computer = vector_data_cell->FactoryComputer(query);
 
-    float lower_bound;
+    float lower_bound = std::numeric_limits<float>::max();
     float dist;
     uint64_t candidate_id;
     uint32_t hops = 0;

src/index/diskann.cpp

@@ -94,7 +94,11 @@ class LocalMemoryReader : public Reader {
     void
     AsyncRead(uint64_t offset, uint64_t len, void* dest, CallBack callback) override {
         if (pool_) {
-            pool_->GeneralEnqueue([this, offset, len, dest, callback]() {
+            pool_->GeneralEnqueue([this,  // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
+                                   offset,
+                                   len,
+                                   dest,
+                                   callback]() {
                 this->Read(offset, len, dest);
                 callback(IOErrorCode::IO_SUCCESS, "success");
             });

src/index/diskann_zparameters.h

@@ -30,12 +30,12 @@ struct DiskannParameters {
 
 public:
     // require vars
-    int64_t dim;
-    diskann::Metric metric;
-    int64_t max_degree;
-    int64_t ef_construction;
-    int64_t pq_dims;
-    float pq_sample_rate;
+    int64_t dim{-1};
+    diskann::Metric metric{diskann::Metric::L2};
+    int64_t max_degree{-1};
+    int64_t ef_construction{-1};
+    int64_t pq_dims{-1};
+    float pq_sample_rate{.0f};
 
     // optional vars with default value
     bool use_preload = false;
@@ -61,9 +61,9 @@ struct DiskannSearchParameters {
 
 public:
     // required vars
-    int64_t ef_search;
-    uint64_t beam_search;
-    int64_t io_limit;
+    int64_t ef_search{-1};
+    uint64_t beam_search{0};
+    int64_t io_limit{-1};
 
     // optional vars with default value
     bool use_reorder = false;

src/index/hnsw_zparameters.h

@@ -38,7 +38,7 @@ struct HnswParameters {
     bool use_static{false};
     bool normalize{false};
     bool use_reversed_edges{false};
-    DataTypes type;
+    DataTypes type{DataTypes::DATA_TYPE_FLOAT};
 
 protected:
     HnswParameters() = default;

src/io/memory_io_parameter.cpp

@@ -24,7 +24,7 @@ MemoryIOParameter::MemoryIOParameter() : IOParameter(IO_TYPE_VALUE_MEMORY_IO) {
 
 MemoryIOParameter::MemoryIOParameter(const vsag::JsonType& json)
     : IOParameter(IO_TYPE_VALUE_MEMORY_IO) {
-    this->FromJson(json);
+    this->FromJson(json);  // NOLINT(clang-analyzer-optin.cplusplus.VirtualCall)
 }
 
 void

src/safe_thread_pool.h

@@ -48,7 +48,7 @@ class SafeThreadPool : public ThreadPool {
 
         std::future<return_type> res = task->get_future();
         Enqueue([task]() { (*task)(); });
-        return res;
+        return res;  // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
     }
 
     std::future<void>