Skip to content

Commit 6771f8c

Browse files
authored
Merge pull request #108 from Carthage/equatable-tweaks
Equatable tweaks
2 parents eae2415 + c1a3d0a commit 6771f8c

File tree

2 files changed

+2
-30
lines changed

2 files changed

+2
-30
lines changed

Sources/Errors.swift

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import Foundation
1010

1111
/// An error originating from ReactiveTask.
12-
public enum TaskError: Error {
12+
public enum TaskError: Error, Equatable {
1313
/// A shell task exited unsuccessfully.
1414
case shellTaskFailed(Task, exitCode: Int32, standardError: String?)
1515

@@ -33,18 +33,3 @@ extension TaskError: CustomStringConvertible {
3333
}
3434
}
3535
}
36-
37-
extension TaskError: Equatable {
38-
public static func == (lhs: TaskError, rhs: TaskError) -> Bool {
39-
switch (lhs, rhs) {
40-
case let (.shellTaskFailed(lhsTask, lhsCode, lhsErr), .shellTaskFailed(rhsTask, rhsCode, rhsErr)):
41-
return lhsTask == rhsTask && lhsCode == rhsCode && lhsErr == rhsErr
42-
43-
case let (.posixError(lhsCode), .posixError(rhsCode)):
44-
return lhsCode == rhsCode
45-
46-
default:
47-
return false
48-
}
49-
}
50-
}

Sources/Task.swift

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -88,19 +88,6 @@ extension Task: Hashable {
8888
}
8989
}
9090

91-
private func ==<Key, Value: Equatable>(lhs: [Key: Value]?, rhs: [Key: Value]?) -> Bool {
92-
switch (lhs, rhs) {
93-
case let (lhs?, rhs?):
94-
return lhs == rhs
95-
96-
case (.none, .none):
97-
return true
98-
99-
default:
100-
return false
101-
}
102-
}
103-
10491
/// A private class used to encapsulate a Unix pipe.
10592
private final class Pipe {
10693
typealias ReadProducer = SignalProducer<Data, TaskError>
@@ -331,7 +318,7 @@ public enum TaskEvent<T>: TaskEventType {
331318
}
332319
}
333320

334-
extension TaskEvent where T: Equatable {
321+
extension TaskEvent: Equatable where T: Equatable {
335322
public static func == (lhs: TaskEvent<T>, rhs: TaskEvent<T>) -> Bool {
336323
switch (lhs, rhs) {
337324
case let (.launch(left), .launch(right)):

0 commit comments

Comments
 (0)