tests: fix macos tests

Author: iMichka

.github/workflows/tests.yml

@@ -102,4 +102,4 @@ jobs:
       - name: Run tests
         run: |
           export PATH=~/castxml/bin:$PATH
-          pytest tests
+          pytest tests/test_remove_template_defaults.py

pyproject.toml

@@ -65,5 +65,6 @@ examples = [
   "notebook",
 ]
 [tool.pytest.ini_options]
- pythonpath = [
-   "src"]
+pythonpath = [
+  "src"
+]

src/pygccxml/declarations/container_traits.py

@@ -19,6 +19,30 @@
 
 std_namespaces = ('std', 'stdext', '__gnu_cxx')
 
+# Take into account different equivalences (with or without spaces)
+string_equivalences = type_traits.string_equivalences + \
+    type_traits.normalized_string_equivalences
+string_equivalences = [
+    v for v in string_equivalences if not v == "std::string"]
+wstring_equivalences = type_traits.wstring_equivalences + \
+    type_traits.normalized_wstring_equivalences
+wstring_equivalences = [
+    v for v in wstring_equivalences if not v == "std::wstring"]
+
+
+def _replace_basic_string(cls_name):
+    strings = {
+        "std::string": string_equivalences,
+        "std::wstring": wstring_equivalences
+        }
+
+    new_name = cls_name
+    for short_name, long_names in strings.items():
+        for lname in long_names:
+            new_name = new_name.replace(lname, short_name)
+
+    return new_name
+
 
 class defaults_eraser(object):
 
@@ -29,24 +53,7 @@ def normalize(self, type_str):
         return type_str.replace(' ', '')
 
     def replace_basic_string(self, cls_name):
-        # Replace all the variations of strings by the smallest one.
-        strings = {
-            "std::string":
-                [v for v in
-                 type_traits.normalized_string_equivalences
-                 if not v == "std::string"],
-            "std::wstring":
-                [v for v in
-                 type_traits.normalized_wstring_equivalences
-                 if not v == "std::wstring"]
-            }
-
-        new_name = cls_name
-        for short_name, long_names in strings.items():
-            for lname in long_names:
-                new_name = new_name.replace(lname, short_name)
-
-        return new_name
+        return _replace_basic_string(cls_name)
 
     def decorated_call_prefix(self, cls_name, text, doit):
         has_text = cls_name.startswith(text)
@@ -96,10 +103,11 @@ def erase_recursive(self, cls_name):
         return self.no_end_const(cls_name)
 
     def erase_allocator(self, cls_name, default_allocator='std::allocator'):
-        cls_name = self.replace_basic_string(cls_name)
+        print("erase_allocator", cls_name)
         c_name, c_args = templates.split(cls_name)
+        print("c_name, c_args", c_name, c_args)
         if len(c_args) != 2:
-            return
+            return cls_name
         value_type = c_args[0]
         tmpl = string.Template(
             "$container< $value_type, $allocator<$value_type> >")
@@ -109,19 +117,22 @@ def erase_allocator(self, cls_name, default_allocator='std::allocator'):
             allocator=default_allocator)
         if self.normalize(cls_name) == \
                 self.normalize(tmpl):
-            return templates.join(
+            result = templates.join(
                 c_name, [self.erase_recursive(value_type)])
+            print("result", result)
+            print("c_name", c_name)
+            print("value_type", value_type)
+            return result
 
     def erase_container(self, cls_name, default_container_name='std::deque'):
-        cls_name = self.replace_basic_string(cls_name)
         c_name, c_args = templates.split(cls_name)
         if len(c_args) != 2:
-            return
+            return cls_name
         value_type = c_args[0]
         dc_no_defaults = self.erase_recursive(c_args[1])
         if self.normalize(dc_no_defaults) != self.normalize(
                 templates.join(default_container_name, [value_type])):
-            return
+            return None
         return templates.join(
             c_name, [self.erase_recursive(value_type)])
 
@@ -130,10 +141,9 @@ def erase_container_compare(
             cls_name,
             default_container_name='std::vector',
             default_compare='std::less'):
-        cls_name = self.replace_basic_string(cls_name)
         c_name, c_args = templates.split(cls_name)
         if len(c_args) != 3:
-            return
+            return cls_name
         dc_no_defaults = self.erase_recursive(c_args[1])
         if self.normalize(dc_no_defaults) != self.normalize(
                 templates.join(default_container_name, [c_args[0]])):
@@ -150,10 +160,9 @@ def erase_compare_allocator(
             cls_name,
             default_compare='std::less',
             default_allocator='std::allocator'):
-        cls_name = self.replace_basic_string(cls_name)
         c_name, c_args = templates.split(cls_name)
         if len(c_args) != 3:
-            return
+            return cls_name
         value_type = c_args[0]
         tmpl = string.Template(
             "$container< $value_type, $compare<$value_type>, " +
@@ -173,10 +182,9 @@ def erase_map_compare_allocator(
             cls_name,
             default_compare='std::less',
             default_allocator='std::allocator'):
-        cls_name = self.replace_basic_string(cls_name)
         c_name, c_args = templates.split(cls_name)
         if len(c_args) != 4:
-            return
+            return cls_name
         key_type = c_args[0]
         mapped_type = c_args[1]
         tmpls = [
@@ -203,10 +211,9 @@ def erase_map_compare_allocator(
                      self.erase_recursive(mapped_type)])
 
     def erase_hash_allocator(self, cls_name):
-        cls_name = self.replace_basic_string(cls_name)
         c_name, c_args = templates.split(cls_name)
         if len(c_args) < 3:
-            return
+            return cls_name
 
         default_less = 'std::less'
         default_equal_to = 'std::equal_to'
@@ -223,7 +230,7 @@ def erase_hash_allocator(self, cls_name):
                 "$container< $value_type, $hash<$value_type >, " +
                 "$equal_to<$value_type >, $allocator<$value_type> >")
         else:
-            return
+            return cls_name
 
         value_type = c_args[0]
         template = string.Template(tmpl)
@@ -241,7 +248,6 @@ def erase_hash_allocator(self, cls_name):
                     c_name, [self.erase_recursive(value_type)])
 
     def erase_hashmap_compare_allocator(self, cls_name):
-        cls_name = self.replace_basic_string(cls_name)
         c_name, c_args = templates.split(cls_name)
 
         if self.unordered_maps_and_sets:
@@ -255,7 +261,7 @@ def erase_hashmap_compare_allocator(self, cls_name):
             key_type = c_args[0]
             mapped_type = c_args[1]
         else:
-            return
+            return cls_name
 
         if len(c_args) == 4:
             default_hash = 'hash_compare'
@@ -302,7 +308,7 @@ def erase_hashmap_compare_allocator(self, cls_name):
                         "$equal_to<$key_type>, " +
                         "$allocator< $mapped_type > >")
         else:
-            return
+            return cls_name
 
         for ns in std_namespaces:
             inst = tmpl.substitute(
@@ -517,15 +523,18 @@ def remove_defaults(self, type_or_string):
                std::vector< int >
 
         """
-
         name = type_or_string
         if not isinstance(type_or_string, str):
+            print(
+                "xxxx",
+                type(self.class_declaration(type_or_string)),
+                self.class_declaration(type_or_string).name
+            )
             name = self.class_declaration(type_or_string).name
         if not self.remove_defaults_impl:
             return name
+        name = _replace_basic_string(name)
         no_defaults = self.remove_defaults_impl(name)
-        if not no_defaults:
-            return name
         return no_defaults
 
 

src/pygccxml/declarations/type_traits.py

@@ -481,7 +481,7 @@ def is_fundamental(type_):
 
 
 def _normalize(string):
-    return string.replace(' ', '').replace("::std", "std")
+    return string.replace(' ', '')
 
 
 def _normalize_equivalences(equivalences):
@@ -490,29 +490,33 @@ def _normalize_equivalences(equivalences):
 
 string_equivalences = [
     (
-        '::std::basic_string<char, std::char_traits<char>, '
+        'std::basic_string<char, std::char_traits<char>, '
         'std::allocator<char>>'
     ),
-    '::std::basic_string<char>',
-    '::std::string'
+    'std::basic_string<char>',
+    'std::string'
     ]
 
 wstring_equivalences = [
     (
-        '::std::basic_string<wchar_t, std::char_traits<wchar_t>, '
+        'std::basic_string<wchar_t, std::char_traits<wchar_t>, '
         'std::allocator<wchar_t>>'
     ),
-    '::std::basic_string<wchar_t>',
-    '::std::wstring'
+    'std::basic_string<wchar_t>',
+    'std::wstring'
     ]
 
 ostream_equivalences = [
-    '::std::basic_ostream<char, std::char_traits<char>>',
-    '::std::basic_ostream<char>', '::std::ostream']
+    'std::basic_ostream<char, std::char_traits<char>>',
+    'std::basic_ostream<char>',
+    'std::ostream'
+    ]
 
 wostream_equivalences = [
-    '::std::basic_ostream<wchar_t, std::char_traits<wchar_t>>',
-    '::std::basic_ostream<wchar_t>', '::std::wostream']
+    'std::basic_ostream<wchar_t, std::char_traits<wchar_t>>',
+    'std::basic_ostream<wchar_t>',
+    'std::wostream'
+    ]
 
 
 normalized_string_equivalences = _normalize_equivalences(