Improve find_noncopyable_vars function (#84)

The find_noncopyable_vars function was wrongly returning
variables of pointer type (non const) as noncopyable variables,
in the case where the pointer was pointing to a noncopyable
class (for example an abstract class, as shown in the test).

Commit cherry-picked from the develop branch.

Author: iMichka

pygccxml/declarations/type_traits_classes.py

@@ -204,6 +204,9 @@ def find_noncopyable_vars(class_type, already_visited_cls_vars=None):
                 logger.debug((message + " - array"), var_type.decl_string)
                 noncopyable_vars.append(mvar)
 
+        if type_traits.is_pointer(var_type):
+            continue
+
         if class_traits.is_my_case(var_type):
 
             cls = class_traits.get_declaration(var_type)

unittests/data/find_noncopyable_vars.hpp

@@ -0,0 +1,13 @@
+// Copyright 2014-2017 Insight Software Consortium.
+// Copyright 2004-2009 Roman Yakovenko.
+// Distributed under the Boost Software License, Version 1.0.
+// See http://www.boost.org/LICENSE_1_0.txt
+
+struct abstract{
+  virtual void do_smth() = 0;
+};
+
+struct holder{
+  abstract* ptr1;
+  abstract* const ptr2;
+};

unittests/test_all.py

@@ -82,6 +82,7 @@
 from . import test_castxml_wrong_epic
 from . import test_elaborated_types
 from . import test_order
+from . import test_find_noncopyable_vars
 
 testers = [
     # , demangled_tester # failing right now
@@ -154,7 +155,8 @@
     test_non_copyable_recursive,
     test_castxml_wrong_epic,
     test_elaborated_types,
-    test_order
+    test_order,
+    test_find_noncopyable_vars
 ]
 
 if platform.system() != 'Windows':

unittests/test_find_noncopyable_vars.py

@@ -0,0 +1,49 @@
+# Copyright 2014-2017 Insight Software Consortium.
+# Copyright 2004-2009 Roman Yakovenko.
+# Distributed under the Boost Software License, Version 1.0.
+# See http://www.boost.org/LICENSE_1_0.txt
+
+import unittest
+
+from . import parser_test_case
+
+from pygccxml import parser
+from pygccxml import declarations
+
+
+class Test(parser_test_case.parser_test_case_t):
+
+    def __init__(self, *args):
+        parser_test_case.parser_test_case_t.__init__(self, *args)
+        self.header = "find_noncopyable_vars.hpp"
+        decls = parser.parse([self.header], self.config)
+        self.global_ns = declarations.get_global_namespace(decls)
+
+    def test(self):
+        """
+        Test the find_noncopyable_vars function
+
+        """
+
+        # The ptr1 variable in the holder struct can be copied,
+        # but not the ptr2 variable
+        holder = self.global_ns.class_("holder")
+        nc_vars = declarations.find_noncopyable_vars(holder)
+        self.assertEqual(len(nc_vars), 1)
+        self.assertEqual(nc_vars[0].name, "ptr2")
+        self.assertTrue(declarations.is_pointer(nc_vars[0].decl_type))
+        self.assertTrue(declarations.is_const(nc_vars[0].decl_type))
+
+
+def create_suite():
+    suite = unittest.TestSuite()
+    suite.addTest(unittest.makeSuite(Test))
+    return suite
+
+
+def run_suite():
+    unittest.TextTestRunner(verbosity=2).run(create_suite())
+
+
+if __name__ == "__main__":
+    run_suite()