it is better to use "os.name" instead of "sys.platform" for platform specific logic - thanks to Aron Xu

Author: roman_yakovenko

docs/history/history.rest

@@ -23,6 +23,7 @@ Thanks to all the people that have contributed patches, bug reports and suggesti
 * Gustavo Carneiro
 * Christopher Bruns
 * Alejandro Dubrovsky
+* Aron Xu
 
 -----------
 SVN Version
@@ -63,6 +64,10 @@ SVN Version
 11. "__int128_t" and "__uint128_t" types were introduced. Many thanks to Gustavo Carneiro
    for providing the patch.
 
+12. Thanks to Aron Xu, for pointing out that it is better to use "os.name",
+    instead of "sys.platform" for platform specific logic
+
+
 -----------
 Version 1.0
 -----------

pygccxml/binary_parsers/undname.py

@@ -73,7 +73,7 @@ class undname_creator_t:
     compiler and demangled name produced by "nm" utility.
     """
     def __init__( self ):
-        if 'win32' in sys.platform:
+        if 'nt' == os.name:
             import ctypes.wintypes
             self.__undname = ctypes.windll.dbghelp.UnDecorateSymbolName
             self.__undname.argtypes = [ctypes.c_char_p, ctypes.c_char_p, ctypes.c_uint, ctypes.c_uint]
@@ -209,7 +209,7 @@ def format_decl(self, decl, hint=None):
         """
         name = None
         if hint is None:
-            if 'win32' in sys.platform:
+            if 'nt' == os.name:
                 hint = 'msvc'
             else:
                 hint = 'nm'

pygccxml/parser/config.py

@@ -173,7 +173,7 @@ def raise_on_wrong_settings( self ):
         super( gccxml_configuration_t, self ).raise_on_wrong_settings()
         if os.path.isfile( self.gccxml_path ):
             return
-        if sys.platform == 'win32':
+        if os.name == 'nt':
             gccxml_name = 'gccxml' + '.exe'
             environment_var_delimiter = ';'
         elif os.name == 'posix':

pygccxml/parser/source_reader.py

@@ -95,7 +95,7 @@ def __create_command_line(self, file, xmlfile):
         #returns
         cmd = []
         #first is gccxml executable
-        if 'win32' in sys.platform:
+        if 'nt' == os.name:
             cmd.append( '"%s"' % os.path.normpath( self.__config.gccxml_path ) )
         else:
             cmd.append(  '%s' % os.path.normpath( self.__config.gccxml_path ) )
@@ -118,7 +118,7 @@ def __create_command_line(self, file, xmlfile):
         if self.__config.compiler:
             cmd.append( " --gccxml-compiler %s" % self.__config.compiler )
         cmd_line = ' '.join(cmd)
-        if 'win32' in sys.platform :
+        if 'nt' == os.name:
             cmd_line = '"%s"' % cmd_line
         self.logger.info( 'gccxml cmd: %s' % cmd_line )
         return cmd_line
@@ -284,7 +284,7 @@ def __file_full_name( self, file ):
         raise RuntimeError( "pygccxml error: file '%s' does not exist" % file )
 
     def __produce_full_file( self, file_path ):
-        if 'win' in sys.platform or 'linux' in sys.platform:
+        if os.name in ['nt', 'posix']:
             file_path = file_path.replace( r'\/', os.path.sep )
         if os.path.isabs( file_path ):
             return file_path

pygccxml/utils/__init__.py

@@ -170,7 +170,7 @@ class native_compiler:
 
     @staticmethod
     def get_version():
-        if 'win' not in sys.platform:
+        if 'nt' != os.name:
             return None #not implemented yet
         else:
             from distutils import msvccompiler

unittests/autoconfig.py

@@ -39,7 +39,7 @@ class cxx_parsers_cfg:
                                                         , compiler=pygccxml.utils.native_compiler.get_gccxml_compiler() )
 
     gccxml.define_symbols.append( gccxml_version )
-    if 'win' in sys.platform:
+    if 'nt' == os.name:
         gccxml.define_symbols.append( '__PYGCCXML_%s__' % gccxml.compiler.upper() )
         if 'msvc9' == gccxml.compiler:
             gccxml.define_symbols.append( '_HAS_TR1=0' )

unittests/complex_types_tester.py

@@ -3,6 +3,7 @@
 # accompanying file LICENSE_1_0.txt or copy at
 # http://www.boost.org/LICENSE_1_0.txt)
 
+import os
 import sys
 import unittest
 import autoconfig
@@ -32,7 +33,7 @@ def test( self ):
 
 def create_suite():
     suite = unittest.TestSuite()
-    if sys.platform != 'win32':
+    if os.name != 'nt':
         suite.addTest( unittest.makeSuite(tester_t))
     return suite
 

unittests/declarations_tester.py

@@ -3,6 +3,7 @@
 # accompanying file LICENSE_1_0.txt or copy at
 # http://www.boost.org/LICENSE_1_0.txt)
 
+import os
 import sys
 import pprint
 import unittest
@@ -205,7 +206,7 @@ def create_suite():
     suite = unittest.TestSuite()
     suite.addTest( unittest.makeSuite(file_by_file_tester_t))
     suite.addTest( unittest.makeSuite(all_at_once_tester_t))
-    #~ if sys.platform == 'win32' and autoconfig.get_pdb_global_ns():
+    #~ if os.name == 'nt' and autoconfig.get_pdb_global_ns():
         #~ suite.addTest( unittest.makeSuite(pdb_based_tester_t))
 
     return suite

unittests/undname_creator_tester.py

@@ -21,7 +21,7 @@ class tester_t( parser_test_case.parser_test_case_t ):
 
     @property
     def known_issues( self ):
-        if 'win32' in sys.platform:
+        if 'nt' == os.name:
             issues = set([
                 # array as function argument: 'int FA10_i_i(int * const)'
                   '?FA10_i_i@@YAHQAH@Z'
@@ -101,7 +101,7 @@ def __tester_impl( self, fname, expected_symbols ):
         for blob in parser.loaded_symbols:
             if isinstance( blob, tuple ):
                 blob = blob[0]
-            if 'win32' in sys.platform:
+            if 'nt' == os.name:
                 #TODO: find out where undecorate function is exposed on linux
                 undname = binary_parsers.undecorate_blob( blob )
                 if "`" in undname:
@@ -131,15 +131,15 @@ def __tester_impl( self, fname, expected_symbols ):
                 self.fail( os.linesep.join(msg) )
 
     def test_map_file( self ):
-        if 'win32' in sys.platform:
+        if 'nt' == os.name:
             self.__tester_impl( self.map_file, 71 )
 
     def test_dll_file( self ):
-        if 'win32' in sys.platform:
+        if 'nt' == os.name:
             self.__tester_impl( self.dll_file, 71 )
 
     def test_z_compare_parsers( self ):
-        if 'win32' not in sys.platform:
+        if 'nt' != os.name:
             return
         dsymbols, dparser = binary_parsers.merge_information( self.global_ns, self.dll_file, runs_under_unittest=True )
         msymbols, mparser = binary_parsers.merge_information( self.global_ns, self.map_file, runs_under_unittest=True )
@@ -158,7 +158,7 @@ def test_z_compare_parsers( self ):
         self.failUnless( was_error == False )
 
     def test_so_file( self ):
-        if 'linux2' in sys.platform:
+        if 'posix' in os.name:
             self.__tester_impl( self.so_file, 64 )
 
     def dont_test_print( self ):