Fix: data loss when parsing Delta to Document (#7)

* Fix: data loss when parsing Delta to Document

* Chore: removed unnecessary annonymous method

* Chore: removed unnecessary validations

---------

Co-authored-by: CatHood0 <santiagowmar@gmail.com>

Author: CatHood0

lib/core/blocks/document.dart

@@ -18,23 +18,30 @@ class Document {
   void insert(Paragraph paragraph) {
     final Paragraph? lastParagraph = paragraphs.lastOrNull;
     if (lastParagraph != null) {
-      if (lastParagraph.isEmpty || (lastParagraph.last?.isEmpty ?? false)) {
-        if (lastParagraph.isSealed) {
-          lastParagraph.unseal();
-        }
+      if (lastParagraph.shouldBreakToNext) {
+        lastParagraph.unseal();
+        lastParagraph
+          ..removeLastLineIfNeeded()
+          ..seal();
+        updateLast(lastParagraph);
+      }
+
+      if (lastParagraph.isEmpty) {
+        lastParagraph.unseal();
         lastParagraph.insertAll(paragraph.lines);
         lastParagraph.setType(paragraph.type);
-        lastParagraph.blockAttributes = lastParagraph.blockAttributes;
+        lastParagraph.blockAttributes = paragraph.blockAttributes;
         if ((lastParagraph.isBlock ||
                 lastParagraph.isEmbed ||
                 lastParagraph.isNewLine) &&
             !lastParagraph.isSealed) {
           lastParagraph.seal(sealLines: true);
         }
-        updateLast(paragraph);
+        updateLast(lastParagraph);
         return;
       }
     }
+
     paragraphs.add(paragraph);
   }
 

lib/core/blocks/paragraph.dart

@@ -61,7 +61,7 @@ class Paragraph {
     String? id,
   })  : _lines = List<Line>.from(lines),
         id = id == null || id.trim().isEmpty ? nanoid(8) : id,
-        _sealed = type == ParagraphType.block
+        _sealed = type == ParagraphType.block || type == ParagraphType.embed
             ? true
             : lines.isNotEmpty && lines.length == 1 && lines.first.isNotEmpty
                 ? lines.first.length > 1
@@ -80,22 +80,37 @@ class Paragraph {
         _sealed = true;
 
   @visibleForTesting
-  factory Paragraph.fragment(TextFragment frag, {String? id}) {
+  factory Paragraph.fragment(
+    TextFragment frag, {
+    String? id,
+    Map<String, dynamic>? blockAttributes,
+  }) {
     return Paragraph.sealed(
       id: id,
       lines: <Line>[
         Line(fragments: <TextFragment>[frag.clone])
       ],
-      type: ParagraphType.inline,
+      type: frag.data is! String
+          ? ParagraphType.embed
+          : frag.data == '\n'
+              ? ParagraphType.lineBreak
+              : blockAttributes != null
+                  ? ParagraphType.block
+                  : ParagraphType.inline,
+      blockAttributes:
+          blockAttributes?.isNotEmpty ?? false ? blockAttributes : null,
     );
   }
 
-  factory Paragraph.withLine({String? id}) {
+  factory Paragraph.withLine({
+    String? id,
+    Iterable<TextFragment>? fragments,
+  }) {
     return Paragraph(
       id: id,
       lines: <Line>[
         Line(
-          fragments: [],
+          fragments: [...?fragments],
         ),
       ],
       type: ParagraphType.inline,
@@ -114,14 +129,14 @@ class Paragraph {
     Map<String, dynamic>? blockAttributes,
     String? id,
   }) {
-    return Paragraph(
+    return Paragraph.sealed(
       id: id,
       lines: <Line>[
         Line.newLine(),
       ],
       blockAttributes: blockAttributes,
       type: ParagraphType.lineBreak,
-    )..seal();
+    );
   }
 
   /// Constructs a [Paragraph] instance from a Object embed.
@@ -132,7 +147,7 @@ class Paragraph {
     Map<String, dynamic>? blockAttributes,
     String? id,
   }) {
-    return Paragraph(
+    return Paragraph.sealed(
       id: id,
       lines: <Line>[
         Line.fromData(data: data, attributes: attributes),
@@ -143,23 +158,31 @@ class Paragraph {
               ? ParagraphType.block
               : ParagraphType.inline
           : ParagraphType.embed,
-    )..seal();
+    );
   }
 
   /// Constructs a [Paragraph] instance from a Quill Delta embed operation.
   ///
   /// This factory method creates a paragraph with a single line from the provided embed operation.
   ///
   /// [operation] is the Quill Delta operation representing the embed.
-  factory Paragraph.fromEmbed(fq.Operation operation, {String? id}) {
-    return Paragraph(
+  factory Paragraph.fromEmbed(
+    fq.Operation operation, {
+    String? id,
+    Map<String, dynamic>? blockAttributes,
+  }) {
+    final bool isInlineOp = operation.data is String;
+    return Paragraph.sealed(
       id: id,
       lines: <Line>[
-        Line.fromData(data: operation.data!, attributes: operation.attributes),
+        Line.fromData(
+          data: operation.data!,
+          attributes: operation.attributes,
+        ),
       ],
-      type:
-          operation.data is String ? ParagraphType.inline : ParagraphType.embed,
-    )..seal();
+      blockAttributes: blockAttributes,
+      type: isInlineOp ? ParagraphType.inline : ParagraphType.embed,
+    );
   }
 
   /// Get all the Lines into this Paragraph

test/flutter_quill_delta_easy_parser_test.dart

@@ -3,14 +3,36 @@ import 'package:flutter_quill_delta_easy_parser/flutter_quill_delta_easy_parser.
 import 'package:flutter_test/flutter_test.dart';
 
 void main() {
+  test('Ensure that is fixed: "Issue: Data Loss When Parsing Document #33"', () {
+    final Delta delta = Delta()
+      ..insert("My delta can innovate all of the existent editors\n")
+      ..insert({"img": "path"})
+      ..insert('\n\n\n');
+
+    final Document expectedDocument = Document(
+      paragraphs: [
+        Paragraph.fragment(TextFragment(data: "My delta can innovate all of the existent editors")),
+        Paragraph.fragment(TextFragment(
+          data: {"img": "path"},
+        )),
+        Paragraph.newLine(),
+        Paragraph.newLine(),
+        Paragraph.newLine(),
+      ],
+    );
+
+    final Document? parsedDocument = DocumentParser().parseDelta(delta: delta);
+    _execExpects(parsedDocument, expectedDocument);
+  });
+
   test('Should split newlines in two different Paragraphs', () {
     final Delta delta = Delta()
-      ..insert("my_delta\n")
+      ..insert("\n")
       ..insert('\n');
 
     final Document expectedDocument = Document(
       paragraphs: [
-        Paragraph.fragment(TextFragment(data: "my_delta")),
+        Paragraph.newLine(),
         Paragraph.newLine(),
       ],
     );
@@ -327,7 +349,7 @@ void _execExpects(Document? parsedDocument, Document expectedDocument) {
     expect(
       parsedDocument?.paragraphs[i].blockAttributes,
       expectedDocument.paragraphs[i].blockAttributes,
-      reason: 'Block difference at paragraph(index: $i).\n'
+      reason: 'Block difference at paragraph(index: [$i]).\n'
           'Parsed: ${parsedDocument?.paragraphs[i].blockAttributes},\nExpected: ${expectedDocument.paragraphs[i].blockAttributes}',
     );
     expect(