Skip to content

Commit 231cc5f

Browse files
HironsanHironsan
committed
Fix code to pass code review
1 parent 3bb7619 commit 231cc5f

File tree

6 files changed

+29
-29
lines changed

6 files changed

+29
-29
lines changed

‎frontend/api/routes/docs.js

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ router.get('/download', (req, res) => {
4242

4343
// Update a document partially.
4444
router.patch('/:docId', (req, res) => {
45-
const docIndex = db.results.findIndex(item => item.id === parseInt(req.params.docId))
45+
const docIndex = db.results.findIndex(item => item.id === parseInt(req.params.docId, 10))
4646
if (docIndex !== -1) {
4747
Object.assign(db.results[docIndex], req.body)
4848
res.json(db.results[docIndex])
@@ -53,7 +53,7 @@ router.patch('/:docId', (req, res) => {
5353

5454
// Get a doc.
5555
router.get('/:docId', (req, res) => {
56-
const doc = db.results.find(item => item.id === parseInt(req.params.docId))
56+
const doc = db.results.find(item => item.id === parseInt(req.params.docId, 10))
5757
if (doc) {
5858
res.json(doc)
5959
} else {
@@ -63,7 +63,7 @@ router.get('/:docId', (req, res) => {
6363

6464
// Update a doc.
6565
router.put('/:docId', (req, res) => {
66-
const docIndex = db.results.findIndex(item => item.id === parseInt(req.params.docId))
66+
const docIndex = db.results.findIndex(item => item.id === parseInt(req.params.docId, 10))
6767
if (docIndex !== -1) {
6868
db.results[docIndex] = req.body
6969
res.json(db.results[docIndex])
@@ -74,9 +74,9 @@ router.put('/:docId', (req, res) => {
7474

7575
// Delete a doc.
7676
router.delete('/:docId', (req, res, next) => {
77-
const doc = db.results.find(item => item.id === parseInt(req.params.docId))
77+
const doc = db.results.find(item => item.id === parseInt(req.params.docId, 10))
7878
if (doc) {
79-
db.results = db.results.filter(item => item.id !== parseInt(req.params.docId))
79+
db.results = db.results.filter(item => item.id !== parseInt(req.params.docId, 10))
8080
res.json(doc)
8181
} else {
8282
res.status(404).json({ detail: 'Not found.' })
@@ -85,15 +85,15 @@ router.delete('/:docId', (req, res, next) => {
8585

8686
// Add an annotation.
8787
router.post('/:docId/annotations', (req, res, next) => {
88-
const doc = db.results.find(item => item.id === parseInt(req.params.docId))
88+
const doc = db.results.find(item => item.id === parseInt(req.params.docId, 10))
8989
if (doc) {
9090
const annotation = {
9191
id: Math.floor(Math.random() * 10000),
9292
label: req.body.label,
9393
start_offset: req.body.start_offset,
9494
end_offset: req.body.end_offset,
9595
user: 1,
96-
document: parseInt(req.params.docId),
96+
document: parseInt(req.params.docId, 10),
9797
text: req.body.text
9898
}
9999
doc.annotations.push(annotation)
@@ -105,11 +105,11 @@ router.post('/:docId/annotations', (req, res, next) => {
105105

106106
// Delete an annotation.
107107
router.delete('/:docId/annotations/:annotationId', (req, res, next) => {
108-
const doc = db.results.find(item => item.id === parseInt(req.params.docId))
109-
const docIndex = db.results.findIndex(item => item.id === parseInt(req.params.docId))
108+
const doc = db.results.find(item => item.id === parseInt(req.params.docId, 10))
109+
const docIndex = db.results.findIndex(item => item.id === parseInt(req.params.docId, 10))
110110
if (doc) {
111-
const annotation = doc.annotations.find(item => item.id === parseInt(req.params.annotationId))
112-
doc.annotations = doc.annotations.filter(item => item.id !== parseInt(req.params.annotationId))
111+
const annotation = doc.annotations.find(item => item.id === parseInt(req.params.annotationId, 10))
112+
doc.annotations = doc.annotations.filter(item => item.id !== parseInt(req.params.annotationId, 10))
113113
db.results[docIndex] = doc
114114
res.json(annotation)
115115
} else {
@@ -119,10 +119,10 @@ router.delete('/:docId/annotations/:annotationId', (req, res, next) => {
119119

120120
// Update an annotation.
121121
router.patch('/:docId/annotations/:annotationId', (req, res, next) => {
122-
const docIndex = db.results.findIndex(item => item.id === parseInt(req.params.docId))
122+
const docIndex = db.results.findIndex(item => item.id === parseInt(req.params.docId, 10))
123123
if (docIndex !== -1) {
124124
const doc = db.results[docIndex]
125-
const annotationIndex = doc.annotations.findIndex(item => item.id === parseInt(req.params.annotationId))
125+
const annotationIndex = doc.annotations.findIndex(item => item.id === parseInt(req.params.annotationId, 10))
126126
Object.assign(db.results[docIndex].annotations[annotationIndex], req.body)
127127
res.json(db.results[docIndex].annotations[annotationIndex])
128128
} else {

‎frontend/api/routes/labels.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ router.post('/', (req, res) => {
2929

3030
// Get a label.
3131
router.get('/:labelId', (req, res) => {
32-
const label = db.find(item => item.id === parseInt(req.params.labelId))
32+
const label = db.find(item => item.id === parseInt(req.params.labelId, 10))
3333
if (label) {
3434
res.json(label)
3535
} else {
@@ -39,7 +39,7 @@ router.get('/:labelId', (req, res) => {
3939

4040
// Update a label.
4141
router.patch('/:labelId', (req, res) => {
42-
const labelIndex = db.findIndex(item => item.id === parseInt(req.params.labelId))
42+
const labelIndex = db.findIndex(item => item.id === parseInt(req.params.labelId, 10))
4343
if (labelIndex !== -1) {
4444
// db[labelIndex] = req.body
4545
Object.assign(db[labelIndex], req.body)
@@ -51,9 +51,9 @@ router.patch('/:labelId', (req, res) => {
5151

5252
// Delete a label.
5353
router.delete('/:labelId', (req, res, next) => {
54-
const label = db.find(item => item.id === parseInt(req.params.labelId))
54+
const label = db.find(item => item.id === parseInt(req.params.labelId, 10))
5555
if (label) {
56-
db = db.filter(item => item.id !== parseInt(req.params.labelId))
56+
db = db.filter(item => item.id !== parseInt(req.params.labelId, 10))
5757
res.json(label)
5858
} else {
5959
res.status(404).json({ detail: 'Not found.' })

‎frontend/api/routes/members.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ router.get('/', (req, res) => {
1919

2020
// Add a project user.
2121
router.post('/', (req, res) => {
22-
const user = users.find(item => item.id === parseInt(req.body.id))
22+
const user = users.find(item => item.id === parseInt(req.body.id, 10))
2323
const member = {
2424
...user,
2525
role: req.body.role
@@ -30,7 +30,7 @@ router.post('/', (req, res) => {
3030

3131
// Update a project user.
3232
router.put('/:userId', (req, res) => {
33-
const projectIndex = db.findIndex(item => item.id === parseInt(req.params.userId))
33+
const projectIndex = db.findIndex(item => item.id === parseInt(req.params.userId, 10))
3434
if (projectIndex !== -1) {
3535
db[projectIndex] = req.body
3636
res.json(db[projectIndex])
@@ -41,7 +41,7 @@ router.put('/:userId', (req, res) => {
4141

4242
// Partially update a project user.
4343
router.patch('/:userId', (req, res) => {
44-
const projectIndex = db.findIndex(item => item.id === parseInt(req.params.userId))
44+
const projectIndex = db.findIndex(item => item.id === parseInt(req.params.userId, 10))
4545
if (projectIndex !== -1) {
4646
db[projectIndex].role = req.body.role
4747
res.json(db[projectIndex])
@@ -52,9 +52,9 @@ router.patch('/:userId', (req, res) => {
5252

5353
// Delete a project user.
5454
router.delete('/:userId', (req, res, next) => {
55-
const project = db.find(item => item.id === parseInt(req.params.userId))
55+
const project = db.find(item => item.id === parseInt(req.params.userId, 10))
5656
if (project) {
57-
db = db.filter(item => item.id !== parseInt(req.params.userId))
57+
db = db.filter(item => item.id !== parseInt(req.params.userId, 10))
5858
res.json(project)
5959
} else {
6060
res.status(404).json({ detail: 'Not found.' })

‎frontend/api/routes/projects.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ router.post('/', (req, res) => {
3535

3636
// Get a project.
3737
router.get('/:projectId', (req, res) => {
38-
const project = db.find(item => item.id === parseInt(req.params.projectId))
38+
const project = db.find(item => item.id === parseInt(req.params.projectId, 10))
3939
if (project) {
4040
res.json(project)
4141
} else {
@@ -45,7 +45,7 @@ router.get('/:projectId', (req, res) => {
4545

4646
// Update a project.
4747
router.put('/:projectId', (req, res) => {
48-
const projectIndex = db.findIndex(item => item.id === parseInt(req.params.projectId))
48+
const projectIndex = db.findIndex(item => item.id === parseInt(req.params.projectId, 10))
4949
if (projectIndex !== -1) {
5050
db[projectIndex] = req.body
5151
res.json(db[projectIndex])
@@ -56,7 +56,7 @@ router.put('/:projectId', (req, res) => {
5656

5757
// Partially update a project user.
5858
router.patch('/:projectId', (req, res) => {
59-
const projectIndex = db.findIndex(item => item.id === parseInt(req.params.projectId))
59+
const projectIndex = db.findIndex(item => item.id === parseInt(req.params.projectId, 10))
6060
if (projectIndex !== -1) {
6161
Object.assign(db[projectIndex], req.body)
6262
res.json(db[projectIndex])
@@ -67,9 +67,9 @@ router.patch('/:projectId', (req, res) => {
6767

6868
// Delete a project.
6969
router.delete('/:projectId', (req, res, next) => {
70-
const project = db.find(item => item.id === parseInt(req.params.projectId))
70+
const project = db.find(item => item.id === parseInt(req.params.projectId, 10))
7171
if (project) {
72-
db = db.filter(item => item.id !== parseInt(req.params.projectId))
72+
db = db.filter(item => item.id !== parseInt(req.params.projectId, 10))
7373
res.json(project)
7474
} else {
7575
res.status(404).json({ detail: 'Not found.' })

‎frontend/api/routes/stats.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const fs = require('fs')
22
const express = require('express')
33
const router = express.Router()
4-
let db = JSON.parse(fs.readFileSync('./api/db/stats.json', 'utf8'))
4+
const db = JSON.parse(fs.readFileSync('./api/db/stats.json', 'utf8'))
55

66
// Get statistics.
77
router.get('/', (req, res) => {

‎frontend/api/routes/users.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ router.get('/', (req, res) => {
1515

1616
// Get a user.
1717
router.get('/:userId', (req, res) => {
18-
const user = db.find(item => item.id === parseInt(req.params.userId))
18+
const user = db.find(item => item.id === parseInt(req.params.userId, 10))
1919
if (user) {
2020
res.json(user)
2121
} else {

0 commit comments

Comments
 (0)