Improve performance of by-name lookup (#8)

* Improve performance of by-name lookup

* Consistency fix: make array handling like getById

* Remove unnecessary like condition

Author: c-w

controllers/features.js

@@ -53,7 +53,7 @@ exports.getByPoint = function(req, res) {
 
 exports.getByName = function(req, res) {
     let query = {
-        name: req.params.name,
+        name: req.params.name.split(','),
         include: req.query.include
     };
 

schema.sql

@@ -24,6 +24,7 @@ CREATE TABLE features
 );
 
 CREATE INDEX features_hull_index ON features USING gist (hull);
+CREATE INDEX features_name_lower_index ON features(lower(name));
 
 GRANT SELECT, UPDATE, INSERT, DELETE ON features TO frontend;
 

services/features.js

@@ -133,7 +133,11 @@ function getByPoint(query, callback) {
 }
 
 function getByName(query, callback) {
-    let namesDisjunction = query.name.split(',').map(function(name) { return `name ilike ${escapeSql(name)}`; }).join(" OR ");
+    const names = query.name.constructor === Array ? query.name : [query.name];
+
+    let namesDisjunction = names.map(function(name) {
+        return `lower(name) = ${escapeSql(name.toLowerCase())}`;
+    }).join(" OR ");
     let nameQuery = `SELECT ${buildQueryColumns(query)} FROM features WHERE ${namesDisjunction}`;
 
     if (query.layer) {