Merge pull request #20 from CatalystCode/security_review

Remove unused endpoints and code per security review

Author: c-w

controllers/features.js

@@ -4,22 +4,6 @@ const common = require('service-utils'),
       HttpStatus = require('http-status-codes'),
       services = require('../services');
 
-/*
-exports.upsert = function(req, res) {
-    services.features.fromJsonApi(req.body, function(err, activity) {
-        if (err) return common.utils.handleError(res, err);
-
-        services.features.create(features, function(err) {
-            if (err) return common.utils.handleError(res, err);
-
-            services.features.toJsonApi(feature, function(featureJson) {
-                res.send(activityJson);
-            });
-        });
-    });
-};
-*/
-
 exports.getById = function(req, res) {
     let query = {
         id: req.params.id.split(','),
@@ -97,4 +81,4 @@ exports.getByBoundingBox = function(req, res) {
             features: features
         });
     });
-};
+};

controllers/index.js

@@ -1,5 +1,3 @@
 module.exports = {
-    features:       require('./features'),
-    ops:            require('./ops'),
-    visits:         require('./visits')
+    features:       require('./features')
 };

controllers/ops.js

@@ -20,12 +20,6 @@ app.get('/features/bbox/:north/:west/:south/:east', controllers.features.getByBo
 app.get('/features/point/:latitude/:longitude',     controllers.features.getByPoint);
 app.get('/features/name/:name',                     controllers.features.getByName);
 
-app.get('/visits/:userId',                          controllers.visits.get);
-app.put('/visits/:userId',                          controllers.visits.put);
-
-app.get('/ops/health',                              controllers.ops.health);
-app.get('/',                                        controllers.ops.health);
-
 services.init(function(err) {
     if (err) {
         return log.error('failed to initialize: ' + err);

controllers/visits.js

@@ -1,12 +1,10 @@
 "use strict"
 
 const async = require('async'),
-      features = require('./features'),
-      visits = require('./visits');
+      features = require('./features');
 
 const submodules = [
-    features,
-    visits
+    features
 ];
 
 function init(callback) {
@@ -15,6 +13,5 @@ function init(callback) {
 
 module.exports = {
     features:   features,
-    init:       init,
-    visits:     visits
+    init:       init
 };

deployment_sha

@@ -22,12 +22,6 @@ let fixtures = {
             "coordinates":[[[[-22.8724103,16.6696193],[-22.924919,16.585595],[-22.9840127,16.8273509],[-22.8892456,16.8339415],[-22.8724103,16.6696193]]]]
         }
     },
-    visit: {
-        userId: '747941cfb829',
-        featureId: '93de94d6-6561-446f-9a33-c1761b029bd5',
-        start: new Date(2016,12,13,16,09).getTime(),
-        finish: new Date(2016,12,13,16,19).getTime()
-    },
     location: {
         timestamp: new Date(2016,5,15).getTime(),
         userId: '747941cfb829',
@@ -85,14 +79,7 @@ let fixtures = {
             speed: 6.02
         }
     ],
-    intersections: [{
-        userId: '747941cfb829',
-        features: [
-            { id: '93de94d6-6561-446f-9a33-c1761b029bd5' }
-        ],
-        timestamp: new Date(2016, 12, 13, 16, 09).getTime()
-    }],
     userId: '747941cfb829'
 };
 
-module.exports = fixtures;
+module.exports = fixtures;