Fixed boolean conversion issue and updated docs.

Author: phongcao

android/src/main/java/com/azure/reactnative/notificationhub/ReactNativeUtil.java

@@ -85,6 +85,8 @@ public static WritableMap convertBundleToMap(Bundle bundle) {
                     map.putInt(key, ((Short) o).intValue());
                 } else if (o instanceof Byte) {
                     map.putInt(key, ((Byte) o).intValue());
+                } else if (o instanceof Boolean) {
+                    map.putBoolean(key, (Boolean) o);
                 } else {
                     map.putNull(key);
                 }

docs/android-installation.md

@@ -181,9 +181,9 @@ import {
 const NotificationHub = require('react-native-azurenotificationhub');
 const PushNotificationEmitter = new NativeEventEmitter(NotificationHub);
 
-const NOTIF_REGISTER_AZURE_HUB_EVENT = 'azureNotificationHubRegistered';
-const NOTIF_AZURE_HUB_REGISTRATION_ERROR_EVENT = 'azureNotificationHubRegistrationError';
-const DEVICE_NOTIF_EVENT = 'remoteNotificationReceived';
+const EVENT_AZURE_NOTIFICATION_HUB_REGISTERED           = 'azureNotificationHubRegistered';
+const EVENT_AZURE_NOTIFICATION_HUB_REGISTERED_ERROR     = 'azureNotificationHubRegisteredError';
+const EVENT_REMOTE_NOTIFICATION_RECEIVED                = 'remoteNotificationReceived';
 
 const connectionString = '...';       // The Notification Hub connection string
 const hubName = '...';                // The Notification Hub name
@@ -201,12 +201,12 @@ const channelEnableVibration = true;
 export default class App extends Component {
   constructor(props) {
     super(props);
-    PushNotificationEmitter.addListener(DEVICE_NOTIF_EVENT, this._onRemoteNotification);
+    PushNotificationEmitter.addListener(EVENT_REMOTE_NOTIFICATION_RECEIVED, this._onRemoteNotification);
   }
 
   register() {
-    PushNotificationEmitter.addListener(NOTIF_REGISTER_AZURE_HUB_EVENT, this._onAzureNotificationHubRegistered);
-    PushNotificationEmitter.addListener(NOTIF_AZURE_HUB_REGISTRATION_ERROR_EVENT, this._onAzureNotificationHubRegistrationError);
+    PushNotificationEmitter.addListener(EVENT_AZURE_NOTIFICATION_HUB_REGISTERED, this._onAzureNotificationHubRegistered);
+    PushNotificationEmitter.addListener(EVENT_AZURE_NOTIFICATION_HUB_REGISTERED_ERROR, this._onAzureNotificationHubRegisteredError);
 
     NotificationHub.register({
       connectionString,
@@ -251,13 +251,12 @@ export default class App extends Component {
     console.warn('RegistrationID: ' + registrationID);
   }
 
-  _onAzureNotificationHubRegistrationError(error) {
+  _onAzureNotificationHubRegisteredError(error) {
     console.warn('Error: ' + error);
   }
 
   _onRemoteNotification(notification) {
-    // Note notification will be a JSON string for android
-    console.warn('Notification received: ' + notification);
+    console.warn(notification);
   }
 }
 

sample/android/app/src/test/java/com/reactnativeazurenotificationhubsample/ReactNativeUtilTest.java

@@ -21,6 +21,7 @@
 
 import static com.azure.reactnative.notificationhub.ReactNativeNotificationHubUtil.*;
 import static com.azure.reactnative.notificationhub.ReactNativeConstants.*;
+import static org.mockito.ArgumentMatchers.anyBoolean;
 import static org.mockito.ArgumentMatchers.anyDouble;
 import static org.mockito.ArgumentMatchers.anyFloat;
 import static org.mockito.ArgumentMatchers.anyInt;
@@ -113,6 +114,7 @@ public void testConvertBundleToMapNullArgument() {
         verify(expectedMap, times(0)).putDouble(anyString(), anyDouble());
         verify(expectedMap, times(0)).putDouble(anyString(), anyFloat());
         verify(expectedMap, times(0)).putInt(anyString(), anyInt());
+        verify(expectedMap, times(0)).putBoolean(anyString(), anyBoolean());
         verify(expectedMap, times(0)).putNull(anyString());
     }
 
@@ -184,6 +186,13 @@ public void testConvertBundleToMap() {
         convertBundleToMap(mBundle);
         verify(expectedMap, times(1)).putInt(key, byteValue.intValue());
 
+        reset(expectedMap);
+        when(mBundle.keySet()).thenReturn(keys);
+        final Boolean booleanValue = new Boolean(true);
+        when(mBundle.get(key)).thenReturn(booleanValue);
+        convertBundleToMap(mBundle);
+        verify(expectedMap, times(1)).putBoolean(key, booleanValue);
+
         reset(expectedMap);
         when(mBundle.keySet()).thenReturn(keys);
         when(mBundle.get(key)).thenReturn(new HashMap<>());