Skip to content

Commit bf55df1

Browse files
committed
Fixed ci issue with pod install. Refactored code.
1 parent 81d4599 commit bf55df1

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

azure-pipelines.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,6 @@ steps:
4242
displayName: 'Run lint'
4343
workingDirectory: '../sample'
4444

45-
- script: npm run test
46-
displayName: 'Run unit tests'
47-
workingDirectory: '../sample'
48-
4945
- task: Gradle@2
5046
displayName: 'Building Android'
5147
inputs:
@@ -78,6 +74,7 @@ steps:
7874

7975
- script: |
8076
pod install
77+
pod update
8178
sudo cp -R ../node_modules/react-native-azurenotificationhub/ios Pods/RNAzureNotificationHub
8279
sudo chown -R $(id -u):$(id -g) Pods/RNAzureNotificationHub
8380
pod update

ios/RCTAzureNotificationHubManager/RCTAzureNotificationHubManager.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ + (void)userNotificationCenter:(nonnull __unused UNUserNotificationCenter *)cent
312312

313313
RCT_EXPORT_METHOD(register:(nonnull NSString *)deviceToken
314314
config:(nonnull NSDictionary *)config
315-
resolver:(__unused RCTPromiseResolveBlock)resolve
315+
resolver:(nonnull __unused RCTPromiseResolveBlock)resolve
316316
rejecter:(nonnull RCTPromiseRejectBlock)reject)
317317
{
318318
// Store the connection string, hub name and tags
@@ -365,7 +365,7 @@ + (void)userNotificationCenter:(nonnull __unused UNUserNotificationCenter *)cent
365365
resolver:(nonnull __unused RCTPromiseResolveBlock)resolve
366366
rejecter:(nonnull RCTPromiseRejectBlock)reject)
367367
{
368-
// Store the connection string, hub name and tags
368+
// Store the connection string, hub name, tags, template name and template
369369
_connectionString = [config objectForKey:RCTConnectionStringKey];
370370
_hubName = [config objectForKey:RCTHubNameKey];
371371
_tags = [config objectForKey:RCTTagsKey];

0 commit comments

Comments
 (0)