fix: in rare cases, compare could be called on partial initialized object

Author: davhdavh

Catglobe.ResXFileCodeGenerator.Tests/Catglobe.ResXFileCodeGenerator.Tests.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFramework>net9.0</TargetFramework>

Catglobe.ResXFileCodeGenerator.Tests/GroupResxFilesTests.cs

@@ -171,6 +171,26 @@ public void FileGrouping()
         }
     }
 
+    [Fact]
+    public void ResxFile_EqualityOperators_ShouldWorkCorrectly()
+    {
+        var file1 = new ResxFile("Base1", null, null, SourceText.From("Content1"), ImmutableEquatableArray<byte>.Empty, new AdditionalTextStub("Path1"));
+        var file2 = new ResxFile("Base1", null, null, SourceText.From("Content1"), ImmutableEquatableArray<byte>.Empty, new AdditionalTextStub("Path1"));
+        var file3 = new ResxFile("Base2", null, null, SourceText.From("Content2"), ImmutableEquatableArray<byte>.Empty, new AdditionalTextStub("Path2"));
+        ResxFile? fileNull = null;
+
+        (file1 == file2).ShouldBeTrue();
+        (file1 == file3).ShouldBeFalse();
+        (file1 != file3).ShouldBeTrue();
+        (file1 != file2).ShouldBeFalse();
+
+        // Null checks
+        (file1 == fileNull).ShouldBeFalse();
+        (file1 != fileNull).ShouldBeTrue();
+        (fileNull == null).ShouldBeTrue();
+        (fileNull != null).ShouldBeFalse();
+    }
+
 }
 
 

Catglobe.ResXFileCodeGenerator/ResxFile.cs

@@ -2,7 +2,7 @@
 
 namespace Catglobe.ResXFileCodeGenerator;
 
-internal sealed record ResxFile(string Basename, CultureInfo? Culture, string? CultureIso, SourceText Content, ImmutableEquatableArray<byte> ContentHash, AdditionalText File) : IEquatable<ResxFile>
+internal sealed record ResxFile(string Basename, CultureInfo? Culture, string? CultureIso, SourceText Content, ImmutableEquatableArray<byte> ContentHash, AdditionalText File)
 {
 	public bool Equals(ResxFile? other)
 	{
@@ -29,7 +29,7 @@ public override int GetHashCode()
 			return hashCode;
 		}
 	}
-
+	
 	public override string ToString() => $"{nameof(Basename)}: {Basename}, {nameof(CultureIso)}: {CultureIso}, {nameof(Culture)}: {Culture?.LCID}";
 
 	public static ResxFile? From(AdditionalText file, CancellationToken ct = default)

Catglobe.ResXFileCodeGenerator/ResxGroup.cs

@@ -20,6 +20,8 @@ internal sealed record ResxGroup
 		isEnabledByDefault: true
 	);
 
+	private readonly ResxFile? _mainFile;
+
 	/// <summary>
 	/// Basename is the name of the file without culture and filetype
 	/// </summary>
@@ -28,7 +30,7 @@ internal sealed record ResxGroup
 	/// <summary>
 	/// MainFile is the file without culture
 	/// </summary>
-	public ResxFile MainFile { get; }
+	public ResxFile MainFile => _mainFile!;
 
 	/// <summary>
 	/// SubFiles are ordered by culture LCID
@@ -42,7 +44,7 @@ internal sealed record ResxGroup
 
 	public ResxGroup(IReadOnlyList<ResxFile> resx)
 	{
-		MainFile = null!;
+		_mainFile = null;
 		SubFiles = ImmutableEquatableArray<ResxFile>.Empty;
 		try
 		{
@@ -57,7 +59,7 @@ public ResxGroup(IReadOnlyList<ResxFile> resx)
 				return;
 			}
 
-			MainFile = mainFile;
+			_mainFile = mainFile;
 		}
 		catch
 		{
@@ -84,22 +86,22 @@ public bool Equals(ResxGroup? other)
 			return true;
 		}
 
-		return Basename == other.Basename && MainFile.Equals(other.MainFile) && SubFiles.Equals(other.SubFiles);
+		return Basename == other.Basename && _mainFile == other._mainFile && SubFiles.Equals(other.SubFiles);
 	}
 
 	public override int GetHashCode()
 	{
 		unchecked
 		{
 			var hashCode = Basename.GetHashCode();
-			hashCode = (hashCode * 397) ^ MainFile.GetHashCode();
+			hashCode = (hashCode * 397) ^ (_mainFile?.GetHashCode() ?? 0);
 			hashCode = (hashCode * 397) ^ SubFiles.GetHashCode();
 			return hashCode;
 		}
 	}
 
 	public override string ToString()
 	{
-		return $"{nameof(MainFile)}: {MainFile}, {nameof(SubFiles)}: {string.Join("; ", SubFiles)}";
+		return $"{nameof(MainFile)}: {_mainFile}, {nameof(SubFiles)}: {string.Join("; ", SubFiles)}";
 	}
 }