Skip to content

Commit 9d9c4bc

Browse files
committed
Fixed failing xml tests
1 parent a1416ec commit 9d9c4bc

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

src/Catty/XML/XMLHandler/SpriteObject/SpriteObject+CBXMLHandler.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ + (instancetype)parseFromElement:(GDataXMLElement*)xmlElement withContext:(CBXML
7878
[XMLError exceptionIfNode:referencedObjectElement isNilOrNodeNameNotEquals:@"object"];
7979
} else if([referencedObjectElement.name isEqualToString:@"destinationSprite"]) {
8080
[XMLError exceptionIfNode:referencedObjectElement isNilOrNodeNameNotEquals:@"destinationSprite"];
81-
} if ([referencedObjectElement.name isEqualToString:@"objectToClone"]) {
81+
} else if ([referencedObjectElement.name isEqualToString:@"objectToClone"]) {
8282
[XMLError exceptionIfNode:referencedObjectElement isNilOrNodeNameNotEquals:@"objectToClone"];
8383
} else {
8484
[XMLError exceptionIfNode:referencedObjectElement isNilOrNodeNameNotEquals:@"pointedObject"];

src/CattyTests/Resources/ParserTests/Custom/ValidProjectAllBricks/ValidProjectAllBricks0992.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -775,11 +775,11 @@
775775
<brick type="CloneBrick">
776776
<commentedOut>false</commentedOut>
777777
</brick>
778-
</brickList>
779-
<brick type="CloneBrick">
778+
<brick type="CloneBrick">
780779
<commentedOut>false</commentedOut>
781780
<objectToClone reference="../../../../../../object[1]"/>
782781
</brick>
782+
</brickList>
783783
<commentedOut>false</commentedOut>
784784
<isUserScript>false</isUserScript>
785785
</script>

src/CattyTests/XML/Parser/CatrobatLanguage0.992/XMLParserTests0992.swift

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,4 +411,15 @@ class XMLParserTests0992: XMLAbstractTest {
411411

412412
XCTAssertTrue(setTempoToBrick.isKind(of: SetTempoToBrick.self), "Invalid brick type")
413413
}
414+
415+
func testCreateCloneOfBrick() {
416+
let project = self.getProjectForXML(xmlFile: "ValidProjectAllBricks0992")
417+
var createCloneOfBrick = (project.scene.object(at: 1)!.scriptList.object(at: 0) as! Script).brickList.object(at: 6) as! Brick
418+
419+
XCTAssertTrue(createCloneOfBrick.isKind(of: CloneBrick.self), "Invalid brick type")
420+
421+
createCloneOfBrick = (project.scene.object(at: 1)!.scriptList.object(at: 0) as! Script).brickList.object(at: 7) as! Brick
422+
423+
XCTAssertTrue(createCloneOfBrick.isKind(of: CloneBrick.self), "Invalid brick type")
424+
}
414425
}

0 commit comments

Comments
 (0)