Skip to content

Commit e5938a6

Browse files
committed
chore: 코드 스타일 개선 및 불필요한 공백 제거
1 parent d1f7954 commit e5938a6

File tree

5 files changed

+38
-39
lines changed

5 files changed

+38
-39
lines changed

data_utils/datahub_services/__init__.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
주요 구성요소:
77
- DataHubBaseClient: 기본 연결 및 통신
88
- MetadataService: 메타데이터, 리니지, URN 관련 기능
9-
- QueryService: 쿼리 관련 기능
9+
- QueryService: 쿼리 관련 기능
1010
- GlossaryService: 용어집 관련 기능
1111
"""
1212

@@ -15,9 +15,4 @@
1515
from .query_service import QueryService
1616
from .glossary_service import GlossaryService
1717

18-
__all__ = [
19-
'DataHubBaseClient',
20-
'MetadataService',
21-
'QueryService',
22-
'GlossaryService'
23-
]
18+
__all__ = ["DataHubBaseClient", "MetadataService", "QueryService", "GlossaryService"]

data_utils/datahub_services/base_client.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111

1212
class DataHubBaseClient:
1313
"""DataHub 기본 클라이언트 클래스"""
14-
14+
1515
def __init__(self, gms_server="http://localhost:8080", extra_headers={}):
1616
"""
1717
DataHub 클라이언트 초기화
18-
18+
1919
Args:
2020
gms_server (str): DataHub GMS 서버 URL
2121
extra_headers (dict): 추가 HTTP 헤더
@@ -26,7 +26,7 @@ def __init__(self, gms_server="http://localhost:8080", extra_headers={}):
2626

2727
self.gms_server = gms_server
2828
self.extra_headers = extra_headers
29-
29+
3030
# DataHub 클라이언트 초기화
3131
self.emitter = DatahubRestEmitter(
3232
gms_server=gms_server, extra_headers=extra_headers
@@ -36,10 +36,10 @@ def __init__(self, gms_server="http://localhost:8080", extra_headers={}):
3636
def _is_valid_gms_server(self, gms_server):
3737
"""
3838
GMS 서버 주소의 유효성을 검사하는 함수
39-
39+
4040
Args:
4141
gms_server (str): 검사할 GMS 서버 URL
42-
42+
4343
Returns:
4444
bool: 서버가 유효한 경우 True
4545
"""
@@ -57,26 +57,26 @@ def _is_valid_gms_server(self, gms_server):
5757
def execute_graphql_query(self, query, variables=None):
5858
"""
5959
GraphQL 쿼리 실행
60-
60+
6161
Args:
6262
query (str): GraphQL 쿼리 문자열
6363
variables (dict, optional): 쿼리 변수
64-
64+
6565
Returns:
6666
dict: GraphQL 응답
6767
"""
6868
headers = {"Content-Type": "application/json"}
6969
payload = {"query": query}
70-
70+
7171
if variables:
7272
payload["variables"] = variables
73-
73+
7474
response = requests.post(
7575
f"{self.gms_server}/api/graphql",
7676
json=payload,
7777
headers=headers,
7878
)
79-
79+
8080
if response.status_code == 200:
8181
return response.json()
8282
else:
@@ -92,4 +92,4 @@ def get_datahub_graph(self):
9292

9393
def get_urns(self):
9494
"""필터를 적용하여 데이터셋의 URN 가져오기"""
95-
return self.datahub_graph.get_urns_by_filter()
95+
return self.datahub_graph.get_urns_by_filter()

data_utils/datahub_services/glossary_service.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414

1515
class GlossaryService:
1616
"""용어집 관련 서비스 클래스"""
17-
17+
1818
def __init__(self, client: DataHubBaseClient):
1919
"""
2020
용어집 서비스 초기화
21-
21+
2222
Args:
2323
client (DataHubBaseClient): DataHub 기본 클라이언트
2424
"""
@@ -191,4 +191,4 @@ def get_glossary_terms_by_urn(self, dataset_urn):
191191
dict: glossary terms 정보
192192
"""
193193
variables = {"urn": dataset_urn}
194-
return self.client.execute_graphql_query(GLOSSARY_TERMS_BY_URN_QUERY, variables)
194+
return self.client.execute_graphql_query(GLOSSARY_TERMS_BY_URN_QUERY, variables)

data_utils/datahub_services/metadata_service.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@
44
테이블 메타데이터, 리니지, URN 관련 기능을 제공합니다.
55
"""
66

7-
from datahub.metadata.schema_classes import DatasetPropertiesClass, SchemaMetadataClass, UpstreamLineageClass
7+
from datahub.metadata.schema_classes import (
8+
DatasetPropertiesClass,
9+
SchemaMetadataClass,
10+
UpstreamLineageClass,
11+
)
812
from datahub.ingestion.graph.client import DatahubClientConfig, DataHubGraph
913
from collections import defaultdict
1014

@@ -13,11 +17,11 @@
1317

1418
class MetadataService:
1519
"""메타데이터 관련 서비스 클래스"""
16-
20+
1721
def __init__(self, client: DataHubBaseClient):
1822
"""
1923
메타데이터 서비스 초기화
20-
24+
2125
Args:
2226
client (DataHubBaseClient): DataHub 기본 클라이언트
2327
"""
@@ -309,4 +313,4 @@ def _print_urn_details(self, metadata):
309313
print(
310314
f" {col['upstream_column']}{col['downstream_column']} (신뢰도: {confidence})"
311315
)
312-
print()
316+
print()

data_utils/datahub_services/query_service.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313

1414
class QueryService:
1515
"""쿼리 관련 서비스 클래스"""
16-
16+
1717
def __init__(self, client: DataHubBaseClient):
1818
"""
1919
쿼리 서비스 초기화
20-
20+
2121
Args:
2222
client (DataHubBaseClient): DataHub 기본 클라이언트
2323
"""
@@ -107,7 +107,7 @@ def get_query_data(self, start=0, count=10, query="*", filters=None):
107107
def get_queries_by_urn(self, dataset_urn):
108108
"""
109109
특정 데이터셋 URN과 연관된 쿼리들을 조회하는 함수
110-
110+
111111
전체 쿼리를 가져온 후 클라이언트 사이드에서 필터링하는 방식 사용
112112
113113
Args:
@@ -117,31 +117,31 @@ def get_queries_by_urn(self, dataset_urn):
117117
dict: 연관된 쿼리 목록
118118
"""
119119
# 먼저 전체 쿼리 목록을 가져옴
120-
input_params = {
121-
"start": 0,
122-
"count": 1000, # 충분히 큰 수로 설정
123-
"query": "*"
124-
}
120+
input_params = {"start": 0, "count": 1000, "query": "*"} # 충분히 큰 수로 설정
125121

126122
variables = {"input": input_params}
127123
result = self.client.execute_graphql_query(QUERIES_BY_URN_QUERY, variables)
128124

129-
if "error" not in result and "data" in result and "listQueries" in result["data"]:
125+
if (
126+
"error" not in result
127+
and "data" in result
128+
and "listQueries" in result["data"]
129+
):
130130
# 클라이언트 사이드에서 특정 URN과 연관된 쿼리만 필터링
131131
all_queries = result["data"]["listQueries"]["queries"]
132132
filtered_queries = []
133-
133+
134134
for query in all_queries:
135135
subjects = query.get("subjects", [])
136136
for subject in subjects:
137137
if subject.get("dataset", {}).get("urn") == dataset_urn:
138138
filtered_queries.append(query)
139139
break
140-
140+
141141
# 필터링된 결과로 응답 구조 재구성
142142
result["data"]["listQueries"]["queries"] = filtered_queries
143143
result["data"]["listQueries"]["count"] = len(filtered_queries)
144-
144+
145145
return result
146146

147147
def get_glossary_terms_by_urn(self, dataset_urn):
@@ -155,6 +155,6 @@ def get_glossary_terms_by_urn(self, dataset_urn):
155155
dict: glossary terms 정보
156156
"""
157157
from data_utils.queries import GLOSSARY_TERMS_BY_URN_QUERY
158-
158+
159159
variables = {"urn": dataset_urn}
160-
return self.client.execute_graphql_query(GLOSSARY_TERMS_BY_URN_QUERY, variables)
160+
return self.client.execute_graphql_query(GLOSSARY_TERMS_BY_URN_QUERY, variables)

0 commit comments

Comments
 (0)