chore: share those Sets that are only modified during initialization

Author: CedaryCat

src/OTAPI.UnifiedServerProcess.GlobalNetwork/Network/SyncHelper.cs

@@ -60,7 +60,7 @@ static void SendWorldEntities(this ServerContext server, int whoAmI) {
                 }
             }
             for (int i = 0; i < Terraria.Main.maxProjectiles; i++) {
-                if (server.Main.projectile[i].active && (server.Main.projPet[server.Main.projectile[i].type] || server.Main.projectile[i].netImportant)) {
+                if (server.Main.projectile[i].active && (Main.projPet[server.Main.projectile[i].type] || server.Main.projectile[i].netImportant)) {
                     server.NetMessage.TrySendData(MessageID.SyncProjectile, whoAmI, -1, null, i);
                 }
             }

src/OTAPI.UnifiedServerProcess/Core/Analysis/StaticFieldModificationAnalysis/StaticFieldModificationAnalyzer.cs

@@ -40,7 +40,9 @@ public class StaticFieldModificationAnalyzer(ILogger logger,
         readonly ParameterFlowAnalyzer parameterFlowAnalyzer = parameterFlowAnalyzer;
         readonly ParamModificationAnalyzer paramModificationAnalyzer = paramModificationAnalyzer;
         readonly StaticFieldReferenceAnalyzer staticFieldReferenceAnalyzer = staticFieldReferenceAnalyzer;
-        public FieldDefinition[] FetchModifiedFields(params MethodDefinition[] entryPoints) {
+        public FieldDefinition[] FetchModifiedFields(MethodDefinition[] ignoredMethods, params MethodDefinition[] entryPoints) {
+            HashSet<string> ignoredMethodSet = [.. ignoredMethods.Select(m => m.GetIdentifier())];
+
             var workQueue = entryPoints.ToDictionary(m => m.GetIdentifier());
             var visited = new Dictionary<string, MethodDefinition>();
 
@@ -66,6 +68,9 @@ out var addedCallees
 
                     foreach (var callee in addedCallees) {
                         var calleeID = callee.GetIdentifier();
+                        if (ignoredMethodSet.Contains(calleeID)) { 
+                            continue;
+                        }
                         if (visited.ContainsKey(calleeID)) {
                             continue;
                         }

src/OTAPI.UnifiedServerProcess/Core/Infrastructure/CacheManager.cs

@@ -11,14 +11,14 @@ public class CacheManager(ILogger logger) : LoggedComponent(logger)
         public sealed override string Name => "CacheHelper";
         const string unmodifiedStaticFieldCacheFile = "UnmodifiedStaticField.AnalysisCache.txt";
         const string modifiedStaticFieldCacheFile = "ModifiedStaticField.AnalysisCache.txt";
-        public string[] LoadUnmodifiedStaticFields(ModuleDefinition module, AnalyzerGroups analyzers, params MethodDefinition[] entryPoints) {
+        public string[] LoadUnmodifiedStaticFields(ModuleDefinition module, AnalyzerGroups analyzers, MethodDefinition[] ignoredMethods, params MethodDefinition[] entryPoints) {
             if (File.Exists(unmodifiedStaticFieldCacheFile)) {
                 var result = File.ReadAllLines(unmodifiedStaticFieldCacheFile);
                 Info("Loaded cached data ({0}) from: UnmodifiedStaticField.AnalysisCache.txt", $"count: {result.Length}");
                 return result;
             }
 
-            var fields = analyzers.StaticFieldModificationAnalyzer.FetchModifiedFields(entryPoints);
+            var fields = analyzers.StaticFieldModificationAnalyzer.FetchModifiedFields(ignoredMethods, entryPoints);
             File.WriteAllLines(modifiedStaticFieldCacheFile, fields.Select(f => f.FullName));
 
             HashSet<string> modifiedFields = [.. fields.Select(f => f.FullName)];

src/OTAPI.UnifiedServerProcess/Core/PatchingLogic.cs

@@ -21,6 +21,7 @@ public static void Patch(ILogger logger, ModuleDefinition module) {
             var main = module.GetType("Terraria.Main");
 
             var unmodifiedStaticFields = cacheHelper.LoadUnmodifiedStaticFields(module, analyzers,
+                [main.Method("Initialize_TileAndNPCData1"), main.Method("Initialize_TileAndNPCData2")],
                 main.Method(".ctor"),
                 main.Method("DedServ"));