Merge the limb-darkening branch

Author: Askaniy

src/celengine/render.cpp

@@ -1645,6 +1645,8 @@ static void renderSphereUnlit(const RenderInfo& ri,
         shadprop.texUsage |= TexUsage::OverlayTexture;
         textures.push_back(ri.overlayTex);
     }
+    if (ri.isStar)
+        shadprop.lightModel = ShaderProperties::StarModel;
 
     // Get a shader for the current rendering configuration
     auto* prog = r->getShaderManager().getShader(shadprop);
@@ -1656,6 +1658,8 @@ static void renderSphereUnlit(const RenderInfo& ri,
     prog->textureOffset = 0.0f;
     prog->ambientColor = ri.color.toVector3();
     prog->opacity = 1.0f;
+    if (ri.isStar)
+        prog->eyePosition = ri.eyePos_obj;
 
     Renderer::PipelineState ps;
     ps.depthMask = true;
@@ -2206,6 +2210,7 @@ void Renderer::renderObject(const Vector3f& pos,
         }
         else
         {
+            ri.isStar = obj.isStar;
             renderSphereUnlit(ri, viewFrustum, planetMVP, this);
         }
     }
@@ -2832,30 +2837,13 @@ void Renderer::renderStar(const Star& star,
         surface.appearanceFlags |= Surface::ApplyBaseTexture;
         surface.appearanceFlags |= Surface::Emissive;
 
+        rp.isStar = true;
         rp.surface = &surface;
         rp.rings = nullptr;
         rp.radius = star.getRadius();
         rp.semiAxes = star.getEllipsoidSemiAxes();
         rp.geometry = star.getGeometry();
-
-        Atmosphere atmosphere;
-
-        // Use atmosphere effect to give stars a fuzzy fringe
-        if (star.hasCorona() && rp.geometry == InvalidResource)
-        {
-            Color atmColor(color.red() * 0.5f, color.green() * 0.5f, color.blue() * 0.5f);
-            atmosphere.height = radius * CoronaHeight;
-            atmosphere.lowerColor = atmColor;
-            atmosphere.upperColor = atmColor;
-            atmosphere.skyColor = atmColor;
-
-            rp.atmosphere = &atmosphere;
-        }
-        else
-        {
-            rp.atmosphere = nullptr;
-        }
-
+        rp.atmosphere = nullptr;
         rp.orientation = star.getRotationModel()->orientationAtTime(observer.getTime()).cast<float>();
 
         renderObject(pos, distance, observer,

src/celengine/render.h

@@ -458,12 +458,15 @@ class Renderer
         Surface* surface{ nullptr };
         const Atmosphere* atmosphere{ nullptr };
         RingSystem* rings{ nullptr };
+        LightingState::EclipseShadowVector* eclipseShadows{ nullptr };
+
+        Eigen::Quaternionf orientation{ Eigen::Quaternionf::Identity() };
+        Eigen::Vector3f semiAxes{ Eigen::Vector3f::Ones() };
         float radius{ 1.0f };
         float geometryScale{ 1.0f };
-        Eigen::Vector3f semiAxes{ Eigen::Vector3f::Ones() };
+
         ResourceHandle geometry{ InvalidResource };
-        Eigen::Quaternionf orientation{ Eigen::Quaternionf::Identity() };
-        LightingState::EclipseShadowVector* eclipseShadows;
+        bool isStar{ false };
     };
 
     struct DepthBufferPartition

src/celengine/renderinfo.h

@@ -21,12 +21,14 @@ class Texture;
 
 struct RenderInfo
 {
+    Eigen::Quaternionf orientation{ Eigen::Quaternionf::Identity() };
     Color color{ 1.0f, 1.0f, 1.0f };
     Texture* baseTex{ nullptr };
     Texture* bumpTex{ nullptr };
     Texture* nightTex{ nullptr };
     Texture* glossTex{ nullptr };
     Texture* overlayTex{ nullptr };
+    Color color{ 1.0f, 1.0f, 1.0f };
     Color specularColor{ 0.0f, 0.0f, 0.0f };
     float specularPower{ 0.0f };
     Eigen::Vector3f sunDir_eye{ Eigen::Vector3f::UnitZ() };
@@ -36,10 +38,9 @@ struct RenderInfo
     Color sunColor{ 1.0f, 1.0f, 1.0f };
     Color ambientColor{ 0.0f, 0.0f, 0.0f };
     float lunarLambert{ 0.0f };
-    Eigen::Quaternionf orientation{ Eigen::Quaternionf::Identity() };
     float pixWidth{ 1.0f };
     float pointScale{ 1.0f };
+    bool isStar{ false };
 };
 
 extern LODSphereMesh* g_lodSphere;
-

src/celengine/shadermanager.cpp

@@ -2093,6 +2093,12 @@ ShaderManager::buildFragmentShader(const ShaderProperties& props)
         source += "gl_FragColor.rgb = gl_FragColor.rgb * scatterEx + scatterColor;\n";
     }
 
+    // Include the effect of limb darkening.
+    if (props.lightModel == ShaderProperties::StarModel)
+    {
+        source += "gl_FragColor.rgb = gl_FragColor.rgb - vec3(1.0 - NV) * vec3(0.56, 0.61, 0.72);\n";
+    }
+
     source += "}\n";
 
     DumpFSSource(source);
@@ -2311,7 +2317,6 @@ ShaderManager::buildAtmosphereFragmentShader(const ShaderProperties& props)
     source += "vec3 nposition = normalize(position);\n";
     source += "vec3 N = normalize(normal);\n";
     source += "vec3 eyeDir = normalize(eyePosition - nposition);\n";
-    source += "float NV = dot(N, eyeDir);\n";
 
     source += DeclareLocal("NL", Shader_Float);
     source += DeclareLocal("scatterEx", Shader_Vector3);
@@ -2326,7 +2331,7 @@ ShaderManager::buildAtmosphereFragmentShader(const ShaderProperties& props)
     // from the line below.
     for (unsigned i = 0; i < std::min(static_cast<unsigned int>(props.nLights), 1u); i++)
     {
-        source += "    float cosTheta = dot(V, " + LightProperty(i, "direction") + ");\n";
+        source += "    float cosTheta = dot(eyeDir, " + LightProperty(i, "direction") + ");\n";
         source += ScatteringPhaseFunctions(props);
 
         // TODO: Consider premultiplying by invScatterCoeffSum

src/celengine/shadermanager.h

@@ -62,6 +62,7 @@ enum class LightingModel : std::uint16_t
     EmissiveModel         = 0x0100,
     ParticleModel         = 0x0200,
     UnlitModel            = 0x0400,
+    StarModel             = 0x0800,
 };
 
 ENUM_CLASS_BITWISE_OPS(LightingModel);