Improve method "update" on "Abstract.pm"

for support use argument with hashref datatype for column and value

Author: yusrideb

lib/CellBIS/SQL/Abstract.pm

@@ -2,6 +2,7 @@ package CellBIS::SQL::Abstract;
 use Mojo::Base -base;
 
 use Scalar::Util qw(blessed);
+use Carp ();
 use Mojo::Util qw(trim);
 use CellBIS::SQL::Abstract::Util;
 use CellBIS::SQL::Abstract::Table;
@@ -62,45 +63,14 @@ sub insert {
 sub update {
   my $self    = shift;
   my $arg_len = scalar @_;
-  my ($table_name, $column, $value, $clause, $type);
-  my $data = '';
-
-  ($table_name, $column, $value, $clause) = @_ if $arg_len == 4;
-  ($table_name, $column, $value, $clause, $type) = @_ if $arg_len >= 5;
-
-  my @table_field  = @{$column};
-  my $field_change = '';
-  my $where_clause = '';
-
-  if ($type && $type eq 'no-pre-st') {
-    my @get_value = $self->QueryUtil->col_with_val($column, $value);
-    $field_change = join ', ', @get_value;
-
-    if (exists $clause->{where}) {
-      $where_clause = $self->QueryUtil->create_clause($clause);
-      $data         = "UPDATE $table_name \nSET $field_change \n$where_clause";
-    }
-
-  }
-  elsif ($type && $type eq 'pre-st') {
-    $field_change = join '=?, ', @table_field;
-    $field_change .= '=?';
-
-    if (exists $clause->{where}) {
-      $where_clause = $self->QueryUtil->create_clause($clause);
-      $data         = "UPDATE $table_name \nSET $field_change \n$where_clause";
-    }
-  }
-  else {
-    my @get_value = $self->QueryUtil->col_with_val($column, $value);
-    $field_change = join ', ', @get_value;
 
-    if (exists $clause->{where}) {
-      $where_clause = $self->QueryUtil->create_clause($clause);
-      $data         = "UPDATE $table_name \nSET $field_change \n$where_clause";
+  if ($arg_len > 2 || $arg_len >= 5) {
+    my $method_name = '_qUpdate_arg' . $arg_len;
+    if ($self->can($method_name)) {
+      return $self->$method_name(@_);
     }
   }
-  return $data;
+  return '';
 }
 
 # For Query Delete :
@@ -158,6 +128,73 @@ sub create_table {
   return $result;
 }
 
+sub _qUpdate_arg3 {
+  my $self = shift;
+  my ($table_name, $col_val, $clause) = @_;
+  my $data = '';
+
+  Carp::croak '$col_val is must be hashref datatype'
+    unless ref $col_val eq "HASH";
+
+  if (exists $clause->{where}) {
+    my @field = map {
+          $col_val->{$_} =~ qr/date|datetime|now|NOW/
+        ? $_ . ' = ' . $col_val->{$_}
+        : $_ . ' = ' . "'"
+        . $col_val->{$_} . "'"
+    } keys %{$col_val};
+    my $field_change = join ', ', @field;
+    my $where_clause = $self->QueryUtil->create_clause($clause);
+    $data = "UPDATE $table_name \nSET $field_change \n$where_clause";
+  }
+  return $data;
+}
+
+sub _qUpdate_arg4 {
+  my $self = shift;
+  my ($table_name, $column, $value, $clause) = @_;
+  my $data = '';
+
+  if (exists $clause->{where}) {
+    my @get_value = $self->QueryUtil->col_with_val($column, $value);
+    my $field_change = join ', ', @get_value;
+    my $where_clause = $self->QueryUtil->create_clause($clause);
+    $data = "UPDATE $table_name \nSET $field_change \n$where_clause";
+  }
+  return $data;
+}
+
+sub _qUpdate_arg5 {
+  my $self = shift;
+  my ($table_name, $column, $value, $clause, $type) = @_;
+  my $data = '';
+
+  my @table_field  = @{$column};
+  my $field_change = '';
+  my $where_clause = '';
+
+  if ($type && $type eq 'no-pre-st') {
+
+    if (exists $clause->{where}) {
+      my @get_value = $self->QueryUtil->col_with_val($column, $value);
+      $field_change = join ', ', @get_value;
+      $where_clause = $self->QueryUtil->create_clause($clause);
+      $data         = "UPDATE $table_name \nSET $field_change \n$where_clause";
+    }
+
+  }
+  else {
+
+    if (exists $clause->{where}) {
+      $field_change = join '=?, ', @table_field;
+      $field_change .= '=?';
+      $where_clause = $self->QueryUtil->create_clause($clause);
+      $data         = "UPDATE $table_name \nSET $field_change \n$where_clause";
+    }
+  }
+  return $data;
+}
+
 # For Action Query String - "select" - arg3 :
 # ------------------------------------------------------------------------
 sub _qSelect_arg3 {

lib/CellBIS/SQL/Abstract.pod

@@ -344,6 +344,26 @@ SQL equivalent :
   # No Prepare Statement :
   UPDATE my_users SET first_name='Achmad Yusri', last_name='Afandi' WHERE id = 2;
 
+=head2 update - with simple
+
+  use CellBIS::SQL::Abstract
+  my $sql_abstract = CellBIS::SQL::Abstract->new;
+
+  my $table_name = 'my_users'; # Table name.
+  my $col_val = {
+    'first_name' => 'Achmad Yusri',
+    'last_name' => 'Afandi'
+  };
+  my $clause = {
+    where => 'id = 2'
+  };
+  my $update = $sql_abstract->update($table_name, $col_val, $clause);
+
+SQL equivalent :
+
+  # No Prepare Statement :
+  UPDATE my_users SET first_name='Achmad Yusri', last_name='Afandi' WHERE id = 2;
+
 =head2 delete
 
   use CellBIS::SQL::Abstract