Cleanup

Author: CelliesProjects

src/dimmerTask.cpp

@@ -34,7 +34,7 @@ void dimmerTask(void *parameter)
 #ifdef LGFX_M5STACK
     static constexpr const int BACKLIGHT_PIN = 32;
     if (!ledcChangeFrequency(BACKLIGHT_PIN, freq, PWM_BITDEPTH) ||
-        !ledcWrite(BACKLIGHT_PIN, LEDC_MAX_VALUE >> 6))
+        !ledcWrite(BACKLIGHT_PIN, LEDC_MAX_VALUE >> 5))
         log_w("Could not capture M5Stack backlight");
 #endif
 
@@ -66,7 +66,7 @@ void dimmerTask(void *parameter)
         vTaskDelayUntil(&xLastWakeTime, ticksToWait);
         const auto msElapsedToday = msSinceMidnight();
 
-        if (msElapsedToday) /* to solve flashing at 00:00:000 due to the fact that the first timer has no predecessor at this time */
+        if (msElapsedToday) /* to prevent flashing at 00:00:000 due to the fact that the first timer has no predecessor at this time */
         {
             std::lock_guard<std::mutex> lock(channelMutex);
 

src/lcdTask.hpp

@@ -1,7 +1,7 @@
 #ifndef _DISPLAY_TASK_
 #define _DISPLAY_TASK_
 
-#include <LovyanGFX.hpp>
+#define LGFX_AUTODETECT
 #include <LGFX_AUTODETECT.hpp>
 
 #include "lcdMessage_t.h"

src/main.cpp

@@ -40,9 +40,8 @@ static void startDimmerTask()
 
 static void ntpCb(void *cb_arg)
 {
-    sntp_set_time_sync_notification_cb(NULL);
-    messageOnLcd("");
     log_i("NTP synced");
+    sntp_set_time_sync_notification_cb(NULL);
     startDimmerTask();
 }
 static void parseTimerFile(File &file)
@@ -170,7 +169,7 @@ void setup(void)
     Serial.begin(115200);
 
 #ifdef LGFX_M5STACK
-    pinMode(DAC1, OUTPUT); // prevents high pitched noise on the builtin speaker which is connected to DAC1
+    pinMode(DAC1, OUTPUT); // prevents high pitched noise on the builtin speaker which is connected to the first DAC
 #endif
 
     log_i("aquacontrol v2");